From patchwork Mon Nov 6 13:30:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 118037 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2770284qgn; Mon, 6 Nov 2017 05:32:20 -0800 (PST) X-Google-Smtp-Source: ABhQp+TJtB4B1gJgDKRs6iTAL5foWSKxa8RPzYnuwJn4BRR6m7xzLFYUO5VFgPQcob5x6kfUDmFp X-Received: by 10.98.150.19 with SMTP id c19mr16547081pfe.239.1509975140375; Mon, 06 Nov 2017 05:32:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1509975140; cv=none; d=google.com; s=arc-20160816; b=zjj8TIRN0r025ktRlEPSb5JZfizuYTK9GiJ4NnyotgLK0ugA3rV77mi+elVUGtmRYo k4rOcjlsLRPVtNOMv80zzn/NkaUV2T2ViC6INOWjJJMlUs0Jv8XWOj659Ist4W3zWHC9 OX23LsqGk1Ep26STZEvJgiWGpTeVV/Z5BQL30TANzgLUYsIs5ZBlbgLK2e3qhpg9Op8b KsPYrKMiEFHVXtoHxleHm4SkfV6eKtV5FKsCPVYfymLthCXfvjCz39G3Qe+c8yaqH6K8 Z/OwwXuqB6iUYepUfdryywtOeiWJDGg4IXoV2Xy6qR01bknf3Tv4UwVwLXuhQZi64KO8 SM8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=UUZ2I7U1Zpc960RRckqSvYr+QTFtjLh24Fl/EEAFDPk=; b=jvr4RiL7Pw5yoUUpLX0uAiy2CB6WCQl+C0z6ZVHf4hHsdwyPXk/XS1LdKPnn+182Wv 0yVLvQl3AU2PFQGM4L1YIdw+cAT11l1QneGWyIy5TABhf7SlEskvUb3eWopSeey4lzzD wpemLvAnTAvqCdAZAybD30z4hDgWY0hShH+LR6+K2PjI56m5X5oBpug8hWmwccJcvQL/ szZXF10Jbt7A6gWyir6wRdatwamcCD3KXBzfr7EdyfoNQQ+H0yNKAUD9IMPhrxIPRnp/ 7s8Owy9pNDokcN7PGv7EflUUQsX7J0SUARkUPr+2MFtcuwRfz0/pc4wcThMehnoYoK7i f3vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m26si10178630pli.525.2017.11.06.05.32.19; Mon, 06 Nov 2017 05:32:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbdKFNcS (ORCPT + 26 others); Mon, 6 Nov 2017 08:32:18 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:50354 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbdKFNcR (ORCPT ); Mon, 6 Nov 2017 08:32:17 -0500 Received: from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MUQni-1ecY2G3sqA-00R2B8; Mon, 06 Nov 2017 14:31:19 +0100 From: Arnd Bergmann To: Mark Brown , Vinod Koul , Guneshwor Singh Cc: Arnd Bergmann , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Naveen Manohar , "Subhransu S. Prusty" , Harsha Priya N , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: intel: initialize return value properly Date: Mon, 6 Nov 2017 14:30:36 +0100 Message-Id: <20171106133114.339667-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:GwUFKiakQGD7rW8DZjNfWJjJFWSrXEKHordrekoFwXiK7oRyVmF HANIiUKsRioDrEClG11rEGcb7bEhod8PyE8AGp9hDIA7QgvgP4ZjKQwi3OQlhV9qVvh+j3K D10xDDjgFUf8T6Aanegbi6Ezbu4rkIC0qY0+53ywyzoGaMplN+YzhXko0JnAzzGx+byXXF6 M1oLZvwyaNjM5/0Vk+XbQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:U3FTiTRJ2N8=:x2e04Wu56dqNSCFDOLc/3O Iwyw1xXilEioIMYDIw1gWCQAOPKF1QLYJPbGLB4WcpZi2W7TzPQMqmfrZxT4+BOsoHN47dcy7 mKpI/3dHlCyk+JgQ+Icw0h5KtcjJa2qZohN5qRq2ykl/w4x0myPC/mWxB0Vwev9zDWEmzRDK6 eDZz1Zwsxo7lCnkIYDiOH3D9EY81ZPY7mhQfo3zfv7+uD6gvnXPDBmr+uhN1FdYajg74dw9SI vMgCLX9Q6IQgJ7CgD28KIvLNwGyR7EIfOtX2FP65oEQ5wQkD2OJmfKm5NFaptpudoObbOEj7x CoXY2zCT7/tVO6V0QoYHcNUS6CGJf70P32KHNLPay2i/FD1iN70WSBSIzUMmrXjQZC+ZayJ4x EjQJtP4vB2a4if84n4reIJaJzU7IT50d760UJkMX/f7xeZ3WRzRgp6/FDR6XUsgjNq1vJrLJN kCNs0SRxX21G/+AiE8KWpPmXqhBk0/F1JxGML6o0pyFk7tP9hEKND169sTM/z8ZJkXrkgawOA mltYZYaAni12ujMvAABz/NqV1xFqBJhz8IAsYXK+EYC5vtOP74rCmSn4EJAuHRq3s9CEz8oNy 3JmFkPNBySbeCg4qkIaLWHFSQJVs7R66TkWWz+xK5P3M5gGpTlIxSQ4SKrNSqNjjiTmn2ySI2 gCGYEmOgX5QF74W09z72z2vSCJvoDfay5f/exN1s9bI7HvnMKR7WbGaVQgrvuayVBas8rTTjs 3O+1pYeJ0Q+IUaUJYE1uAfcJ6eGWqMkDOFa2VA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_SND_SOC_HDAC_HDMI is disabled, we can run into an uninitialized variable: sound/soc/intel/skylake/skl.c: In function 'skl_resume': sound/soc/intel/skylake/skl.c:326:6: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] I have run into this on today's linux-next kernel, but it appears that this is an older problem that was just hard to trigger with randconfig builds as CONFIG_SND_SOC_HDAC_HDMI would in effect be impossible to disable when having SND_SOC_INTEL_SKYLAKE enabled. Signed-off-by: Arnd Bergmann --- sound/soc/intel/skylake/skl.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Acked-By: Vinod Koul diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 31d8634e8aa1..acb0ab470ca6 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -355,6 +355,7 @@ static int skl_resume(struct device *dev) if (ebus->cmd_dma_state) snd_hdac_bus_init_cmd_io(&ebus->bus); + ret = 0; } else { ret = _skl_resume(ebus);