From patchwork Wed Nov 8 21:33:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 118347 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5931348qgn; Wed, 8 Nov 2017 16:13:50 -0800 (PST) X-Google-Smtp-Source: ABhQp+Sy2Mqh81VZdu8ecStRoRqylerTww9/BPTjYAXS4dfE4kls3gv6IaYWjHyBK1aHZXoxzJHv X-Received: by 10.223.184.230 with SMTP id c35mr1812433wrg.18.1510186430454; Wed, 08 Nov 2017 16:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510186430; cv=none; d=google.com; s=arc-20160816; b=PBj4jQdy3V26FtANTSkRrEaWxxocnapLv5gu51daS7wqI/T/tcXD7BTcX3Ur8ki9AE YIO5VNLqysNBxsA7ADJETJOURs6CU1aw38Xboc0u9+0dCeu4+SCkECJzxsXeo8AtVaj8 0bTGPSfyFx6tELDwiXLXqfhux/00/Fnp5s57tM8TyB2bIhpcAzSgk7LIojuJcHK/TgL7 qTCu5KLuvd+L/v9n5DegGRvfsLrIEQO2qE/r/+loe95dkLdm1SaxJq/Xzl1B2HKjf2eP ABEYBX5pej1CRagEUJLFcNqVB2ffCKxAADUJRqVzpcq/WX9fIeLofcGvVDg1+bG4gpAa 0iIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=okh/XBYUMXyp5pey58Pyaofu21uTMKTmFvdGv9PWZLw=; b=pGQUiZhG2RAYyhhTcDw8aZC3FMiBVNF2Dwy7thi6YMaq/LzB9De17v/mV4y2DjMwsa xvUljoHR42NHBSclhI2+yzgjieXEHD5nAJ21s5LRt0MRzqEEKJcIixUfPhOxE4O5v0I8 57exllVDsHv31UKXH0D40uSW+vaqkIFQnbUgHVTfP0GAuK9FwM2ZK0c5QlUG6KzF7eB5 YrQn5JWJsd6gM+eUOmoHPI8Usf7luntKnSeUpFcVDFEl6G9vEiqAeQ3/q/BtUsZwEtdF bml5yy/FU2jibZjQTUC/sn7kFe3wq6DEiUwbaEJdmNQMQrrpZEPucVvp3afeuUCg4N5v VOMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hfNZzGZI; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id c38si82181wrc.538.2017.11.08.16.13.49; Wed, 08 Nov 2017 16:13:50 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hfNZzGZI; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 5E08126795D; Thu, 9 Nov 2017 01:12:23 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D74F6267674; Wed, 8 Nov 2017 22:38:42 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 7222E2676B9 for ; Wed, 8 Nov 2017 22:33:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Jsx6E9+5Nl0Vw70ZMzz9szeRthx1X7P3tH9rkv3IVlY=; b=hfNZzGZIFFR9 FjKn8NLSVxd16C5EpMbXOodsoCfPrvYV23oJkLihlX5JpNnpwKe6ERVRe3ekE/mjf9I9bx7RqNUjX Vcn5fi4czWjpK1EetStjmaxG1mBvdf+2zdlBxjVB8Qyu/RGX3Hl8prv0VuFwA+GgvKJOMlwNQa4c8 dSFKw=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eCXy7-0003hK-Qd; Wed, 08 Nov 2017 21:33:07 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eCXy6-0005Wq-VH; Wed, 08 Nov 2017 21:33:06 +0000 From: Mark Brown To: Pankaj Bharadiya In-Reply-To: <20171107104626.25800-7-guneshwor.o.singh@intel.com> Message-Id: Date: Wed, 08 Nov 2017 21:33:06 +0000 Cc: alsa-devel@alsa-project.org, Takashi Iwai , Guneshwor Singh , Liam Girdwood , Patches Audio , Mark Brown , Vinod Koul Subject: [alsa-devel] Applied "ASoC: Intel: Skylake: Check for NHLT ACPI header signature" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: Skylake: Check for NHLT ACPI header signature has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 3b47c9dc75be097bc0e2f3ac4b176fbf3eed85f2 Mon Sep 17 00:00:00 2001 From: Pankaj Bharadiya Date: Tue, 7 Nov 2017 16:16:21 +0530 Subject: [PATCH] ASoC: Intel: Skylake: Check for NHLT ACPI header signature In certain buggy BIOS acpi_evaluate_dsm() may not return the correct NHLT table, so check the NHLT table header signature before accessing it. Signed-off-by: Pankaj Bharadiya Signed-off-by: Guneshwor Singh Acked-By: Vinod Koul Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl-nhlt.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl-nhlt.c b/sound/soc/intel/skylake/skl-nhlt.c index e7d766d56c8e..d14c50a60289 100644 --- a/sound/soc/intel/skylake/skl-nhlt.c +++ b/sound/soc/intel/skylake/skl-nhlt.c @@ -20,6 +20,8 @@ #include #include "skl.h" +#define NHLT_ACPI_HEADER_SIG "NHLT" + /* Unique identification for getting NHLT blobs */ static guid_t osc_guid = GUID_INIT(0xA69F886E, 0x6CEB, 0x4594, @@ -45,6 +47,13 @@ struct nhlt_acpi_table *skl_nhlt_init(struct device *dev) memremap(nhlt_ptr->min_addr, nhlt_ptr->length, MEMREMAP_WB); ACPI_FREE(obj); + if (nhlt_table && (strncmp(nhlt_table->header.signature, + NHLT_ACPI_HEADER_SIG, + strlen(NHLT_ACPI_HEADER_SIG)) != 0)) { + memunmap(nhlt_table); + dev_err(dev, "NHLT ACPI header signature incorrect\n"); + return NULL; + } return nhlt_table; }