From patchwork Mon May 4 09:46:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 283538 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5990C3A5A9 for ; Mon, 4 May 2020 09:48:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FD7D20658 for ; Mon, 4 May 2020 09:48:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pk2ccTEw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FD7D20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVXiT-00079m-IQ for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 05:48:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVXgg-0004vr-OH for qemu-devel@nongnu.org; Mon, 04 May 2020 05:46:58 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20283 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVXge-0004CY-SN for qemu-devel@nongnu.org; Mon, 04 May 2020 05:46:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588585616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2JQqRaa3lceQY2Cox9GrAmR4rq6Pv9q/z7ys+NUFBVQ=; b=Pk2ccTEw5vglIQX4FMDEaCj2Vpzn0D6a61XCJ61mTt/EZ/zMH9TyNmUpXoX1LPHcl1gyyb DaY7YwUAbOShA35CSigWuTsibJYiR3CFNH/o7tqm8Zv+7o22OyG+otfrH58/gdnCcuKGNS besZCVmWXkKpSWrAx01O8Rs0/wwbPnw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-W-TUwdPGMxKHv8v_6qHizw-1; Mon, 04 May 2020 05:46:54 -0400 X-MC-Unique: W-TUwdPGMxKHv8v_6qHizw-1 Received: by mail-wm1-f70.google.com with SMTP id l21so4600008wmh.2 for ; Mon, 04 May 2020 02:46:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sohTl/XQVWV8gUG5aVpQRD87OojC6hP3gHhZB8wVux0=; b=Sbu4+UDJ9XglKa2pixdrI9EtMtVpQGV4C378ccdx0HyAsvXGdy0bt1KManiFgcqb5W JpKX83uoPCNL1Q7MPJQD1DLhVshdUblTpPe3HnAiJMhk36i/gdiJumEkSC1/XaunAqbJ T6slDnKMK5X9NXehjETN4cRdERx6M+5qmckwKtkUuxQLH/1Qsw7xd+7DsXeqVFW3f0Dm pub/MjSXymUbJ+b07fRJX+Qt9RmO2FXUC2MexZdXb/MwP3Hjp+LltLo4ykHqISbaUqFO 4pcwqZ5fG0XYIzHTwFuE3ZVU1ZzEFqKixx+pOkbNdxHiriA1YKV28ZgQ8S/AoEy3HxXg hf2A== X-Gm-Message-State: AGi0PuZ1ZfdsPd8F8Lf4DRE29fBHX/EkjAro81hrog//5XiMxGsxFanJ vZNFPgnJfPxrJEe7zo4o/7gH2rNZMwu3y3RNZyV+i9AArcYcannnLgqDA4wGyIYBGw03vTUqZi7 szJik5g/GqMmfK8c= X-Received: by 2002:adf:d091:: with SMTP id y17mr17521117wrh.418.1588585613141; Mon, 04 May 2020 02:46:53 -0700 (PDT) X-Google-Smtp-Source: APiQypJVL4aNUKKB/YhYWDA8wYUmMElDApF8Fu0tx/nu9Hq5Z1bMOWXo/YUJSWq09CfP89GA25ffiw== X-Received: by 2002:adf:d091:: with SMTP id y17mr17521101wrh.418.1588585612938; Mon, 04 May 2020 02:46:52 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id a13sm10529403wrv.67.2020.05.04.02.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 02:46:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/6] qemu/bitmap: Document bitmap_new() returned pointer Date: Mon, 4 May 2020 11:46:37 +0200 Message-Id: <20200504094641.4963-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200504094641.4963-1-philmd@redhat.com> References: <20200504094641.4963-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 01:14:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Maxim Levitsky , Keith Busch , Stefan Hajnoczi , Max Reitz , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bitmap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 82a1d2f41f..0b390ff576 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/bitmap.h @@ -90,12 +90,14 @@ int slow_bitmap_intersects(const unsigned long *bitmap1, const unsigned long *bitmap2, long bits); long slow_bitmap_count_one(const unsigned long *bitmap, long nbits); +/* callers must free the returned pointer with g_free() */ static inline unsigned long *bitmap_try_new(long nbits) { long len = BITS_TO_LONGS(nbits) * sizeof(unsigned long); return g_try_malloc0(len); } +/* callers must free the returned pointer with g_free() */ static inline unsigned long *bitmap_new(long nbits) { unsigned long *ptr = bitmap_try_new(nbits); From patchwork Mon May 4 09:46:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 283536 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE9EC3A5A9 for ; Mon, 4 May 2020 09:51:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEE872071C for ; Mon, 4 May 2020 09:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AgCChtIZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEE872071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVXl5-0003M6-2r for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 05:51:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVXgl-0004zk-Be for qemu-devel@nongnu.org; Mon, 04 May 2020 05:47:03 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:56347 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVXgk-0004EJ-DB for qemu-devel@nongnu.org; Mon, 04 May 2020 05:47:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588585620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iOoRSFUD32uShqGqJeGiHJdxg36QvfSMrGROhUVpi4c=; b=AgCChtIZvXKH8Gjd9bILDXyiiBlShzXtr+axBojLPQdVDrWKGoTvMuX5/FiO+f2fMGuJTf /fQXypO/plNge+thD5QJFE/Em/H7cz+PkejH25y+u5/cUKyDq+eo3s+s3XGXrqF1xnSuCe 4zn80ArqLWe9KgJeQCeuE3zLrlkvO3U= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-ILmlFRz8OEC1lzIdiiSMQw-1; Mon, 04 May 2020 05:46:59 -0400 X-MC-Unique: ILmlFRz8OEC1lzIdiiSMQw-1 Received: by mail-wr1-f72.google.com with SMTP id g7so10433283wrw.18 for ; Mon, 04 May 2020 02:46:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jqr2MbWG5qDVE72NJQlyIDzc23rCOzvleinSwfktvqM=; b=VYbcdPeGDqHEmzSszY51R1DfobfY6sydDG/gmRC7sP9m49bHEEKAxFCLm3+XQYXzr6 5pULtL/a1iouQ5CgfCNzxJdJFXLyxs4ctEk2KTtHCicyUnZjz4ef67xxOdZ+BpNRGHPQ gBObK6CkmyvTMAo1CcWhxAd1zkwJn8xsS88MeDIegTZWm04LJm965KfdgO6xRCEpst90 yFMG4x4t+N+5eL9xBrCsC3nzrhrgPxDk8jnapPYAULa/Jy+h2LtoKJuMrY8tCMSC1/aD l1DBxu9vXUf7qDkXHLjPzWYTdylBsFm0OWFX8DIfFytVPFjerQowjVUDqI+S3qnAYJd/ D3vw== X-Gm-Message-State: AGi0PuZpDUotRKEj0tIOCm2OOFuMlZ6tNH4Y3bKCTub7oRiF4HmIwkVW u7jXb+v0etfvLshkOt9mKOgh04574wB+lCgjLDsNtc2o2yc+KYOIePdvmGQ3dAdb/96HoGXTokB otmDZIr3y6wXFtYI= X-Received: by 2002:a5d:5703:: with SMTP id a3mr17393242wrv.53.1588585617718; Mon, 04 May 2020 02:46:57 -0700 (PDT) X-Google-Smtp-Source: APiQypKRlXQhcOWnVxbUEExVA4635H7zp8oLcYLgcINZAFRoGyP+yAZN0t2Ty8e+2GE6VLyEZwspmQ== X-Received: by 2002:a5d:5703:: with SMTP id a3mr17393220wrv.53.1588585617497; Mon, 04 May 2020 02:46:57 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id k6sm12762713wma.19.2020.05.04.02.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 02:46:57 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/6] sysemu/block-backend: Document blk_read()/blk_pwrite() Date: Mon, 4 May 2020 11:46:38 +0200 Message-Id: <20200504094641.4963-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200504094641.4963-1-philmd@redhat.com> References: <20200504094641.4963-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 04:24:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Maxim Levitsky , Keith Busch , Stefan Hajnoczi , Max Reitz , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The blk_read()/blk_pwrite() return value is not obvious, document it. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/block-backend.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index f2dcf63ae3..823b8e94a7 100644 --- a/include/sysemu/block-backend.h +++ b/include/sysemu/block-backend.h @@ -153,7 +153,31 @@ BlockAIOCB *blk_aio_pwrite_zeroes(BlockBackend *blk, int64_t offset, int bytes, BdrvRequestFlags flags, BlockCompletionFunc *cb, void *opaque); int blk_make_zero(BlockBackend *blk, BdrvRequestFlags flags); + +/** + * blk_pread: + * + * @blk - the block backend where the buffer content is going to be read from + * @offset: position in bytes to read at + * @buf: the data buffer + * @bytes: number of bytes to read + * + * Returns: the number of bytes read on success, or a negative errno otherwise. + */ int blk_pread(BlockBackend *blk, int64_t offset, void *buf, int bytes); + +/** + * blk_pwrite: + * + * @blk - the block backend where the buffer content is going to be written to + * @offset: position in bytes to write at + * @buf: the data buffer + * @bytes: number of bytes of @buf to write + * @flags: request flags + * + * Returns: the number of bytes consumed on success, + * or a negative errno otherwise. + */ int blk_pwrite(BlockBackend *blk, int64_t offset, const void *buf, int bytes, BdrvRequestFlags flags); int64_t blk_getlength(BlockBackend *blk); From patchwork Mon May 4 09:46:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 283537 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9108C47257 for ; Mon, 4 May 2020 09:51:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88FBA2071C for ; Mon, 4 May 2020 09:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Le9ii+5F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88FBA2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVXkn-0002dX-MA for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 05:51:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVXgr-000581-AK for qemu-devel@nongnu.org; Mon, 04 May 2020 05:47:09 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:55164 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVXgq-0004GV-LG for qemu-devel@nongnu.org; Mon, 04 May 2020 05:47:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588585627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvIOGdjqIkzytmiWyY1qnAlUnGlQqd6ywNbmnMw49Uo=; b=Le9ii+5FqkeWhPlxgjxzGfhdbxKHVYTDdhOrStSx1NO7eSTff1vOxS2MyLeKgj15X+vafj XwEOBfsJadCbGrA1RsS7ygTaSn9DVREQE7efd+DpKbo58f0m+2SKLs/KKhcy2TxHXCctvP XpMEH7gxDbdK8skcJVMdhuJzlY2awBc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-guUDtxNfNXWAsaEhdgcH1A-1; Mon, 04 May 2020 05:47:03 -0400 X-MC-Unique: guUDtxNfNXWAsaEhdgcH1A-1 Received: by mail-wm1-f71.google.com with SMTP id o26so3224175wmh.1 for ; Mon, 04 May 2020 02:47:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0cHqmvxZVKll/YDWdGdgBQsGWJ3nu/ONs4V6i1R5aFg=; b=HGKBFL92evv6ME03PBPn0oWEtLVQIck93yqF+CUL38jhi8JqSvmdGV+DKWfI2hHuuY +Z/kbpvPjc9UPDFJgSu6Au2RT1ieU4g2nubW4+p/9uzV6G+xNsvc0skRVAjmFuLjCcxC 6+23HY+Ka+Y3xUX6exYNYQaoCXYbEIJed+E6Qw6LcisD/aB1hpctSjr9Oe57iRHroJAr qVBp0qYvCJdrqW0cRzH2cIibqU7XUniwaqCOTNK4ci2HozWjiEXdvfHnA2YP/OZLvhGt nOIVaHxLOfTEyJr8pck0w5s6AmNk9aZHk6QUFPRpSzBeL2u7R/mydJ8YIqTp4p4/f58Q BBew== X-Gm-Message-State: AGi0PuYDD0BFj86tVNnay81bWR+hwZs4auZtsu4c0ywKtnltXYUEXCsp OAKEjOmLhsaRWMJi+ld5D6xtwtWF6gD5spb+jDAIM4OJ8g8NLyHrXbH2Wd9N2kc6FtddXd/y1J+ E/l8sQX1TTN/fkSw= X-Received: by 2002:a5d:6850:: with SMTP id o16mr17620779wrw.309.1588585622338; Mon, 04 May 2020 02:47:02 -0700 (PDT) X-Google-Smtp-Source: APiQypIDtNONPhZkTPwQdW6eLEOwCIYTz7AhsLlWKZ71vdMIAmvOq1vzhv8BNDUtr9Ma0tZ8UWbh8g== X-Received: by 2002:a5d:6850:: with SMTP id o16mr17620766wrw.309.1588585622200; Mon, 04 May 2020 02:47:02 -0700 (PDT) Received: from x1w.redhat.com (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id g186sm12685573wme.7.2020.05.04.02.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 02:47:01 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 4/6] block/block: Document BlockSizes fields Date: Mon, 4 May 2020 11:46:39 +0200 Message-Id: <20200504094641.4963-5-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200504094641.4963-1-philmd@redhat.com> References: <20200504094641.4963-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 01:21:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Maxim Levitsky , Keith Busch , Stefan Hajnoczi , Max Reitz , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As it is not obvious for a block neophyte what means the 'log' value, document it. Signed-off-by: Philippe Mathieu-Daudé --- include/block/block.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index c57fdecf9a..94517c92b6 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -86,8 +86,8 @@ typedef enum { } BdrvRequestFlags; typedef struct BlockSizes { - uint32_t phys; - uint32_t log; + uint32_t phys; /* physical block size */ + uint32_t log; /* logical block size */ } BlockSizes; typedef struct HDGeometry {