From patchwork Thu Nov 30 12:33:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 120171 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp608105qgn; Thu, 30 Nov 2017 04:34:26 -0800 (PST) X-Google-Smtp-Source: AGs4zMbedY92OUcVbK2+aFEQwLre5LCy5V5/y2N2brLBF7Crf6l/Pd6eCNp4CXBdzz5pdq0hmBfK X-Received: by 10.223.164.22 with SMTP id d22mr2069649wra.232.1512045266290; Thu, 30 Nov 2017 04:34:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512045266; cv=none; d=google.com; s=arc-20160816; b=wEgEcAveJ/hIlf0GKRJ8mTXd1S2ivpEWybsxKbpmhauIICU+OqzNMe+pLEkH3es6ES rbB7xoR9064mwfi+xEak2tMncPeFIWmx6oVOWQg/98ulJnvYrnvGUsVF8qqkArSxsbVp 3GGnyHafuxkxWiF4lDIxZxrlFpvf2Dh5RkJUK8Waklk9LeCEAmm4B0QODX71+JGbDI// KBlOfOmw7HPiVHk9y4kdhrk/8snFHErs+oXcnv33CVPxYbT8LwJQEa5JS05h8i3cb/cf 79DgNjOkLR/QyKnuk2haSk+47z6G9aJ0aiPXqC/SQQSiYppZCfb88naS/0MuNVtOj/ZP l1uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=XreauXO1BYl8T5seEdku1rsrexaUVDTapG0xANNU9AI=; b=a8hxsvYuh5UGdrQJq86sDS0i67VM+QasaSTw6Q3Y2M5HH/Pp2PHKNTnse+LnBgbcZm ur7LwdWYEPtr3Dzryujnli0kT/toz2g15ll774Wl+DxGZf79f8Du4G604lNfTdhDEObe iv8oBBEtCxOeLkBxl9/u/GZqQCzxJnro/nla5oNFBxCCC5y8UB9BhaIdJ8Gqm9QGnpSc zlHaHEv3/ATbumRxJAkCYKjouhFqkNGK/aCqp7YQgqtkiBT93wFuHT3YAcgJ+xJZEYjU Am977u9Tj/H1Rzb2EBcq+fjsa25ODt7PO+lZKv55Igb9B+zJZuSjSlj8m5hQpRqJmV7A tpTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=rOSf9ASD; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id b185si2970033wme.22.2017.11.30.04.34.26; Thu, 30 Nov 2017 04:34:26 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=rOSf9ASD; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D4993267ACC; Thu, 30 Nov 2017 13:33:37 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7BFEA267AED; Thu, 30 Nov 2017 13:33:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D164D2679BD for ; Thu, 30 Nov 2017 13:33:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=WWVhn++YbxoINSQZNuO3faL6QCXKGsxHbUw0lxePZyg=; b=rOSf9ASD+9ip nMNtDHPPpsZO5IvfC8pLLnJHuiNH6FiNCmtOh3cNWy4EuMoU3/F9zrYOD7qB1kTOdxpPNL4x87/oH lapWr36ILivSxa4QY8s+y3FbchCueRSXCbwgU4Hqpsi5jQxlFW0SgTeqq+/53bVRJ6n+PW+S4n71U ysmFU=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eKO1Y-0003GJ-SA; Thu, 30 Nov 2017 12:33:04 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eKO1Y-0000XO-Ex; Thu, 30 Nov 2017 12:33:04 +0000 From: Mark Brown To: John Hsu In-Reply-To: <1512007997-31704-1-git-send-email-KCHSU0@nuvoton.com> Message-Id: Date: Thu, 30 Nov 2017 12:33:04 +0000 Cc: alsa-devel@alsa-project.org, cychiang@google.com, anatol.pomozov@gmail.com, WTLI@nuvoton.com, wuchengli@google.com, lgirdwood@gmail.com, YHCHuang@nuvoton.com, mac.chiang@intel.com, broonie@kernel.org, Wu-Cheng Li , CTLIN0@nuvoton.com, mhkuo@nuvoton.com Subject: [alsa-devel] Applied "ASoC: nau8825: set clear_irq when imm IRQ happened" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: nau8825: set clear_irq when imm IRQ happened has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From e3fee43a968fd39dcc56be3757fcdfe250964125 Mon Sep 17 00:00:00 2001 From: John Hsu Date: Thu, 30 Nov 2017 10:13:17 +0800 Subject: [PATCH] ASoC: nau8825: set clear_irq when imm IRQ happened Although the crosstalk is disabled, it is better to set clear_irq properly when the impedance measurement interrupt happens. It can avoid that the driver clears other IRQs by accident if the active_irq has another IRQ events. Signed-off-by: John Hsu Reviewed-by: Wu-Cheng Li Tested-by: Wu-Cheng Li Signed-off-by: Mark Brown --- sound/soc/codecs/nau8825.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index d3c1a02f1e15..603cd72c2a25 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1733,10 +1733,9 @@ static irqreturn_t nau8825_interrupt(int irq, void *data) nau8825->xtalk_event_mask = event_mask; } } else if (active_irq & NAU8825_IMPEDANCE_MEAS_IRQ) { - if (nau8825->xtalk_enable) { + if (nau8825->xtalk_enable) schedule_work(&nau8825->xtalk_work); - clear_irq = NAU8825_IMPEDANCE_MEAS_IRQ; - } + clear_irq = NAU8825_IMPEDANCE_MEAS_IRQ; } else if ((active_irq & NAU8825_JACK_INSERTION_IRQ_MASK) == NAU8825_JACK_INSERTION_DETECTED) { /* One more step to check GPIO status directly. Thus, the