From patchwork Wed Dec 20 19:16:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 122489 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5990773qgn; Wed, 20 Dec 2017 11:18:35 -0800 (PST) X-Google-Smtp-Source: ACJfBosR6amjEiny0DwdtDmoBKoqinrpcaC7uKWqTOny76W3nRuPdDKWp1WSYHtwWMMJzsPvipOY X-Received: by 10.84.239.1 with SMTP id w1mr7814530plk.368.1513797514935; Wed, 20 Dec 2017 11:18:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513797514; cv=none; d=google.com; s=arc-20160816; b=bgx2SibxmKl0mseBiLqzySfcZNX9Nitqa2Hx6+4nR+rtQm+KnaBcf7R8KPBIAkpDXc dsDUQdc4B8jPMuGkQwYdmQW9PtGZ7nbHI260Mk9q9vCEcag8yJWTihpaVIERk2L453sT LpNj7oTb2mrjcMOdh6DtggAlu4larsZGvMlNO4OR78VBt/YL2nRRo5jQrZQAodDmOyyH q+/WVLUoncCvBSVFFM0n7pHTB30+3K4Jy9jJXTEOx4Ja4OGXM310m9fa9olqI1dEgKkF J9I8J8BDBH+8oAyRiC4bbYzFNFnvKzVi2nrrmMle4OhzIxzVX2sWF0BuvSUE6SohrPUK PPPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Xa8b+QpKxKYUGPrqYpraBj/WHrKkoCbHSVhXeiXN0aI=; b=gdSpZeT+v3r0KHYx6PItBDAmG1Jl0QYnNZYjf1BCGNV57X4Sz1ixCfpCdBxAewlepJ v+GbnMFjYMlC6JeA3VA7k8YsweXm9QVt0xd6g03BrxrWUNCAWlR8rpOwo9jNrLfY5cLe VJCyQM7R6zY1FJixr4xeGFBzDGNsDO9mOhiVysP0iTzPJKUg5ad8r941JlZp4qRHN2cM FFaN4Dh3bksa0FOdKwEV6xh4VaMWYVgcnkefbalN3OAlsTNRTuzBxjtc/IGh/GBxGheV scYDcfHmJP3MqkPuCKla8TFqDgt2R7JgWC5skFRj8/CPGSfEFGTKl/U5yBXAJDq+pM8l hM+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LjvQ6eT2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si7331837pgp.119.2017.12.20.11.18.29; Wed, 20 Dec 2017 11:18:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LjvQ6eT2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756422AbdLTTSY (ORCPT + 28 others); Wed, 20 Dec 2017 14:18:24 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:40556 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501AbdLTTSW (ORCPT ); Wed, 20 Dec 2017 14:18:22 -0500 Received: by mail-wr0-f196.google.com with SMTP id q9so23212769wre.7; Wed, 20 Dec 2017 11:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Xa8b+QpKxKYUGPrqYpraBj/WHrKkoCbHSVhXeiXN0aI=; b=LjvQ6eT2vgEPNd1LvZuU7gm6bXzt/YXM7j0KHs+gvFo6T+JdmVPsbUNf/g3jgqFhLD 5DdjsD8iMwV056oSMV/rhPz4Myglj4zlWoRlAHqu90LE8Gj76XkcyTx9/WjKelnx9shG 5vromus2EFj1n3KgIw8vbMVBm15JcEXcTVCKwekPCAPT1dIqE0oX2fQcVxBzKcTIiVMG jKXjyWBbzbpBv2jO6w4X778Kq9mJv2ps27ajt4NcgcLuMCIiB1Lvh+L7cjL+VabvgsTg eE3blgcYxLA1YIgCKDwsofWr3GoFn5Btqs2Qfb84kNMU+oUxPSHfdwA0aZug6tUQYY5d 8skA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Xa8b+QpKxKYUGPrqYpraBj/WHrKkoCbHSVhXeiXN0aI=; b=Ip8u5xlTavvD/Sp4GCF6JAVrVzcBx/dV7fBlpzv+maVzr6j6+EVxiP1svwyBi+gak+ 4rRzpymZ91kCiDwJlaRy3coxYzSXhj8ENQlQ8V7/1yTQ6PZlKlLkjuuDgSrALNVBIElp 4/yO7I/zQr5cBEREkzxa0+vOSIs34q5W9MsbZmgN6Ar+ByNjHDnbGuyuCoHp47KEJEBX hwEyPiKJb9+lqeO0cfVuDrKZbhUCAtcueLP2ayZ8oM9nQtBd0AeUK0rdIYicCH3CZUuv mxh9d3rk2kQL698MDvzl3prfctQ3Kl//nkPIuh+ljnkOFRvkooKs9Rx2JNlftczDA0Ig ik/Q== X-Gm-Message-State: AKGB3mLtEfMKa6lARwQ/tgxjO/zAqzgnPxszMcKbs4fmhb3E3qULEpuc XNezGtYLr5Xxp2S9jQmD2Mg= X-Received: by 10.223.159.18 with SMTP id l18mr2717058wrf.156.1513797501285; Wed, 20 Dec 2017 11:18:21 -0800 (PST) Received: from Red.local (LFbn-MAR-1-494-123.w2-15.abo.wanadoo.fr. [2.15.82.123]) by smtp.googlemail.com with ESMTPSA id y42sm15435087wrc.96.2017.12.20.11.18.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 11:18:20 -0800 (PST) From: Corentin Labbe To: fenghua.yu@intel.com, tony.luck@intel.com Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH] ia64: agp: Replace empty define with do while Date: Wed, 20 Dec 2017 20:16:13 +0100 Message-Id: <20171220191613.7827-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's dangerous to use empty code define. Furthermore it lead to the following warning: drivers/char/agp/generic.c: In function « agp_generic_destroy_page »: drivers/char/agp/generic.c:1266:28: attention : suggest braces around empty body in an « if » statement [-Wempty-body] So let's replace emptyness by "do {} while(0)" Signed-off-by: Corentin Labbe --- arch/ia64/include/asm/agp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.13.6 diff --git a/arch/ia64/include/asm/agp.h b/arch/ia64/include/asm/agp.h index 2b451c4496da..0261507dc264 100644 --- a/arch/ia64/include/asm/agp.h +++ b/arch/ia64/include/asm/agp.h @@ -14,8 +14,8 @@ * in coherent mode, which lets us map the AGP memory as normal (write-back) memory * (unlike x86, where it gets mapped "write-coalescing"). */ -#define map_page_into_agp(page) /* nothing */ -#define unmap_page_from_agp(page) /* nothing */ +#define map_page_into_agp(page) do { } while (0) +#define unmap_page_from_agp(page) do { } while (0) #define flush_agp_cache() mb() /* GATT allocation. Returns/accepts GATT kernel virtual address. */