From patchwork Mon Nov 9 21:18:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320976 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000146ejb; Mon, 9 Nov 2020 13:19:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQYFYWWFeMZVbYVG6lbFwKVhlZNs6WKaBGx5OSFxMhfpZPicmlkIakvHwJCEbavbWjx91S X-Received: by 2002:aa7:8b03:0:b029:152:a364:5084 with SMTP id f3-20020aa78b030000b0290152a3645084mr15007132pfd.29.1604956748834; Mon, 09 Nov 2020 13:19:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956748; cv=none; d=google.com; s=arc-20160816; b=Hc1a+ciEFMSRrUZOepy0RaRgA3pk9neEdaPOKE2pT6vP0nsapHp7nKklLX4QIuA4Uz CBWjc4dJm4M+5gsEwU7lHn/g8noN86mfEgo/XQjzAdWzM6mJR0AapR2DAl2arIoY1vOy Nu75GHqsmMvuE3iWj0DcxIhmwincrXxSkPjz9UAyHUs+gsJ1jyQqDvxBBB+ChyioKysd vnhdeSYp7CHTx/dgPPjYAyMsLz+XQ7VXY/5ztL/GJ0NhrLoGF+O9vHBDhQluTfDa6/qx EVKDId0PrvBi2GpEtdl5/zvjsEAQEUzgt4VgXa9PDBHx8VQSN6m1BAUEUNUGhDt9e60O vO6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=sDOeiCuf2pUpCdGaBwhCdSEl/6ozFfogA5xy+JFWl8U=; b=xMosKM8hCehkt7lxpqe3evmJPZ6qkkNB4rrwcsXmHGT/wro4aWRMwq4s2xROnKXvSv Cn6OzuH9qpF+zli0AIITN8W9p9rpMjLdKIJy46OzynSH0gacVt0kJ6B+nkr9UgSUT/2F TLUJBSAzJunYJVD72Gh0zQ7H1VJ959NqyXxGEfYWYE1qckTmwhaxv+FVbLX2vyqi7FAT +BR6YBJu2nizHyN1p0mxlOxpm1HuvNhr9+RWKg6H8EKk6qko2fFbObQPAhtmsh597CXl O3swyXBWc4CbNfkwgltogRJTHsjdFg4U2ONhgUZrvEOmMF+sssBJRtCKGbyH584S41Pb WdLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LZgL07gg; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id h16si10085064pgn.557.2020.11.09.13.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LZgL07gg; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12C248953E; Mon, 9 Nov 2020 21:19:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B9F48953E for ; Mon, 9 Nov 2020 21:19:03 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id p22so941572wmg.3 for ; Mon, 09 Nov 2020 13:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MH4JrPJnV93KjKdduQzhuU+LLZMbEyGUifyLAOa0/tA=; b=LZgL07ggHJ7R0ptAiCpzHF9zdgd23QxQBllK5tecy3Tb0t8KoVT1vGpK9+6IeZl6Ef QoIJBhYsx0LZBTWLDq0577hYyZJNNfKp+3WPEuTdHhOgXWdJt5fegyQFRifigj05BvOy 20yqpzld/RJwNMLhDNKYqkxNtMyDyaZoqI2T8b7sL5FRdcvW4K8xR6xjT3DLqtGK+/8y 25EH/0vFCbVKQyOrgk+EDhDJ726xYSE33dZ+NebIY+hwswqauDuUYiNGxQ4ZFGC9sxrZ kIA64UzFlAZUGyLWCj6urbm00THq2CnDEDDejjZXcE6t1KYu0ZbV6AgMTzfHPn3FNzd8 7G5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MH4JrPJnV93KjKdduQzhuU+LLZMbEyGUifyLAOa0/tA=; b=jYqhmS9linTlPvhqvKFk3k4N5CCi6ETixBMEtNAvenffgz0SbPEZM7iQ6xoGS2/nvm U4ei4vDNIMZNaxTjPbdtDalMd73z7BTm8EVRHhTcCiu6MnN3ukg3x0FoRmChxaVqSTPF c6DRxdnj4BOtQAf+j7MdnXIlelNgZbtrXs5dOY+vD5JciiBa2rPasXYS+19yDN087ov9 kUX+mfF7Xw3kfrD13iAmZSPw4eMogQ+7rI74omfgdnBW0wkdYK1D4s9NEczuBBvXxcX9 JZhYW2alkFjBFNXVbD0DmNj7sXXvBRQbkMPcvatAaD4yRv3Q7G2m1yvR8YoqLMXaRTFa spig== X-Gm-Message-State: AOAM533y17GmrwSony2tVoWm8fTFxB6zD1mS4w1NKZCgJlvOaEUTg7RC whHqwgAnGcxBtXQQlISbtTfxGstRISnIdPWb X-Received: by 2002:a1c:3c8a:: with SMTP id j132mr1090012wma.75.1604956742114; Mon, 09 Nov 2020 13:19:02 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use Date: Mon, 9 Nov 2020 21:18:36 +0000 Message-Id: <20201109211855.3340030-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Jerome Glisse , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_ttm_tt_create’: drivers/gpu/drm/radeon/radeon_ttm.c:611:24: warning: variable ‘rdev’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Jerome Glisse Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 95038ac3382e2..a8c915920070f 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -608,21 +608,21 @@ static void radeon_ttm_backend_destroy(struct ttm_bo_device *bdev, struct ttm_tt static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, uint32_t page_flags) { - struct radeon_device *rdev; struct radeon_ttm_tt *gtt; enum ttm_caching caching; struct radeon_bo *rbo; - - rbo = container_of(bo, struct radeon_bo, tbo); +#if IS_ENABLED(CONFIG_AGP) + struct radeon_device *rdev; rdev = radeon_get_rdev(bo->bdev); -#if IS_ENABLED(CONFIG_AGP) if (rdev->flags & RADEON_IS_AGP) { return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, page_flags); } #endif + rbo = container_of(bo, struct radeon_bo, tbo); + gtt = kzalloc(sizeof(struct radeon_ttm_tt), GFP_KERNEL); if (gtt == NULL) { return NULL; From patchwork Mon Nov 9 21:18:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320977 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000172ejb; Mon, 9 Nov 2020 13:19:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJym+4ILdDH3YVMzDGe2MbvDBkfnAH4Ga3rMCSCrQRBbYR5oHB/kwyjfyP+WKQjKgczdcgWj X-Received: by 2002:a63:1341:: with SMTP id 1mr13821816pgt.6.1604956751643; Mon, 09 Nov 2020 13:19:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956751; cv=none; d=google.com; s=arc-20160816; b=J2dvOTZW1yY3Ujj1a/oaB73Cnlk4pYkT/K59aquCU32f9zyLZGhJxUzS5yy55BUUIi Rs42KWMHGwEIafqy+5ySVhmZeu8gndt24z250Qh/NBKbCYFMiSBrG/eZpcK1eobGxUBB Nydp/cZG22TFcZDmVP7EEKN2v0Y9YJjTmsWtLS02ZfSzPl9sYH7CqhmX++W+cP2Y/hCS 4X/c8pQo2NcVMEo50uY8+bE944zCNWb2ymJsU6aETgcGcLgm+Nhbej/Cu65y3cJb+TwN S76Kz3xTMPGgIioKQP0S6Tdhbdgd5rB0LcHJBfWWcsrIFf2s9fZ77geHsY0jZAyEEdzx akQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=6TmOx/Ec98yzqC7RqREOI3DyoSJawIdhQoLVJfAoCII=; b=Arbx7UMJER6iUDfI6ASHh8xMyTG/jJa2i9EetiDe+ud9Q/4e6ysuPRWgTrsoXm26P3 NZjLt2ub/ZADgAL7AiWEmTEGX63k9B1PXUAZ7q8S5wFl+BzUYhTjZjg0AtcNBktU8sbV LZD9VHk47doeyKQemoz3WKtPd/J1jhgUp/UGhMKjCmb7nUK6bxssJFOCt0LdF1um1Ja3 1tGZ74ScU1g38P/CoUpociCUX7cl//UXwDlcrJnL14w0NYzaMReQ/hCo90DBZbWm81W6 0qjCPjJJswtaABMwOxTvKR9whh78SRjGo0M+1JBg3sjLl/s+RZzp9Qisn8JKBqpeWMLb sVFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=G98UJ0t6; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id o14si516309pjt.157.2020.11.09.13.19.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=G98UJ0t6; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9DD38957D; Mon, 9 Nov 2020 21:19:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id A90688958E for ; Mon, 9 Nov 2020 21:19:07 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id 23so10375298wrc.8 for ; Mon, 09 Nov 2020 13:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zaj9PQ1+4jRxFdQPS9IoWMCG22fw+6XqKxYZ9+Me3Xg=; b=G98UJ0t6Uf8XyAe1ROYsF/XIMBcEriB62SabFOr3x7XylyO8f9EbS45rVGhEBLXDKc hsQWYFs4zJrYc8FmqhCl4m5tFEmUxtb/xdNjP38hGmTM+qJYlf6lSeEtXHgBY1Lxc1SA woIBgG5kTOcPnd9oN2qSk/gOYKj/NVFn+xnPT8PufPJK9ISuPMYdystjas8QpGyhxCK+ WtcpnuN2ItVwsIy5aLglVDP5NcL4TDQ+65zCqarczO7dPo3xQQ7A1fqgdOtMQ8sFQoBt TSwqrf1ReLTffFk2GBD4UR3j4VhzU9yKA8Fb0Q9ctsBiVMwkr9lJ2Lss+sSdO0Qjq+Zn hz3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zaj9PQ1+4jRxFdQPS9IoWMCG22fw+6XqKxYZ9+Me3Xg=; b=nXyBlXaMH1kaHodvQ1d3ZZH5AGIASC71Ac6uxBb/ijGbjtFruJ5Iuxkq2pxmDTsXef Oirh700PG0VOSla73xkPoABowlu4FPi3d+MKTy7fEwUybdw+6GUdwkKjMK8DU59d6h4y k6XXu2yDgaZV7nN0meJYehj41t4UEtOKvo5eGi/ATKYAz/ZDMRfGT7oiFFVl/6UPrEZR +ADQhIIpI4DnbLZ0LD5eJk8r9GeXdBvc+aO1vs+kIeZiIaPHwP02fUmRZ8RYrJDO+nIG pRAO+6CLFNvif9nroIaEHLCQti+C+r1Y8Jd82IyQ4GKNgJde+oWqIA+bIvgM0CBYwerZ lxNQ== X-Gm-Message-State: AOAM530x+7bZrGTOPmUQCE+rqGfnO5E2kwiD9KyrQIB97AEvI9tpizgb JjAGyIBfBe7Pwo1dSt5euGKCKA== X-Received: by 2002:a5d:4bc7:: with SMTP id l7mr7212779wrt.105.1604956746318; Mon, 09 Nov 2020 13:19:06 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/20] drm/radeon: Move radeon_ttm{init, fini} to shared location Date: Mon, 9 Nov 2020 21:18:37 +0000 Message-Id: <20201109211855.3340030-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c: At top level: drivers/gpu/drm/radeon/radeon_ttm.c:817:5: warning: no previous prototype for ‘radeon_ttm_init’ [-Wmissing-prototypes] 817 | int radeon_ttm_init(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/radeon_ttm.c:878:6: warning: no previous prototype for ‘radeon_ttm_fini’ [-Wmissing-prototypes] 878 | void radeon_ttm_fini(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon.h | 4 ++++ drivers/gpu/drm/radeon/radeon_object.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 53d9898e9871e..a0c2497cd4cf4 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -451,6 +451,10 @@ struct radeon_surface_reg { /* * TTM. */ + +int radeon_ttm_init(struct radeon_device *rdev); +void radeon_ttm_fini(struct radeon_device *rdev); + struct radeon_mman { struct ttm_bo_device bdev; bool initialized; diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index ab81e35cb0606..048d83d0ca996 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -41,8 +41,6 @@ #include "radeon.h" #include "radeon_trace.h" -int radeon_ttm_init(struct radeon_device *rdev); -void radeon_ttm_fini(struct radeon_device *rdev); static void radeon_bo_clear_surface_reg(struct radeon_bo *bo); /* From patchwork Mon Nov 9 21:18:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320979 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000238ejb; Mon, 9 Nov 2020 13:19:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrg/PO3EKJKfadENLqJwyVVltmuw3JcxPeWSLLrcZgU/A4KduPAWN5tt+F7Py6dcQYWDa1 X-Received: by 2002:a17:90b:3648:: with SMTP id nh8mr1108276pjb.27.1604956755849; Mon, 09 Nov 2020 13:19:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956755; cv=none; d=google.com; s=arc-20160816; b=aKysqdStYlrw8oRZIb0s8AKgERXlTb1tnUIJnv5XbE5OYmnp83pBZPSA9myFCCmdW8 /Tatrm+/FIoDieGc2CuOHZPITKId7zLpsbrlIrA0Mx0Sg3DvnnXmNvmsurXzH5mnVyfM NONVVlvRVBv3RTZ2Ve5tIn8Ge9/pCwd87aNZ82Xg6cE8Q8bOQpdIqp6t/NEc+85lWCQe BMyDzV2ZaJF8JIJiZaNmWpRG8rWIy3JPeuWPkpVXK4jXDsErAcA9V7pTYvAdziLVQFK8 b1wdBTLz9+BrABKEUGq7i7TZuwcwTuewE84zuTGXvTLkBYdh6QJag4svh+WSOnFdKQ2B p1Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=0V6W509i0PPnr+wRwvV6bdqjggnMZD+xOoOaPUjBqjU=; b=YFF296dQSTGn0LFIuigHD/V/pOsfFmqpCKHlPCKB+XdMbkky5y1K3vIH4Ci7P2SGF4 GMHnXY33iJIAsOHb/Pkkw9x5XSYJ13VcIH0oDMOaEd47pPXMjOsulsdEAej72aB8nkC+ lgcojHr+izWXvQ3fDCx8UQ6BYCmyY1eKnA0FupZ4z4pV1gtWof1yGDV/L6GEp9+b452o wfcECTWehV6cu1vmmn63MdzCN845PMQZdlKY6lmxW1N7KfP9UqKd9eWyfkha32Glsu6u ziE/MTjOh6Ykx11uNuW2F62YYaK83J/GiCazQCQmYWXoCgsJyZpiaMROlxpy6mk1p5Gl uAGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=rnIwaAtc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id g11si9907245plj.53.2020.11.09.13.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=rnIwaAtc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 436D18958E; Mon, 9 Nov 2020 21:19:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id A051C89598 for ; Mon, 9 Nov 2020 21:19:12 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id o15so2542190wru.6 for ; Mon, 09 Nov 2020 13:19:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A+pA8ZHZ/BWRZ/+5idjB7jAn1iVLFLVHhzg6ecfAKK0=; b=rnIwaAtcMH8I2ZxIUoGWsSl6kKjHPDJJrShyAVuGGXNBBDSIsump85D8GU4POVebMN E1L8xTS69PO2A8bD7eNCLX1g2XSl+7BuiBQOD/qhy+xQod6/Q8/Ef7akcS/Jtzzrm61R 9c2sGZxrqEZ1+XxS7jIAj6abpTvKU9oCNdXo4u6GnbxzmQkOQFukaOTpLHoBacS7XwuP GQvsqcIDdgOqdqoj4ibSXlHmHb3CgUGENsNWH845TfYVrbh1zjrnx39FoMVR7dC0FQS+ L3SNZRoVvGLdM5finrmbU6TJiCv4M9wW5PsZ2yDhmovVUU9POtXHWjZWnrXwCkw+MhSp 16Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A+pA8ZHZ/BWRZ/+5idjB7jAn1iVLFLVHhzg6ecfAKK0=; b=IwmY7tZeMZMLmvKQ4+TWb3WwQ1BRm9VOAj14gHEyzTByHNvPcJIZqGcZT/ZpbqU+in LBR3TWI3HEnq3F+omuE1ofVVK1mkzlMIpxBID6gT+tBuW/RyPKT8bpD0lgEwxr2QjgO0 /67Yl/IzvJffJ2seln2O1hkehl/kUBJQ+mvG6NY20qUhtjj//cRYkmvuIypwct5X5pCQ U9O5JCLAf39Nv2QCC4ra29AwFITjpjEN/YrajvtttIhwCVbEgGyEpRrpJUZNhzxoL2fH htMVJGmldEUtw+VHybGLxya3uUiU1WyeokfcB2h7ZtE023g0PkhSJt5ygRENt5Oeumj/ gN1w== X-Gm-Message-State: AOAM533uEc/cLo+6U9GkaeP1hCAcXtkTagoRpSIg3ZoGA/EWdfGLfzmF ClKIxOVXDqJSIQmFsAh7T7+f/g== X-Received: by 2002:adf:93e5:: with SMTP id 92mr20405072wrp.421.1604956751344; Mon, 09 Nov 2020 13:19:11 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/20] drm/radeon: Move 'radeon_add_legacy_encoder' prototype to shared header Date: Mon, 9 Nov 2020 21:18:39 +0000 Message-Id: <20201109211855.3340030-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1745:1: warning: no previous prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes] 1745 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, uint32_t supported_device) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon.h | 2 ++ drivers/gpu/drm/radeon/radeon_encoders.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index a0c2497cd4cf4..0cc8f081e113a 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -2817,6 +2817,8 @@ extern void radeon_wb_disable(struct radeon_device *rdev); extern void radeon_surface_init(struct radeon_device *rdev); extern int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data); extern void radeon_legacy_set_clock_gating(struct radeon_device *rdev, int enable); +extern void radeon_legacy_backlight_init(struct radeon_encoder *radeon_encoder, + struct drm_connector *drm_connector); extern void radeon_atom_set_clock_gating(struct radeon_device *rdev, int enable); extern void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain); extern bool radeon_ttm_bo_is_radeon_bo(struct ttm_buffer_object *bo); diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c index ced022fae19d7..3e342fd812ff4 100644 --- a/drivers/gpu/drm/radeon/radeon_encoders.c +++ b/drivers/gpu/drm/radeon/radeon_encoders.c @@ -33,9 +33,6 @@ #include "radeon.h" #include "atom.h" -extern void -radeon_legacy_backlight_init(struct radeon_encoder *radeon_encoder, - struct drm_connector *drm_connector); extern void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder, struct drm_connector *drm_connector); From patchwork Mon Nov 9 21:18:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320980 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000263ejb; Mon, 9 Nov 2020 13:19:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2HELRNi6OBc2r3ckpSthadXszw0zqwD/Knd7qtpS67eK8evR/Om4hXS890FcIkLP/UaQi X-Received: by 2002:aa7:9601:0:b029:18a:e777:dac1 with SMTP id q1-20020aa796010000b029018ae777dac1mr15205832pfg.4.1604956758639; Mon, 09 Nov 2020 13:19:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956758; cv=none; d=google.com; s=arc-20160816; b=mL807LoNYULB891OT4J/MS6mSa/JNuhdw5BDPiL11roq9uSUjv0SwfjgkfAoiVdMB4 tRQdCFho4mjKN9YEb518qA/mmZRBSKbWDxWqGtLL2BxcbHBPVlaOfd8q6Y9HM5bBas+A oHOuved2m9dELT82a9ku8hN4VmwEQWB+RrDP4lPKGfIR1Hq6+EOvKKdxHwv5VYVFoe+W FmYOLo2bZgJN6QlM1tRiol+EOqGbZddgL1c0yImn6QqGfRCj7WC5qHYuVrhE+3d8uAv3 V4NsPtdaWsOACWl3/SQn/mU+fXQzM2jsWRT76SR4FeBa6umax6igeaqcoMiOa3vEv/2z mFCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=+/zBJ3kPQ4KYOkS+1UarIRre8xwZSKf4oaOuPr7VW8c=; b=x5Ub5zEggJONDeykQMOMhxPTSg9jORbc7whiyPsMFThTrOKHDjVLcMjGYwsU/DrSuD Sd4Plb/Qrq4SisRR6j7bB+OVXo3So79baZtQ+XjPEqwDJkVxvvXhInTvkXhigDtP84/I Vg3FglyRN6OTgVXcjE8tLk2Akf1ThURtTCrUQ4eBbD51e616Yy42+KDhd2l+7Zh9Ne5m i6nKCfHbhuDyLBfRvihNTg2MGgHeUJ3HxDRKTXLcsO1yioZTbcgJjS8YzoxDt80nyZC4 2KCJ5iku13f7Ej6RU7sXhSKTyLLIZe+iJiqNYu4m8jci9lXDoHjd0t6pxb1JiHOjx0Ax QkLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yRHbohXs; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s184si9880495pfs.248.2020.11.09.13.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yRHbohXs; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A187589568; Mon, 9 Nov 2020 21:19:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA93389598 for ; Mon, 9 Nov 2020 21:19:16 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id s13so905982wmh.4 for ; Mon, 09 Nov 2020 13:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RmvaQQVqTzYJ/ca4PPIPDIzgTk17HpnAY5XhUH8w95U=; b=yRHbohXsw2QICXZKtP8ovBwjdAKlIxFQQZ0rhdvBYM4oJ5nxL/ORcz5DZJWVVZZIzN 2/DChFnHuAKzp22e7kROw5JKDyNwVhDN23V5qieSGG16WDx6KvMRGkdsZEMniuIP7nk+ Sb5HW0mH6htetyMcaUGgJnVqniObdZbyJiW3Ik/WG7Q/LVqaY071vIQevKfeYPRrQda/ h/2lcchdzqK1tzNe6NjIVVe1ICyMPAqusXyXJ/4pAYjNaiAky3LshKFGFmX1HHh2LkZ2 PSdzhquhWWOMtxj8kR90KE+YOqjwEr684dSRLXPld+Zdv6uH1lJGbb/qRzXwlwPBMggC ylAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RmvaQQVqTzYJ/ca4PPIPDIzgTk17HpnAY5XhUH8w95U=; b=PC0EF2POcvmYh/00V5YmOJysF+OJP4JPnzBIalDO/uCnkvoewgVEvYCvzt+VfpcEVw /G2khAva779QbCk3LrC0BEOQXAHOrgOkeeFf4qL6opqLP+EgdMprXk1/3AKtwjmHfp8I ExT0QV+dzZS6tBRCz7aTODAJ2txzIZN2OXOtykUPNPLshbvrLGcUy28ZtifQ3V0aAdYP jQnfy8L5behvkBqZqznW4IMSVgCFkEnRgnJyjKyy0yU53WahIYprwPq/4Z7EVlVAZMBK Nm7D3LAx9RjRerGYF6jffC+/Kk9cOmsk+FGSFHywdCT+6sfu83H1YonMctyeKk3tYytl Z3Kg== X-Gm-Message-State: AOAM5329GvrYsY5PyGsH5WqH2oU/8Kc3x/0uUThnK0S71G7Z5eCEW8dQ JoSNKFDII9eQ9T1rQmK/UIzVdg== X-Received: by 2002:a1c:9e12:: with SMTP id h18mr1132707wme.11.1604956755622; Mon, 09 Nov 2020 13:19:15 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/20] drm/radeon: Move 'radeon_add_legacy_encoder's prototype to shared location Date: Mon, 9 Nov 2020 21:18:40 +0000 Message-Id: <20201109211855.3340030-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon.h | 2 ++ drivers/gpu/drm/radeon/radeon_atombios.c | 5 ----- drivers/gpu/drm/radeon/radeon_combios.c | 5 ----- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 0cc8f081e113a..421f6b26512ed 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -2819,6 +2819,8 @@ extern int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data); extern void radeon_legacy_set_clock_gating(struct radeon_device *rdev, int enable); extern void radeon_legacy_backlight_init(struct radeon_encoder *radeon_encoder, struct drm_connector *drm_connector); +extern void radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, + uint32_t supported_device); extern void radeon_atom_set_clock_gating(struct radeon_device *rdev, int enable); extern void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain); extern bool radeon_ttm_bo_is_radeon_bo(struct ttm_buffer_object *bo); diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 5d25917251892..557960e3b204f 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -39,11 +39,6 @@ extern void radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, uint32_t supported_device, u16 caps); -/* from radeon_legacy_encoder.c */ -extern void -radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, - uint32_t supported_device); - union atom_supported_devices { struct _ATOM_SUPPORTED_DEVICES_INFO info; struct _ATOM_SUPPORTED_DEVICES_INFO_2 info_2; diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c index d3c04df7e75d7..b8cd37d76d8bf 100644 --- a/drivers/gpu/drm/radeon/radeon_combios.c +++ b/drivers/gpu/drm/radeon/radeon_combios.c @@ -40,11 +40,6 @@ #include #endif /* CONFIG_PPC_PMAC */ -/* from radeon_legacy_encoder.c */ -extern void -radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, - uint32_t supported_device); - /* old legacy ATI BIOS routines */ /* COMBIOS table offsets */ From patchwork Mon Nov 9 21:18:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320981 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000294ejb; Mon, 9 Nov 2020 13:19:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzF/CjSIrrDURXfPeeItOabyY/lrfqL7fCgrsQedRuMV763rCKwMROjL1Re8ibcS1j1IxZK X-Received: by 2002:a17:90a:7089:: with SMTP id g9mr1238756pjk.47.1604956762049; Mon, 09 Nov 2020 13:19:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956762; cv=none; d=google.com; s=arc-20160816; b=ttiYp8TqmqvOsEIwFWuUm9+hpqAdMVoSK6k4GQzL+/znbMiiuojOIfLD8sC7chFfQG Uggso3u+6rhZvuxfcTRIPMtOIeUGlO+LtPsLWIAVR49GIDBsSqgUxpanWwX215YbVU/+ OGLURfHt+C+TUamG7YAUmqNpImngXg1x/YOSuiyXs3gD9zpVR/Wr8+4nzS7ufVpBXNc5 rzYdire6RV+RW03lQG9tK7UW3MUUxIUAlk+J1WLBEKImzJx3OENUUdXVFenr73VR7ZrW iwnhISSXKQxRb2kAtVD9hXJu8mZsHKjY4LaO1dP4UVjfkuWgTfvpFDoiFqPmiOJBcPZx ynvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=80LNNT4qVS8hSxFjYeln82j5SJx40hHgOSSEDG7DXQ0=; b=YHFjdMOzaj275AgtC97XGbH9jY/rnYNDxHaeVbI2JzSGYcni8pAISgXeu0eQt8cKrA T8ngh4WSBCiEvbVgN8Uc9LxdwUwhJ3tvE0HGcV2vhobg+4e49YJ+r+IPfNn5Z0tjXBXa 1fBfOJrAwLMkELL3+FGPy4nZW59tPKKF9pjLPN7I9zecXDAc1kJZiEbZCw5ory04fKf3 0CM1XcjMR3vTG66bijKVtvjgxYBRcfVV08esKGCxrquBHP7yB/lwChAg38mGCrM35mhi OY4wyX6xhOFjSvKDZ+P660RrGfulR7cHVzV5xVuA04IYH8RMHXJxvG0J1Fril8UhnExr 3Miw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=vDRSOmaO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id ig12si502235pjb.59.2020.11.09.13.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=vDRSOmaO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DD7589590; Mon, 9 Nov 2020 21:19:21 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10CC289598 for ; Mon, 9 Nov 2020 21:19:20 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id t67so902273wmt.5 for ; Mon, 09 Nov 2020 13:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mNbwgos7EBbAiIS/whVqYV59kF6ty8MKTbhrWe3Hj/4=; b=vDRSOmaOWfnFuTXwEONPBcO8vJz7zF39LmqlgHPib6OIXViysSis7axMfLToI6uzcL fflPl+k/7ZFLIGyyXOLQ3TiIrfwGxSkGA9MmRO2uUcGtCt0kGjl+uBPJRp3aPomVX1BF EsHIQZXRDK9Vnv4zD/sgKAUuLnYw0kUHMXsav4ieFfUvp3ZnOj++Jot2LssQVDnBcsPx 39lCcPvgMs9bMyUsvFNk7r5g109XNQaut2J9n314ZUar9st0RyOSYygednECLaUvqshj UwCOwCaWkMWuHpYepBA4xCTKSRCE/Z6mWJww+6Zuk694xH4pxg0gQXodu1LbNfYithWA sLVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mNbwgos7EBbAiIS/whVqYV59kF6ty8MKTbhrWe3Hj/4=; b=dQeC2V31+6feyBQMFUPOFFjO+U12dU8+Ht5NHX5e0z9PDl+pqXSDep+LJCAlNWTV/g IlgGyUkByLrc8xqCMEm4TsLEAxzLYaCL1Q3uitCkDYYAetj0H5d97TDxjaAnC0t297mr NkNyHcELrtjlpE6ciVPDTbsmFWnU4zYaJ22HJliSI6hRbvctTAzkhlvf01FKdIQsqD/6 bv9+zO+fGW1Dxiktw/I38k+WdQ7Xay7kw5WdAVMfI/4JdF86nZ/DFLMEQiiPdmSapV6n h+ElEV1ruajKi9rWgcRiqbr8cY8l/dV5O8cx5uRcOt+OhCvjah3d9qmwplebIyEb0saA 2hsg== X-Gm-Message-State: AOAM531pzjHhO0yXLqMXRSRRD3cm+pmihKr5oJvzjmSXXskiCRGBmkuT 3SX6zAQ3mC/uvPtcrlesBjhY7g== X-Received: by 2002:a1c:9950:: with SMTP id b77mr1103869wme.123.1604956758642; Mon, 09 Nov 2020 13:19:18 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/20] drm/radeon/radeon_connectors: Strip out set but unused variable 'ret' Date: Mon, 9 Nov 2020 21:18:41 +0000 Message-Id: <20201109211855.3340030-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_connectors.c: In function ‘radeon_setup_mst_connector’: drivers/gpu/drm/radeon/radeon_connectors.c:2574:7: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_connectors.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index e308344344425..607ad5620bd99 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -2571,13 +2571,11 @@ void radeon_setup_mst_connector(struct drm_device *dev) return; list_for_each_entry(connector, &dev->mode_config.connector_list, head) { - int ret; - radeon_connector = to_radeon_connector(connector); if (connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort) continue; - ret = radeon_dp_mst_init(radeon_connector); + radeon_dp_mst_init(radeon_connector); } } From patchwork Mon Nov 9 21:18:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320983 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000354ejb; Mon, 9 Nov 2020 13:19:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYXeKUfeMLL6OF6miTtt5FXq3ApAPBrOKzJFvoq20XjWmLY9Mt2x4ilXZpjUTPSsHRUnUy X-Received: by 2002:a63:234c:: with SMTP id u12mr14532296pgm.149.1604956767810; Mon, 09 Nov 2020 13:19:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956767; cv=none; d=google.com; s=arc-20160816; b=aN3BR4i2Z+ZlAXHzLk7UIXuja05kzuiQju0CEay1a9Oeqh6KpHvdzYv30HPR0riaTH +Xq0O+kfWcPqpqZGHuJeezalvhsCiWYM/NWncMBL3cmM4XctJN0k5hgodYV51T/8s7vv XtLD5sQRPscHm/pTMcBm0c73hOz1ASV+6sQvRiqR1hihU7w0w/87OhEAzZVJI+rGQu6F hWsZDQunuI98UWSmZs2laln9aZmdd6Wg6UU83lJSMvKaQsa08GYYLC5WibtoTGFAgxEf MdI1IKnO19PGb/xtAy7YZ3es95dfwvVXf4GQQMPmUKRaxckUKApgKCOyRZQwht8IDf0G Q7Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=DcLFzSF7SjUCoJo3wAV7LVVlOBPWIxukk0YZ6PBHzUw=; b=ii7lMALyNYa87JFQ8Ak2WYZxeTJkj2JrQPtkOWno8OP8sg61K240i3DFJoD6HIFMf4 SBlPZevMRfsh/J4G8Iitmv0irQ/PS54Av7X8dPHxFKK+p1MCATpbcKUumVmaFuQ3R86R Ttnyez4t0SEiVcdGm2EZ7SojHu07ZpU+IkF0k6k6JpBBy8a2lYS1oyBOxSD984cQlEvD Nxqe9dmzcNiBa9n50QQ+434AOCFiQEt27Kpdbd5hbx+2j4S+xUnxSSIF3zCeESM0eQhu A/OYoXZaTc/cp0qA0tZsqzX2L/cARZJI2Orf43hUlJQcVrQ+xjQ2is6/4w+8pxtKRtJu aoww== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FioJyxPL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id b10si10066320pft.269.2020.11.09.13.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=FioJyxPL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2C9389336; Mon, 9 Nov 2020 21:19:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 456328913D for ; Mon, 9 Nov 2020 21:19:25 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id c17so10372074wrc.11 for ; Mon, 09 Nov 2020 13:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R1FKv2blGXbscAB7wKDEc1cac5g15gUeFIAgqfSJF6w=; b=FioJyxPLeJAUtobkLDaKIkmME9xBKEy47Q9FG/W/6yyZv2S0N5LgGTxjipqJH0Ic7z 7O7aoSIH0b6KWnTCeiLyOlX4PzanvzFhWVpR5qoa0amSEfrtzUxepB6fY5WLRJ5Jfnzm c2dNShFGlyjTrh/hS4rsX1zH+8qYiS6WOQ67brpZ7qzIgUOHVvSwuWENmC9jIFj645MA Xb33uxmCmy6o2SGrzeyUwHROne1dbDp9fNKNXUfk9+yFZ1dsf8gX3f4tLB/9FuW590/1 VLciwVZw8Kh8nvtdTJ2ejXFLbWRrQ68+EyhhQ4bPpezIErzIqIbGGJ9GOki4QtKA/G8m tiIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R1FKv2blGXbscAB7wKDEc1cac5g15gUeFIAgqfSJF6w=; b=a3PMiRV8WD+VJiUHf0247Sicp6/KF/3adSeehVUp0UjzhtfgjSPjTsgWl4XyYMsIy2 gk8GwW4c4E0W5jJiFBPzSaQgsXcQQVnwgSwd3IbQeMjTTBBBeuwvhLdLWZ6TtePiJq4B 3diytB8pUtxRPOSwWgUvZj3A/LJ9y8JZ2CuqSEhEDf6P+FCGieCEPhfjgK4ewXGARu+M JGJVOXh7Ju5ZFe95si47pP77VWU2C0ACihjq7MCTYrrYLh5mJGjSWvndWXtq0AIo9jWY E7qsO9KdSHivq9PkxtH1PWf+ylyTP2Ih0NCPCxxGLIwSGy9AOh55DULwtXPQtzTszJm+ depg== X-Gm-Message-State: AOAM530+B6ssqAF0gQHI3A14E3WpAf+Nfo/4Pu3Gx3pqCFjAMKn2lDYB kstGY8c4nk+DhvRdQZm5puUqVfdzkRG/s0yV X-Received: by 2002:adf:f546:: with SMTP id j6mr6858247wrp.219.1604956763980; Mon, 09 Nov 2020 13:19:23 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/20] drm/radeon/radeon_i2c: Remove pointless function header Date: Mon, 9 Nov 2020 21:18:43 +0000 Message-Id: <20201109211855.3340030-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_i2c.c:46: warning: Function parameter or member 'radeon_connector' not described in 'radeon_ddc_probe' drivers/gpu/drm/radeon/radeon_i2c.c:46: warning: Function parameter or member 'use_aux' not described in 'radeon_ddc_probe' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_i2c.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 545e31e6cc3a9..aa61b3cb4049c 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -38,10 +38,6 @@ extern int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs, int num); extern u32 radeon_atom_hw_i2c_func(struct i2c_adapter *adap); -/** - * radeon_ddc_probe - * - */ bool radeon_ddc_probe(struct radeon_connector *radeon_connector, bool use_aux) { u8 out = 0x0; From patchwork Mon Nov 9 21:18:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320984 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000383ejb; Mon, 9 Nov 2020 13:19:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwkB3nrNYRrpAc872qnD6dfdqb9ZhO5neSjRkISQ/OL812Rz/zbf4awG0CwJUiQW5GDi6EK X-Received: by 2002:a63:6645:: with SMTP id a66mr14823967pgc.207.1604956770406; Mon, 09 Nov 2020 13:19:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956770; cv=none; d=google.com; s=arc-20160816; b=fC+ef5FUJmXutVd02sYkom6xsgl0UM40xp/IHGLoDXkMFFocKgN5KhsVZ4sYia8Rfv z2o4TUtrZN6KIhvFAWb0jY4ozFbQy8TYG6b0fYKajxKhT/EiMxQa57lwr6gFOBf5+Yk2 abLjt6yoUHPubVr1RPfR0WnooLvmIZko9hECe98TbISgJXYL7snx63JWeH4nTHrnxaeR SLcil2NgQPVyXt254icEuONusQ4FCrkfwZOEH+DDx4HzKUCM1PSkcOHXDtXRr/5wYZkV J3KCnQR4SZzvq+0mHLEM7nAicm0/7K5YpUAO/qjUrRGVT7lJAPuvujfPN1jxNfZEBG8X LhoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=un9asFAV45eObPhA16C46Vr3WSaG3Zh/72qEkaQzz9M=; b=gth2cCKiE6tzAOoYOa3vCUQCeTGXdbtRWDBp4ZCOiHVvuRAHKOoLL3UBwNB6Pv89Gw 01G2BpFNvoOQXyvxxi+tPt0FNpiJXTO+NYutXk+XNiGNJISVVMYVgdCOON5vnKGyIhm7 MkReIjsdFbEg5ftCFVoWmcZmsV+0Qjp5x0VfSYhf8J4PEV9pvDcsM4w7gKvkrmvippUU 1jvrG5vuajwGbSQkxGoP5khF8PqAzLwwRrfvzmB9kNNU0q2lCL1p/TcvBHo7zOVSVswn 9DDef6dfyjmrJg972hdlOLl87Oguzvb+d8wn0txK2xgEyWcmU7ALNQbtF9eR1Cqd9OQn YxTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gos6PdJK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id a24si549520pju.3.2020.11.09.13.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gos6PdJK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3165B895B4; Mon, 9 Nov 2020 21:19:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 159B489598 for ; Mon, 9 Nov 2020 21:19:27 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id s8so3284477wrw.10 for ; Mon, 09 Nov 2020 13:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tr0ixvpAne6ZdwZHnMFSb4ufpkRvb3k+F4potoikpiI=; b=gos6PdJK9eoOZt5jAVidZVPiNSp7oMO7v/VwIq7DXK6v8BMHqbyy322XdWXNcfBWKf rYyWHR0GBx0IoFGoaAXbiyoTaY9cr2uiACim4xVlAVhQp/drKv8pdLkhLS/HH5Kkx5md tol4j4FQeDeqF37INsLFh+mswbJiu4IN7tG/6B56wbIe2ENo8DXUBHxhH/Q+KYN9N6oH SelA1dZwpqUDcK+AXu+wxqkKMHHFLCicP4Uu5f2aAIJHV65JPoXv5nKByQNEr4PA1sO/ nexs/LOKUrdFkJwytG62ilL+tRypUFvudMmo0ni9onyE480ckbyN2peZV9UCw2Qys3c0 PIog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tr0ixvpAne6ZdwZHnMFSb4ufpkRvb3k+F4potoikpiI=; b=MSqWsf3QfWwZMGrVfmW6uLhVSIlYjZfFPw+hVrwG4ttWFG8Ge/WEFheBcKPDXnwKnJ QZrtURQYZ1ClCdfsmmsCDwEGyu1+2pQzLpSy44Wr/IRlIAVdx+kXghSMj+Gg9GJOEb4h P+ovITKimUntDUNxgJpu9XM1WYYqCLOjZl5lFDoZDbl4AeXNzahYWvn+8xF62IwupFmw xbgl7SdCbUa9miGZOmihCYSKyHK4dD/Mh5cJ5tqqPRDaMN9a5viJ+IqaCQA2Sf/SjVsO xrwex1TpJANWgueRWIasWHonKpZmDDDe861egHWgMQl4cTGC8Xd6YVqEoXv7ZiACClz+ QwCA== X-Gm-Message-State: AOAM5337ohUUu7Ahesi+jGUsliEgxjN9SaZDzpjc8sq8DGO5+Utc/Epn 309fEdwAJB1RsePRHY66KCdObw== X-Received: by 2002:a05:6000:1006:: with SMTP id a6mr11354521wrx.367.1604956765807; Mon, 09 Nov 2020 13:19:25 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/20] drm/radeon/radeon_irq_kms: Demote non-conformant kernel-doc fix another Date: Mon, 9 Nov 2020 21:18:44 +0000 Message-Id: <20201109211855.3340030-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or member 'irq' not described in 'radeon_driver_irq_handler_kms' drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or member 'arg' not described in 'radeon_driver_irq_handler_kms' drivers/gpu/drm/radeon/radeon_irq_kms.c:571: warning: Function parameter or member 'n' not described in 'radeon_irq_kms_set_irq_n_enabled' drivers/gpu/drm/radeon/radeon_irq_kms.c:571: warning: Excess function parameter 'num' description in 'radeon_irq_kms_set_irq_n_enabled' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_irq_kms.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c index b86bc88ad4308..3521084030d24 100644 --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c @@ -43,11 +43,9 @@ #define RADEON_WAIT_IDLE_TIMEOUT 200 -/** +/* * radeon_driver_irq_handler_kms - irq handler for KMS * - * @int irq, void *arg: args - * * This is the irq handler for the radeon KMS driver (all asics). * radeon_irq_process is a macro that points to the per-asic * irq handler callback. @@ -556,7 +554,7 @@ void radeon_irq_kms_disable_hpd(struct radeon_device *rdev, unsigned hpd_mask) * @mask: the mask that enables the interrupts * @enable: whether to enable or disable the interrupt register * @name: the name of the interrupt register to print to the kernel log - * @num: the number of the interrupt register to print to the kernel log + * @n: the number of the interrupt register to print to the kernel log * * Helper for updating the enable state of interrupt registers. Checks whether * or not the interrupt matches the enable state we want. If it doesn't, then From patchwork Mon Nov 9 21:18:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320985 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000408ejb; Mon, 9 Nov 2020 13:19:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwy/eumOwf/9zBnO8+lovdzqT1CgrXeaaVabu0Ltjz3TS5YlJJBzDjU8D2n4IpDtd3Q5ocW X-Received: by 2002:a17:90a:2ec3:: with SMTP id h3mr1233919pjs.54.1604956772577; Mon, 09 Nov 2020 13:19:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956772; cv=none; d=google.com; s=arc-20160816; b=AD7pbVpNAFkYzYzcKJwr221FU14W7q/RrZFq3YDExHEjsjl2DN5u/Gm5XPrzi5IY6T swcbyZt46sOHJtINBiFilMujrcDMY7KM2a66IWiDWR8y74Tfc1cnVLitqDdjcK4ufMhd ESh4hnvUv+4BLqoOxmZvBdcUva0ztCRS2YOpGMB89CceuM5/I7tmpx35GG1wivCBEKSF 4fFNksXHizN/g2fU0H5teCD+WYsLN3qFG5oCd1Nsa+rw30Rfz20/GHlAHcJCMSUFb9Jz +x7KFCREul8amped2hfTtnh42APdM4b6dFLEA4Nj65o2BKAvO3xCMJZVJfDCVxWzJGT4 Epiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=UWQa05Anfyf/fM0t98fyHNeHd7De6uImlC/x651DIto=; b=LL0f/tPRj7OEvgOxp3of0fnktE2Dwgic3GVoWM96upYLJSDrlgIqQvZC058vjew9Fu LQHX0qnh3EWvemoZlMIvv/XStTiLDT0KCnlk9mG2+xgrqbHZ2brGGXBMT5jX3dIrEKYa jqDqXEcVJQjNCYOVXa9QzQREG9xyMzJaxTTeKnvmCDsGbWSa/ibenhu7CI8bjbhbkQT4 O/2jQMF4VJBmVh6YErmgfh6tJRaoOpbKLrkv6lFDhaq/VKpoo/dR+3FRdpCe84Zq47lu +r0JG8vXeU2kRoP/g1XlpC2qvQIM/MWPsG7+ZvvhJ6BXr537UqwosE+AzKx6BqcfmYJh K6Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AaQNQ9NI; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id v189si9471498pgd.204.2020.11.09.13.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AaQNQ9NI; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8444F892FA; Mon, 9 Nov 2020 21:19:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id B655A89272 for ; Mon, 9 Nov 2020 21:19:29 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id p22so942915wmg.3 for ; Mon, 09 Nov 2020 13:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hg/I8hWx//QmSj29JDx18mAH+iG9CJqB6Lurd4l5hM4=; b=AaQNQ9NIHkRGoTiIRF1aRbT+aRsVQOm3b9utKoz6DPEumCRmo8ulSQC4s6mp+erOM4 LRXMWkhr0iRHwoQjDKD2CWxMIlFyviTFAewCFYg+m4eNcwLPgs7s7FaXFliAQ1D2LNYV KWWf497r8hxqorMREEcQnOEkHSmQ/oOI+acP+sT85BS6Jj9aCQSUZF/n4aBwaS0ouFNB dQfab8IsQ1wI4bP4VpeVJXWYH450W4LDxGaHXJSDMkuD5kIIVpdbF/lAMSFhiteMxQTs 8AaotcYN+NonRvAYcA2ThRjOs5m937qryN9440lKxewZFO8wEihMG2b7zvWDLNIsgBAP VvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hg/I8hWx//QmSj29JDx18mAH+iG9CJqB6Lurd4l5hM4=; b=cLFe+u0dRGyfVLUuhVFlsewhHiJAU8DpS1KPPXdtnVPV8eA3amDrK8iERzdniZlIAF KCLuo1GKGc8RRcx7mZCBrMWhCAhJ+lJ1kv7snqYf9FVhNUYjeK1pzRhesQYBf1UtKZpN c4nI/H7KwE/bn9snld8iAp37UISK7JC2JYo9oGmhwYjlt7kwP+BpLl6rIJ08AmDuDexb l2uIEW3aWDmVnNXsfoBDV55EsrG/v1NKsrYWY/d2WFMmUkekNnoX0dJwmsNv0rEbpVjP 7IA4rgi6Q+IUWwXP8fY1So80uHqeNiw/bgisT4ocK1XYYO3m0NtviJzJFUdkoQtHJ0O4 cKTA== X-Gm-Message-State: AOAM533ce8Ica0A9mQKTDphw8HbZxtJmYOMoKHrpy8buUI1yyQkJUuBI OWjXtM3+oXPyqfuXr9XMsQkeDA== X-Received: by 2002:a1c:790c:: with SMTP id l12mr1056495wme.47.1604956768392; Mon, 09 Nov 2020 13:19:28 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/20] drm/radeon/radeon_ring: Add missing function parameters 'rdev' and 'data' Date: Mon, 9 Nov 2020 21:18:45 +0000 Message-Id: <20201109211855.3340030-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ring.c:226: warning: Function parameter or member 'rdev' not described in 'radeon_ring_unlock_undo' drivers/gpu/drm/radeon/radeon_ring.c:240: warning: Function parameter or member 'rdev' not described in 'radeon_ring_lockup_update' drivers/gpu/drm/radeon/radeon_ring.c:283: warning: Function parameter or member 'data' not described in 'radeon_ring_backup' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_ring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index 37093cea24c59..c3304c977a0a5 100644 --- a/drivers/gpu/drm/radeon/radeon_ring.c +++ b/drivers/gpu/drm/radeon/radeon_ring.c @@ -218,6 +218,7 @@ void radeon_ring_undo(struct radeon_ring *ring) /** * radeon_ring_unlock_undo - reset the wptr and unlock the ring * + * @rdev: radeon device structure * @ring: radeon_ring structure holding ring information * * Call radeon_ring_undo() then unlock the ring (all asics). @@ -231,6 +232,7 @@ void radeon_ring_unlock_undo(struct radeon_device *rdev, struct radeon_ring *rin /** * radeon_ring_lockup_update - update lockup variables * + * @rdev: radeon device structure * @ring: radeon_ring structure holding ring information * * Update the last rptr value and timestamp (all asics). @@ -275,6 +277,7 @@ bool radeon_ring_test_lockup(struct radeon_device *rdev, struct radeon_ring *rin * * @rdev: radeon_device pointer * @ring: the ring we want to back up + * @data: placeholder for returned commit data * * Saves all unprocessed commits from a ring, returns the number of dwords saved. */ From patchwork Mon Nov 9 21:18:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320986 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000460ejb; Mon, 9 Nov 2020 13:19:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJy22R8hA0oMRtSgKtX05fZGkIE2BGBfXXaZG5OLPiBSsYkpfTXSRFWCLfnBCvbD+BlRWLvM X-Received: by 2002:aa7:83c2:0:b029:156:5ece:98b6 with SMTP id j2-20020aa783c20000b02901565ece98b6mr15494159pfn.4.1604956775697; Mon, 09 Nov 2020 13:19:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956775; cv=none; d=google.com; s=arc-20160816; b=Jyc92Zb8TkV26DR9SuxDmuS5JHGD0vAdAR1hsksg2LsRzErmC/NrxJPqmQ2GgIhpCM pj6a/Kc1YSU4RHvmXRxSN/i49yxfycM3GmgC3F3/CHOUzx17rBHORfpz6iNHuv40SFYh TSBFCMHLCnAs8wM6e+wdKEZSNtMXDHInbjMCPgmiyS3JJcEgTofzSckrgijyAB5iV8Oc Z/1HPChIZdu+HnubB50Ri02EG9C8Q/CQI68Gos8GLgdG2Xq/WyS7pZ8eotAIhKIb1QhV B/iaqhNupDgFhX4qQFu1yG04ZWHt2GgUHAtPFK26V+DKsuLMPlZ0dATckA02HqDsj0uB RV2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=tEyAuyZPkHXXZXVx6cB+MZus42hCiMrXpVsyqjLbBIk=; b=IGG1Q/3bQSIWsowZp0/iSWmd8MHYCEYj4jwlDPWuxReRoCbsX6paKu6JWFchcBdl27 ueW07DwXzQL4RdDZqmbRepvxfvqZyLqAbMdhlB+sZnzlGVO0Pk35TT0W20Vupvs0Yok9 /hvUhLuTE0GzLKMQaMb2jO3umKuGgAHvdJR5BC9ngs/uD1yORCFp8jpQpuvocHef8tmw 84sSqI6zPZj2hatIfT9Nz7zbLZUom4UDiqh8yVwGkmz7P2hbxq1S8UaXHm17fEYhEgww ymJ7dsAmqXlXxQipB2zNMfFh7xLoZue39SN5R/TA7/eT03JbbR2ZgPY3a0ZhURGxhDa/ Dl1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ONMp+BLP; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 6si9883401pll.382.2020.11.09.13.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ONMp+BLP; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7B8E89598; Mon, 9 Nov 2020 21:19:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC6DB895B6 for ; Mon, 9 Nov 2020 21:19:31 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id 10so951862wml.2 for ; Mon, 09 Nov 2020 13:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T1sUvjuz6GhGo/eyfmlP/SOHCvkRA45s8OKsudAKYNE=; b=ONMp+BLP0pr8GPw4qGQ5ZafDFD+hKfVrwwI3l0QNlbUCStl/4v20Q2yKrVeUVieJ/1 /EHEG++w11JWCuRkI6pVfbliwTpAMswOOxzKqHVOuq4dDrk74KHAaF458LgMN+/XKWAo SIcyz5tZ4bXs7cGR7YqPOFdKiJ0skIJ5jsFNhl7Ea5Q9szqmPq2TCH/UZxpjE3K9EV9h vp4QUfIDYNirEHinBWvHkQ7ZVv9RrznVs1023gtMY17oJIpvTUzdQtaJaPCJiVyVnn9g AX3v/5GkiAAnNlntob34lzgthtPjni35Do2nVDGWEYGZz7zDBJruQkiw8wHElCLheDdp LP4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T1sUvjuz6GhGo/eyfmlP/SOHCvkRA45s8OKsudAKYNE=; b=QpVOrfQc72CrUVS8E3lsK9tEKnOb0+sUv97UXCoZCY+C/ES1nAPgJI1HQLmYiIudmW yzVAwjNrcUfYRdzMBTzp4WnyvO3vq/+gJQ4vYp32u8XgtlB7A/N5czZNqdNOytTgZ4z+ ZgGyYGMyQRwiYA5h1sRYy5TknZd9YfhL44m9/PDs8FXtTBbw2OHVx5mFO/ues86DeO4t 4LVqhQkKtxxaNj+kSNYopjsL7WeRt6yfsJZhzUhiMrM/tdYHa/J8U8UmbonUOf4ewi6O RyqgFZgQupsRxsQU3fcsFhJrdDoZd493jQwhiORIYeqKKb6Lnqx7s+bHfJXXRKXYWs9M s22g== X-Gm-Message-State: AOAM53056nGWPkKTmMP+ZDPaRcQlaf+HGamUZOs/iNFHirT1yNyIiHcm +Anowsod47JEwTt5n1AgVtonYQ== X-Received: by 2002:a05:600c:2110:: with SMTP id u16mr1168189wml.4.1604956770543; Mon, 09 Nov 2020 13:19:30 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:29 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables Date: Mon, 9 Nov 2020 21:18:46 +0000 Message-Id: <20201109211855.3340030-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600.c: In function ‘r600_pcie_gart_tlb_flush’: drivers/gpu/drm/radeon/r600.c:1083:7: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/radeon/r600.c: At top level: drivers/gpu/drm/radeon/r600.c: In function ‘r600_mmio_hdp_flush’: drivers/gpu/drm/radeon/r600.c:4393:7: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/r600.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index d9a33ca768f34..6e780b0109995 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -1080,7 +1080,6 @@ void r600_pcie_gart_tlb_flush(struct radeon_device *rdev) if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_RV740) && !(rdev->flags & RADEON_IS_AGP)) { void __iomem *ptr = (void *)rdev->gart.ptr; - u32 tmp; /* r7xx hw bug. write to HDP_DEBUG1 followed by fb read * rather than write to HDP_REG_COHERENCY_FLUSH_CNTL @@ -1088,7 +1087,7 @@ void r600_pcie_gart_tlb_flush(struct radeon_device *rdev) * method for them. */ WREG32(HDP_DEBUG1, 0); - tmp = readl((void __iomem *)ptr); + readl((void __iomem *)ptr); } else WREG32(R_005480_HDP_MEM_COHERENCY_FLUSH_CNTL, 0x1); @@ -4390,10 +4389,9 @@ void r600_mmio_hdp_flush(struct radeon_device *rdev) if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_RV740) && rdev->vram_scratch.ptr && !(rdev->flags & RADEON_IS_AGP)) { void __iomem *ptr = (void *)rdev->vram_scratch.ptr; - u32 tmp; WREG32(HDP_DEBUG1, 0); - tmp = readl((void __iomem *)ptr); + readl((void __iomem *)ptr); } else WREG32(R_005480_HDP_MEM_COHERENCY_FLUSH_CNTL, 0x1); } From patchwork Mon Nov 9 21:18:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320987 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000486ejb; Mon, 9 Nov 2020 13:19:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxG+Sxd+m4xciNHnq4uArVFMXsStlXgb4PeZZbrixLs1grg70IBtoexblvy9/R+PROfMx3g X-Received: by 2002:a65:5c43:: with SMTP id v3mr14838542pgr.271.1604956778560; Mon, 09 Nov 2020 13:19:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956778; cv=none; d=google.com; s=arc-20160816; b=N8Y+QNc0Pdweloc8fMVLCuUMorcI10uMFY1yfdKFdZbn6uNbdDmImr0eyIlE/04Pgt 1GIpJKGqi5w3ruavaOHvuA67crQBswf2h5zBnxSnflW0tkjMyTHJ4TqLU876uGXoLR96 kZ1P4TjKbSNk7BMSxYU3aUS+0ht/+x1LkwE2VDFVAzSGWWLbmf5BvInngzJyp+216U6a P6bI+OlScGuOKHtioLVPdK6DHjK+TJA8odlfIT3WXYBIuygIxCzjW7739LcgIaEfOLKQ KQVc6Wwb4ShBvloSOruoec8p+6g9UzqwMifZjx4M8ypNkyhm9ekSrWd6L/nFcDkw1de9 h3QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=/Eqp6y1U6oV3l2da1RgVXnZb8ac4lrHEDzyZU9KgpXw=; b=T/HbdL/aiL0jHrd/e1oAtmRZDMOe1gigP1hZ5T7X550rnSTtj9Gud5SL04mcrif1nT /mGWzTKbEMD2Qu0aWtJO47+NDiur7ioEW8D/IBdabOzBT2WpzDN7HWsYTflmH1T+0f+W uV7ayjOBrikJGXHRF3FXSGmTDFUyiHSPxyl0GCWyLY3N3zuY9tazlMKs/hmqp/OPkMet ybKfv9QDOLIZUkPlOQC56x1O07qdoRQNGuOiQOyuG+DWp+D4C04P+6kMVscWRGKFuCSj o/0x0WW5FerPBYgGDvxazBZhfSBlUZTQqiGljY8T1D0fx0L+DDWGQY45paDWDzOtwoRx xqQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b5h89XM0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id d15si6859306plj.361.2020.11.09.13.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b5h89XM0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 962D2895C8; Mon, 9 Nov 2020 21:19:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 908F989598 for ; Mon, 9 Nov 2020 21:19:33 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id c9so935590wml.5 for ; Mon, 09 Nov 2020 13:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=b5h89XM0bSAA01H9VI7YC0WubiXdlYohWOGdakYwfbQeM0MifG/HJ7RiJjyS8bNAqv Yq0xrDdJ/NdDCYnAvDV+Gz94LXJqrl3Y9rQ1xU5cQVElcN9MRBYPt7zShja/Bk9UKiY+ WqQGtf5m5oHpwx0PpT6vx6sx0WU+595ypt6m//MfqLkRGLEVbmlBXKkjvjc4+0QCw5SY 32zJqgbybJVw0CEE2G/rBftR+lVzzS50Z19Gnxv32vnSAyV0pO+I/ApDOOXfswqPnmLU rAqt+Z5FRuuTuszclEWd6FGcuvBK9Rvt+6Q2ubDA7I6UNZGYzp4HdqjtuyoOZzsm2oeB Q+Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=tszxkgsV1HJ//YftaQpl91T4bIC70t27RBcp+ZJo93gwYYShXj8JMVpdXSQmebAdvd x0rQkEATdpR/QSOAmYIlbkTX7jdVR1X3Lgovgk+v/Vxdwj4CZveLeWMSwnBva4n71zij QysbPj5s/OwQqhiM9tHQFvyWdXrOQU1OIh4tK3/1b6JgkWyBTFXDPHtdYHVCVQ9MhDAc GKaW8hKPWJFJlHhlwOTmiaZwnHRrWupMFedB9R9n7boAjTo+NLC4aHOf5JV3NI4YA22r 6X7uU59oFRf/BLGgr4IieT6MCmeBAw4zmt8ZXK/wmfX6JAHeDNvh2S3KMJCV6IXc0xw/ 6bEQ== X-Gm-Message-State: AOAM531k8lkbJmnmHHNnWRE9V5GnsF8noMVp9lk3xUfT9frQr3gjRSni S/7EWGBSVA51Y0PhuEbhHSCybA== X-Received: by 2002:a1c:6545:: with SMTP id z66mr1082675wmb.157.1604956772232; Mon, 09 Nov 2020 13:19:32 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/20] drm/radeon/radeon_cs: Fix a bunch of doc-rot issues Date: Mon, 9 Nov 2020 21:18:47 +0000 Message-Id: <20201109211855.3340030-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, Jerome Glisse , dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_cs.c:416: warning: Function parameter or member 'backoff' not described in 'radeon_cs_parser_fini' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function parameter or member 'p' not described in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function parameter or member 'idx' not described in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Excess function parameter 'parser' description in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'p' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'cs_reloc' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'nomm' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'parser' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'data' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'offset_start' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'offset_mask' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'reloc' description in 'radeon_cs_packet_next_reloc' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_cs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index 21ce2f9502c09..729939df29cc5 100644 --- a/drivers/gpu/drm/radeon/radeon_cs.c +++ b/drivers/gpu/drm/radeon/radeon_cs.c @@ -408,6 +408,7 @@ static int cmp_size_smaller_first(void *priv, struct list_head *a, * cs_parser_fini() - clean parser states * @parser: parser structure holding parsing context. * @error: error number + * @backoff: indicator to backoff the reservation * * If error is set than unvalidate buffer, otherwise just free memory * used by parsing context. @@ -723,8 +724,9 @@ int radeon_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) /** * radeon_cs_packet_parse() - parse cp packet and point ib index to next packet - * @parser: parser structure holding parsing context. + * @p: parser structure holding parsing context. * @pkt: where to store packet information + * @idx: packet index * * Assume that chunk_ib_index is properly set. Will return -EINVAL * if packet is bigger than remaining ib size. or if packets is unknown. @@ -829,11 +831,9 @@ void radeon_cs_dump_packet(struct radeon_cs_parser *p, /** * radeon_cs_packet_next_reloc() - parse next (should be reloc) packet - * @parser: parser structure holding parsing context. - * @data: pointer to relocation data - * @offset_start: starting offset - * @offset_mask: offset mask (to align start offset on) - * @reloc: reloc informations + * @p: parser structure holding parsing context. + * @cs_reloc: reloc informations + * @nomm: never actually used * * Check if next packet is relocation packet3, do bo validation and compute * GPU offset using the provided start. From patchwork Mon Nov 9 21:18:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320989 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000515ejb; Mon, 9 Nov 2020 13:19:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwX1FZJAmQnUH0Y0qVsA9rnBNm5xx1xfnCDr+aornoYPPvAH7yFNlTS6x3sabNJM531094N X-Received: by 2002:a17:90a:5908:: with SMTP id k8mr1170019pji.222.1604956780674; Mon, 09 Nov 2020 13:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956780; cv=none; d=google.com; s=arc-20160816; b=TPM34FoZhrVR2uOvUi+QN8EIx2KtVZR7f+1NN58G9u/dv9KBHlugm4DePaFG8OWrKm eRDAFOcD3A73IBUYv2x+uUF7lkW8FdKptZTUXXJ/wLI8J8yGEIuJaIsajhmWkg8wgItR hURC70QjgT/Bh5YvN+gFNDXjSj3VuBJcMYrNnhALC4RBBA5SmgkxpwpKB3tTwQQm3EAd xjSqeGxtaU9/7SGXM1p2jQc+nwQdwX6gYkuwhDywdVyBfSKPlhAtcUsgN37fnwzpmsyw K7llDaC7s/5Yt5dX+HFc8RjUgKTfgQUmo4c18jAiHlzLtCYgJC7plP8aTSfmT3/yPNlv V8Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=KSMfgIisA4x/hAjfmuu9uOjiIAAO9PoT2qmxqcUueRY=; b=NnxR5Ut7Sux1gjjCILzZ10uRxA9ugnDFotPhRof+AcNFmtrTJm7+B3dg7orFvZwV7q Cwo+C/dzWsNdaOg+SyARGWaKrpNrUNmefFv80QNWxHSTbKiEetk5tJea7RfE4oAI6Gkj ORyTR1cAobBp2DkFfPMpKVgguHBY2eo5XDjo8QMtuXz0wcBQh1PnbESoIzyjzUzwoVS5 tR2rqDoFR7PSSjyXbjS+aQwE+W+Rt/5IxRPT/G51+o1rMpPvKIRyLXU64rHbvMsQhJui YU87jXhu93woEG/VKfb06vlYfMPc+gHdsH8EpsAQeXkqft+8/1AhcsxzLSf6e/Z0sFE1 52vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KFykpLfC; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id cp5si510773pjb.104.2020.11.09.13.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KFykpLfC; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB0CC895C4; Mon, 9 Nov 2020 21:19:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DF63895B6 for ; Mon, 9 Nov 2020 21:19:35 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id a65so923151wme.1 for ; Mon, 09 Nov 2020 13:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mP6ncVP3tb6PBoh8PR+HhOmxf1xJDs0FPGkTnD+ivtc=; b=KFykpLfCS//ZsH9E/r0koc17hviNUTM0dyZhwgahRURu3RDlD7WSTPyYvfI4R8B37N ZFI3daldAmSN6II7vkZ85e3c/io1Z3RNNLihM2vj4e44wuAlM7r5dqaY2pDwC8H5SDhx MVXosMn+hWDvCRWFW3ZAc6jqRmjlJQqoWzd+x45NGezmyeXfjnPyZNr4TX3GenC0Kslv 8jDKQGDpJUYd5tCK0MisiUthJtNJogiZomkAVQ4mIqAEpuMMcUSgIerN9BLCTgEJ9vGL +NKWgQHleOmv5Wx5VeN25Eq5miaw3qZyfxGB+zMrOE+/foVnBu/M/3DohTb7/Dk+ROoN 7rXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mP6ncVP3tb6PBoh8PR+HhOmxf1xJDs0FPGkTnD+ivtc=; b=PW18GpNVmoL8nmLeW9vx4EQfPmttBo57hQ8qkXhcNE6D29dv8wZ2A0N2I9CWoZ73wK eO0OvAyw+Pg0MEcGOIubD1+hxc1v/7VqpIstkcHUaUwthTxhc2c+DZsn2eg4P0yg8cmV 4OgTfgbV/ThmRWAJbR52vMC0hs84lbmBC5ln4qraMTQKscq1vLRM/5TUxEZjCAA1Qten N827mpBLVrcLC4Scu6k3+6E+yrTTrqgt/lGz9IZVZ83wm6VUGnWir8tiG9FH3JMW+Vr1 OeTWf0+j5urMP2vGhkynwKInXah8VdK4HEM6PWmcEAKZ+FRohLaGXKqYmcJAP6vZHSIR vuEQ== X-Gm-Message-State: AOAM530i7RVVD/XUYjEz/kKEOV28JD9NrzDPIef5/Y8rvmEPGTcsfY4D wkkeiFlI6bkLWbLC+/ur4/nSrg== X-Received: by 2002:a1c:7f14:: with SMTP id a20mr1125386wmd.95.1604956773891; Mon, 09 Nov 2020 13:19:33 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:33 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/20] drm/radeon/evergreen: Move 'rv770_set_clk_bypass_mode' prototype to shared location Date: Mon, 9 Nov 2020 21:18:48 +0000 Message-Id: <20201109211855.3340030-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/rv770.c:1138:6: warning: no previous prototype for ‘rv770_set_clk_bypass_mode’ [-Wmissing-prototypes] 1138 | void rv770_set_clk_bypass_mode(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/evergreen.c | 1 - drivers/gpu/drm/radeon/r600.c | 1 - drivers/gpu/drm/radeon/radeon.h | 2 ++ 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 14d90dc376e71..3541a9444be22 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c @@ -223,7 +223,6 @@ extern u32 si_get_csb_size(struct radeon_device *rdev); extern void si_get_csb_buffer(struct radeon_device *rdev, volatile u32 *buffer); extern u32 cik_get_csb_size(struct radeon_device *rdev); extern void cik_get_csb_buffer(struct radeon_device *rdev, volatile u32 *buffer); -extern void rv770_set_clk_bypass_mode(struct radeon_device *rdev); static const u32 evergreen_golden_registers[] = { diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index 6e780b0109995..9587792503525 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -112,7 +112,6 @@ void r600_fini(struct radeon_device *rdev); void r600_irq_disable(struct radeon_device *rdev); static void r600_pcie_gen2_enable(struct radeon_device *rdev); extern int evergreen_rlc_resume(struct radeon_device *rdev); -extern void rv770_set_clk_bypass_mode(struct radeon_device *rdev); /* * Indirect registers accessor diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 421f6b26512ed..32a2c894ee3ff 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -280,6 +280,8 @@ struct radeon_clock { uint32_t vco_freq; }; +void rv770_set_clk_bypass_mode(struct radeon_device *rdev); + /* * Power management */ From patchwork Mon Nov 9 21:18:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320988 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000508ejb; Mon, 9 Nov 2020 13:19:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqYRuGYnUA0AfsaYxN6Tqa63b80FYk0RSRVfdo8qTV88QO5y/ZFFRI9jYe2yqysmFoIOtg X-Received: by 2002:aa7:9190:0:b029:18b:6556:1e62 with SMTP id x16-20020aa791900000b029018b65561e62mr15871680pfa.62.1604956780190; Mon, 09 Nov 2020 13:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956780; cv=none; d=google.com; s=arc-20160816; b=Y9513FvA6Cftli2ah6g1Qw2eR3wvkhlU8pqBMtrVznyuj2JkhVPtBm9CE52dgEcZWW ovg+lZlwXVPivuI/oywZjVSdzMyxbBwplUuIFrPZXrwsb3dOCfzcifxaJKeb3nzE/6mY EnvyFZ9sXiD/mAmnOoo9+KzaCMQ4uXAfWgA28A+VTzqlBS99oQ/lRoBlqy9QnyAL04RP HVUW5jMRFigu+Fws5ZLAJsdM/NvIlgtGi+1f6+aiGZZO/jYKnuAmO5PvP0h3Ah6dDwjW i+6RtFvmENoZPDHDG0Y4jz6z+MLjpR0u+RNEWqBdXeULupgEC9v1Iz4DGxOcClhTV/Ai ucYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=dAa3hfookhzV5akOlyrIGlErVP8B0jtVE3nHRW89EcQ=; b=LLoAw7zB5ewK2o59TSikqDV+0DRqn+yuUNlhZ83WR0DsIfN261v6hpBuKuwLsqwdH8 mrgVDRrAZ/1UdVmd+mu6C6KgsdHjz+pbtgyIlz9SMVcDlueVU9/jZtHn90wADI4jdWNi u6vMMXkIZcfb5BK8cY1smon+q300oEfzXpPb7eyQxYdzMhKejr0tINiAtMQ+tQHmkGvp pQPrBLVF778CM9g2cEE1id3f0MJmst/jkVshGxfqi/lQQHdGqosjJKRZ3PLUliGtal7g bfTycuG8odZ0and6ZZDkngGBdUKsxBVD0c1+1ZpSJfiBKv48Kp+fdurcAWguO6bLFn8W uZug== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aCa++B8s; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id h10si3050786plt.252.2020.11.09.13.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aCa++B8s; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55720895B6; Mon, 9 Nov 2020 21:19:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92418895B9 for ; Mon, 9 Nov 2020 21:19:36 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id c9so935751wml.5 for ; Mon, 09 Nov 2020 13:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f19bG5OlKZrzXa9sIoz5zZmJ+HLtlGgA3VlLSxdphFA=; b=aCa++B8skb7N4286tYGRf0uVCE5RA7rp82ko+LOn4nj7tYdW1Try+em3OvGh7LqyHJ MRu9QWNM2UQmP4ba30mnVaQj4DEhUYiDtJAvbyg6Z4WqzCMSMMBCywL5BuHEKRLTQ3Nt 2X145Ci6pyLdMT7zFdh2R7fTC99dcrsXD0EYw9LuP3OsGdalYW3SAGUiCeNOmz/E9yEK mchlHxBojyQih21VMFDS9OpCNNLApP66gmN4r2PoS0bM6GwOpg6mRa2jMWrpl7BtEGXH FFXqxiP6DlTTZZGtyKGVzWqpe9Tq3bxgTloLVFtq3gA13n/n1cc5NsUa3HUiCib0YktV cJBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f19bG5OlKZrzXa9sIoz5zZmJ+HLtlGgA3VlLSxdphFA=; b=fsMloOsmPrmKF6+jOVlgAaSwDf2SGHIjeeHhBme6lFaZTmXsg8t7pC5DXzBZVNmVao gexalIsv3LIOgXQNAq8xmZskAJOROw6DuCKvnrrtXL/NZpAOhxr/0SdRqGNc2epY6opF ZFz89d3RC/jlctXGvD6ZmBfTxyruJpoa2FK8NUogkkJ7rLheGJdDqFFN0BllaNd2iDgD 8Q9tlqYlBkj1mAu/NZwjTfVuarZJHJfQ8uy7K3xcn0Wt64pFGvW5zQ3P1mWv9zVrRXtA GN7ndaRi6oMuY2P8ZT/pREPC6zbAC7nxdEZNGidu9evkf0yJFfrK7tMmKvZuNGzyB3Yr ARbA== X-Gm-Message-State: AOAM532tyAscOnASKdQgmyvgtSUDW/q95SLupWPkjTGj1NZ+xbUKJqkU Gpt28fsscUXz8nI9qclDYtE3mQ== X-Received: by 2002:a1c:2905:: with SMTP id p5mr1138832wmp.187.1604956775281; Mon, 09 Nov 2020 13:19:35 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/20] drm/radeon: Move 'radeon_pm_acpi_event_handler' prototype into shared header Date: Mon, 9 Nov 2020 21:18:49 +0000 Message-Id: <20201109211855.3340030-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/rv770.c:1138:6: warning: no previous prototype for ‘rv770_set_clk_bypass_mode’ [-Wmissing-prototypes] 1138 | void rv770_set_clk_bypass_mode(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_acpi.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 32a2c894ee3ff..1cbbaff7cede2 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -291,6 +291,7 @@ void radeon_pm_fini(struct radeon_device *rdev); void radeon_pm_compute_clocks(struct radeon_device *rdev); void radeon_pm_suspend(struct radeon_device *rdev); void radeon_pm_resume(struct radeon_device *rdev); +void radeon_pm_acpi_event_handler(struct radeon_device *rdev); void radeon_combios_get_power_modes(struct radeon_device *rdev); void radeon_atombios_get_power_modes(struct radeon_device *rdev); int radeon_atom_get_clock_dividers(struct radeon_device *rdev, diff --git a/drivers/gpu/drm/radeon/radeon_acpi.c b/drivers/gpu/drm/radeon/radeon_acpi.c index 6cf1645e7a1a8..0eb594b56af8c 100644 --- a/drivers/gpu/drm/radeon/radeon_acpi.c +++ b/drivers/gpu/drm/radeon/radeon_acpi.c @@ -45,8 +45,6 @@ static inline bool radeon_atpx_dgpu_req_power_for_displays(void) { return false; #define ACPI_AC_CLASS "ac_adapter" -extern void radeon_pm_acpi_event_handler(struct radeon_device *rdev); - struct atif_verify_interface { u16 size; /* structure size in bytes (includes size field) */ u16 version; /* version */ From patchwork Mon Nov 9 21:18:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320990 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000532ejb; Mon, 9 Nov 2020 13:19:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJz9/O6vyVbl13dV7/z4ly4lgn6LJNTeQ+sMo7WmPglvZGbGGfal+o3gsjZnOgXF1YdlqY05 X-Received: by 2002:a17:90a:a81:: with SMTP id 1mr1120642pjw.165.1604956782484; Mon, 09 Nov 2020 13:19:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956782; cv=none; d=google.com; s=arc-20160816; b=MyH811EHcO2DwOSz41tEIYamHyqUabTWjIGxyPAVnClgSAh/CQqA8v2P4q3xoLYw7/ PnuX+x2U1/STAs21IJuxcy9S/9PLV9NoWKLwVeIrjpYn/0hgNOq4KCW1S6t4WaQwx4MH FbqOEb3liFRJ4SMT/XbPXW1JaAJaS17dUKIcz/P06lZ8rUGPdD6Mo7FA+dfDKSiZ0Z+M MAOx4SoBkdt/bBn9wEaHwiN51D+j0tw11NcPGkt9hL3WvujdEIkM3xXv+0dBxg4ggaLp mn4HzFHcJPpIpp0/2H0IyDYfrhASgPE1410WQbOYQoqsvsYF2A8zOHTpeJrRd9o9h/bX S+kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=wxcvzvjc/MeVeTCaDOwBJE4u+qDfW5BGF448tfpUpW4=; b=OEcANUb6i0M5VWt3BX4f1b/85qK8pptWg443khFAeiedgOlt4s7+cxhyAG1OiGz8Ff T5jAsCGJfRMg7mjs5d2ak5tUc6tsLuRgIOpdQuiijfz/dqE19QQecYFYZz9GG5/uwTuG XPgciQYfMO+AYYzpCDNd4wVCWNV03oj6Hm8OyEKK0BNQa7FQFjqDPeUhyUlAsiLchPrG uJfnjj3QAR4Xi4l76viHCI3mKDHsDWDetduLXv+p5ofOlACYHUDUhfvGGRxemXUJNKjn 3DISY1e2M/z6SO2ekU7+HbDFJsFipsaiS3QVfz0NDfs61zFZlMsvs5MBWsGvXwcikbwZ KJzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WfKgy4ob; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q12si3782244pfk.184.2020.11.09.13.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WfKgy4ob; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8104895B9; Mon, 9 Nov 2020 21:19:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4ECD3895EE for ; Mon, 9 Nov 2020 21:19:39 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id j7so3130538wrp.3 for ; Mon, 09 Nov 2020 13:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ivs8p7JDCUXGc2cgIvVJmvGG5nx3ukesj4jjJvZ5SP0=; b=WfKgy4obnGDp3z2oavqhYPYCnFzdi0qq4fJnhQ/qoTHYWdV0//xXiGiEEle9NiiUdZ 7dFOlv+0axSe3ldGBfDxL6JFPqmKylN+1qiz31crs+9Rpb6qTonbnnaSJGwZgB8hjo9h +zc49rSeTioIFp/20IaE0nrHmEZIYDpK932ajCNpkShNuDH8ULLH6laIlgPbR0ybXA4M FXweYKCt20GRWBnyc3Us0WylLtxa+svuwY24ACCllfgCkR1QvJPG+XRSEFN8fjIBoSWb othWv9Mrh390+GEdfa+GqnLN0EeG0Cuq7ydmY0zStvVzoKjklBlDW756Zg6K/Kig8v/I 4MSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ivs8p7JDCUXGc2cgIvVJmvGG5nx3ukesj4jjJvZ5SP0=; b=C0wCTr2pCMChBhkqJA14JLx2Y6Ai4TUd1jzo3y1c7wtxn+3HBFqFBsXul08LaRlfqT 2/MENW69HrT7Rkn/CxviE4gNe4I0rs7hck01zzg5+tRNYrfIr1UIC4IErlS8HBMM0C2U eUloQxJ2VxsznCIHNiDIK806HDwCneGsNVaQpfB0s+3ySQk2ygMuH6OxquVQHvbHhbb1 dBXSsDHuM8jKdAPRKt77pyuec9V+2X7ebjzJzPKYQSeZjTwfRGPrU7mdnzHy+EjsW3uk j3Ir49+DvKtvDicB09IIvP52GpCMiEXu/OHTfb6JJ5vbNws8ps8j8hezve7RUE3R0kDk NC3Q== X-Gm-Message-State: AOAM533ze9zMv10k87u3XMO/krG4AcStbEUeibDF4nTP+ZPsWKnBPbcu mNziqP1o2LoZFZWqpAQhU9D6DA== X-Received: by 2002:a5d:530c:: with SMTP id e12mr13994595wrv.355.1604956777979; Mon, 09 Nov 2020 13:19:37 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:37 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header Date: Mon, 9 Nov 2020 21:18:50 +0000 Message-Id: <20201109211855.3340030-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600_hdmi.c:177:6: warning: no previous prototype for ‘r600_hdmi_update_acr’ [-Wmissing-prototypes] 177 | void r600_hdmi_update_acr(struct drm_encoder *encoder, long offset, | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/r600_hdmi.c:217:6: warning: no previous prototype for ‘r600_set_avi_packet’ [-Wmissing-prototypes] 217 | void r600_set_avi_packet(struct radeon_device *rdev, u32 offset, | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/r600_hdmi.c:314:6: warning: no previous prototype for ‘r600_hdmi_audio_set_dto’ [-Wmissing-prototypes] 314 | void r600_hdmi_audio_set_dto(struct radeon_device *rdev, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/r600_hdmi.c:340:6: warning: no previous prototype for ‘r600_set_vbi_packet’ [-Wmissing-prototypes] 340 | void r600_set_vbi_packet(struct drm_encoder *encoder, u32 offset) | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/r600_hdmi.c:351:6: warning: no previous prototype for ‘r600_set_audio_packet’ [-Wmissing-prototypes] 351 | void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset) | ^~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/r600_hdmi.c:393:6: warning: no previous prototype for ‘r600_set_mute’ [-Wmissing-prototypes] 393 | void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute) | ^~~~~~~~~~~~~ drivers/gpu/drm/radeon/r600_hdmi.c:469:6: warning: no previous prototype for ‘r600_hdmi_enable’ [-Wmissing-prototypes] 469 | void r600_hdmi_enable(struct drm_encoder *encoder, bool enable) | ^~~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/r600d.h | 14 ++++++++++++++ drivers/gpu/drm/radeon/radeon_audio.c | 11 +---------- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600d.h b/drivers/gpu/drm/radeon/r600d.h index 2e00a5287bd2d..db4bcc8bee4e5 100644 --- a/drivers/gpu/drm/radeon/r600d.h +++ b/drivers/gpu/drm/radeon/r600d.h @@ -27,6 +27,20 @@ #ifndef R600D_H #define R600D_H +struct radeon_crtc; +struct radeon_hdmi_acr; + +void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset); +void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); +void r600_hdmi_audio_set_dto(struct radeon_device *rdev, + struct radeon_crtc *crtc, unsigned int clock); +void r600_set_avi_packet(struct radeon_device *rdev, u32 offset, + unsigned char *buffer, size_t size); +void r600_hdmi_update_acr(struct drm_encoder *encoder, long offset, + const struct radeon_hdmi_acr *acr); +void r600_set_vbi_packet(struct drm_encoder *encoder, u32 offset); +void r600_hdmi_enable(struct drm_encoder *encoder, bool enable); + #define CP_PACKET2 0x80000000 #define PACKET2_PAD_SHIFT 0 #define PACKET2_PAD_MASK (0x3fffffff << 0) diff --git a/drivers/gpu/drm/radeon/radeon_audio.c b/drivers/gpu/drm/radeon/radeon_audio.c index 8c63ccb8b6235..a2be60aa3cec4 100644 --- a/drivers/gpu/drm/radeon/radeon_audio.c +++ b/drivers/gpu/drm/radeon/radeon_audio.c @@ -27,6 +27,7 @@ #include #include "radeon.h" #include "atom.h" +#include "r600d.h" #include "radeon_audio.h" void r600_audio_enable(struct radeon_device *rdev, struct r600_audio_pin *pin, @@ -63,8 +64,6 @@ void dce6_afmt_write_latency_fields(struct drm_encoder *encoder, struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev); void dce6_afmt_select_pin(struct drm_encoder *encoder); -void r600_hdmi_audio_set_dto(struct radeon_device *rdev, - struct radeon_crtc *crtc, unsigned int clock); void dce3_2_audio_set_dto(struct radeon_device *rdev, struct radeon_crtc *crtc, unsigned int clock); void dce4_hdmi_audio_set_dto(struct radeon_device *rdev, @@ -75,31 +74,23 @@ void dce6_hdmi_audio_set_dto(struct radeon_device *rdev, struct radeon_crtc *crtc, unsigned int clock); void dce6_dp_audio_set_dto(struct radeon_device *rdev, struct radeon_crtc *crtc, unsigned int clock); -void r600_set_avi_packet(struct radeon_device *rdev, u32 offset, - unsigned char *buffer, size_t size); void evergreen_set_avi_packet(struct radeon_device *rdev, u32 offset, unsigned char *buffer, size_t size); -void r600_hdmi_update_acr(struct drm_encoder *encoder, long offset, - const struct radeon_hdmi_acr *acr); void dce3_2_hdmi_update_acr(struct drm_encoder *encoder, long offset, const struct radeon_hdmi_acr *acr); void evergreen_hdmi_update_acr(struct drm_encoder *encoder, long offset, const struct radeon_hdmi_acr *acr); -void r600_set_vbi_packet(struct drm_encoder *encoder, u32 offset); void dce4_set_vbi_packet(struct drm_encoder *encoder, u32 offset); void dce4_hdmi_set_color_depth(struct drm_encoder *encoder, u32 offset, int bpc); -void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset); void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset); void dce4_set_audio_packet(struct drm_encoder *encoder, u32 offset); -void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); void dce4_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode); static void radeon_audio_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode); -void r600_hdmi_enable(struct drm_encoder *encoder, bool enable); void evergreen_hdmi_enable(struct drm_encoder *encoder, bool enable); void evergreen_dp_enable(struct drm_encoder *encoder, bool enable); From patchwork Mon Nov 9 21:18:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320991 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000558ejb; Mon, 9 Nov 2020 13:19:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCYgGk3r4qP9gAhsAv/HqzGqxtj+/XnuUuE0kJ6ItARycQsDZ4y05OR1QAINpBGK6XsRCM X-Received: by 2002:aa7:9207:0:b029:18a:ab6f:3a7a with SMTP id 7-20020aa792070000b029018aab6f3a7amr14796567pfo.72.1604956784814; Mon, 09 Nov 2020 13:19:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956784; cv=none; d=google.com; s=arc-20160816; b=pLzuBT9v9LnxRapZjDzeT2s5btk13V7i3N9Zp+0AJ9iwya11ITEttrrq5ptLWpYV5g VLUkoRAEZqmfoPVE7jv7t1uQNoPiU5KOkiZRBisW52evHRxGbNDcKj3CJwkqmEOLldNY IqOPn1PzONw4a6TANoYRC14B0uRkWWc4ZKsmfxFStM4D2tL2FtJ/15FagshawMjMkOyK G2TDSwKFmE2QdkIZN2Heu4BHZN+QuLbeCyhTkN6nUTjwngCr3gOZqf3aHW3aivs1BiA+ emyQ8WKJ2StLFNexGYvVEOCBFgZs6a1c+7JamWp8V8X16yUEZLi/YOYL3zkh/0r0BAgJ YV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=pOtIBxEiLux1x8GJYEyt8ptwRug8r+4hP8KEISFZYtg=; b=NPZB9f78Ks7cqsogmz+BJvWSdaCGElQKntemQoWcCOwxMQt0HceX2/E6Uoj7mKAxl2 41++EgCgMKlarTXLuOY0/jSWSWNte8uDU1iPiU2JkJsXoxxQe2mYlhIrw6Ite97mfXuj 35BhsyQOgpzHz9okKCEe/ZmsFIHeYARP0GjyJeBWBs7EuTxaF0nTqAc8l+WrjjKyzorJ rTKAHPOVZk1g/Oo45orlGNnzim/gsSlBgShBViGACeqds8dqBFc3IUj4R9K2FyuKrZ8X LIEiE0y6/gIsYWjDeONMOqFZKADGrBmgzKStYAcZe7ftazStArfzDF3kFUh0Joezu7/a fcSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=c2pKONE2; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id k15si3892492pgn.200.2020.11.09.13.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=c2pKONE2; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7089895F5; Mon, 9 Nov 2020 21:19:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6A9F895E7 for ; Mon, 9 Nov 2020 21:19:40 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a65so923365wme.1 for ; Mon, 09 Nov 2020 13:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qyLIuv0VkA4024J/8Pdl2sIFaA9qPd+RCQW07HGbGvk=; b=c2pKONE2QnVXBi9ZaRYMHRGMIwmOfN6gN4ypT2YPgAaJYwTh7G5su4q8Io1kOPfJtb RZWvEr1JLtcG//QIdrYa4j6bfhlWi9L+6lJFcCVXd9fND4nUW6KjCiIu2fJu5HIvZgCs B2SRFUcVNHE7ostquCla/96Yh2qu/zSeIoIIWLSBUe2apPv0gLfGgLCqPqqWP6w6IbZd 2yaRUpnkJjx/AlrfRUHzaeiY5p+muLq/bnkMb/W7oSvuX6n9WUsN6g9gygcq2EWiTG3D IyrWrsyjoAtF4GEe+mO3dfM1ZOLqgo4NG9Ah8Jn8R2zxLN+baf/gLxh5JwyU9D9ekria zNEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qyLIuv0VkA4024J/8Pdl2sIFaA9qPd+RCQW07HGbGvk=; b=KNsdMRdrL17tqE7UrVJiguPgRz3pI2twwW1WVp+jZoRHJiHA0fXAjqpaP66Q/meE1U 7CbMrBal2SRx1+3iOCBNqE2Ybx/cyPGBOeVRkdGyV2u2DThto/0XbwxH2z8jvDygocJp YUTbuwysaLv6GBSruJivGzzMr0CZqfLWsdNNiApXpAjTpCDLxDyWewMUQGlcLRGMo3lC bvRhjkGNuL3ysMnEM5M0dsipyy1JsehQ7y0j/ADsjb/2m59DyoJPNP6nzq8+Tq1Luq9E 3Ek1Kdy5fXXP8HAu0S3PzbwvQdVskeUt1a7KShnZRXLiJwi/U6KE1b1ttv+P4abfqm8/ ObQQ== X-Gm-Message-State: AOAM531huwtthG3DP0POpACbGHBFTchRo3b+hKos8o8glHyrH7/MVKTi ttwsQO/lya8/f3B+pCPefvx895IaPtvGIege X-Received: by 2002:a7b:c954:: with SMTP id i20mr1228799wml.56.1604956779427; Mon, 09 Nov 2020 13:19:39 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/20] drm/radeon/radeon_audio: Move 'dce3_2_*' prototypes to shared location Date: Mon, 9 Nov 2020 21:18:51 +0000 Message-Id: <20201109211855.3340030-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Slava Grigorev , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/dce3_1_afmt.c:30:6: warning: no previous prototype for ‘dce3_2_afmt_hdmi_write_speaker_allocation’ [-Wmissing-prototypes] 30 | void dce3_2_afmt_hdmi_write_speaker_allocation(struct drm_encoder *encoder, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/dce3_1_afmt.c:48:6: warning: no previous prototype for ‘dce3_2_afmt_dp_write_speaker_allocation’ [-Wmissing-prototypes] 48 | void dce3_2_afmt_dp_write_speaker_allocation(struct drm_encoder *encoder, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/dce3_1_afmt.c:66:6: warning: no previous prototype for ‘dce3_2_afmt_write_sad_regs’ [-Wmissing-prototypes] 66 | void dce3_2_afmt_write_sad_regs(struct drm_encoder *encoder, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/dce3_1_afmt.c:116:6: warning: no previous prototype for ‘dce3_2_audio_set_dto’ [-Wmissing-prototypes] 116 | void dce3_2_audio_set_dto(struct radeon_device *rdev, | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/dce3_1_afmt.c:170:6: warning: no previous prototype for ‘dce3_2_hdmi_update_acr’ [-Wmissing-prototypes] 170 | void dce3_2_hdmi_update_acr(struct drm_encoder *encoder, long offset, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/dce3_1_afmt.c:202:6: warning: no previous prototype for ‘dce3_2_set_audio_packet’ [-Wmissing-prototypes] 202 | void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/dce3_1_afmt.c:223:6: warning: no previous prototype for ‘dce3_2_set_mute’ [-Wmissing-prototypes] 223 | void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute) | ^~~~~~~~~~~~~~~ Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Slava Grigorev Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_audio.c | 12 ------------ drivers/gpu/drm/radeon/radeon_audio.h | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_audio.c b/drivers/gpu/drm/radeon/radeon_audio.c index a2be60aa3cec4..18228b366752e 100644 --- a/drivers/gpu/drm/radeon/radeon_audio.c +++ b/drivers/gpu/drm/radeon/radeon_audio.c @@ -39,16 +39,10 @@ void dce6_audio_enable(struct radeon_device *rdev, struct r600_audio_pin *pin, u32 dce6_endpoint_rreg(struct radeon_device *rdev, u32 offset, u32 reg); void dce6_endpoint_wreg(struct radeon_device *rdev, u32 offset, u32 reg, u32 v); -void dce3_2_afmt_write_sad_regs(struct drm_encoder *encoder, - struct cea_sad *sads, int sad_count); void evergreen_hdmi_write_sad_regs(struct drm_encoder *encoder, struct cea_sad *sads, int sad_count); void dce6_afmt_write_sad_regs(struct drm_encoder *encoder, struct cea_sad *sads, int sad_count); -void dce3_2_afmt_hdmi_write_speaker_allocation(struct drm_encoder *encoder, - u8 *sadb, int sad_count); -void dce3_2_afmt_dp_write_speaker_allocation(struct drm_encoder *encoder, - u8 *sadb, int sad_count); void dce4_afmt_hdmi_write_speaker_allocation(struct drm_encoder *encoder, u8 *sadb, int sad_count); void dce4_afmt_dp_write_speaker_allocation(struct drm_encoder *encoder, @@ -64,8 +58,6 @@ void dce6_afmt_write_latency_fields(struct drm_encoder *encoder, struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev); void dce6_afmt_select_pin(struct drm_encoder *encoder); -void dce3_2_audio_set_dto(struct radeon_device *rdev, - struct radeon_crtc *crtc, unsigned int clock); void dce4_hdmi_audio_set_dto(struct radeon_device *rdev, struct radeon_crtc *crtc, unsigned int clock); void dce4_dp_audio_set_dto(struct radeon_device *rdev, @@ -76,16 +68,12 @@ void dce6_dp_audio_set_dto(struct radeon_device *rdev, struct radeon_crtc *crtc, unsigned int clock); void evergreen_set_avi_packet(struct radeon_device *rdev, u32 offset, unsigned char *buffer, size_t size); -void dce3_2_hdmi_update_acr(struct drm_encoder *encoder, long offset, - const struct radeon_hdmi_acr *acr); void evergreen_hdmi_update_acr(struct drm_encoder *encoder, long offset, const struct radeon_hdmi_acr *acr); void dce4_set_vbi_packet(struct drm_encoder *encoder, u32 offset); void dce4_hdmi_set_color_depth(struct drm_encoder *encoder, u32 offset, int bpc); -void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset); void dce4_set_audio_packet(struct drm_encoder *encoder, u32 offset); -void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); void dce4_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode); diff --git a/drivers/gpu/drm/radeon/radeon_audio.h b/drivers/gpu/drm/radeon/radeon_audio.h index 5c70cceaa4a6c..05e67867469b0 100644 --- a/drivers/gpu/drm/radeon/radeon_audio.h +++ b/drivers/gpu/drm/radeon/radeon_audio.h @@ -81,4 +81,16 @@ void radeon_audio_mode_set(struct drm_encoder *encoder, void radeon_audio_dpms(struct drm_encoder *encoder, int mode); unsigned int radeon_audio_decode_dfs_div(unsigned int div); +void dce3_2_afmt_write_sad_regs(struct drm_encoder *encoder, + struct cea_sad *sads, int sad_count); +void dce3_2_afmt_hdmi_write_speaker_allocation(struct drm_encoder *encoder, + u8 *sadb, int sad_count); +void dce3_2_afmt_dp_write_speaker_allocation(struct drm_encoder *encoder, + u8 *sadb, int sad_count); +void dce3_2_audio_set_dto(struct radeon_device *rdev, + struct radeon_crtc *crtc, unsigned int clock); +void dce3_2_hdmi_update_acr(struct drm_encoder *encoder, long offset, + const struct radeon_hdmi_acr *acr); +void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset); +void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); #endif From patchwork Mon Nov 9 21:18:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320992 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000573ejb; Mon, 9 Nov 2020 13:19:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxeh8/tPt8Ir9D+Mil1vof5uXJQBldEQU6QODqnIwQZM2yhvc1dbGPRy+plSbdjDruK5dj X-Received: by 2002:a17:90b:297:: with SMTP id az23mr1207811pjb.71.1604956786950; Mon, 09 Nov 2020 13:19:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956786; cv=none; d=google.com; s=arc-20160816; b=Fz9y6QTmp+QqtkHyYaQ1z/2Jt/g0kvjS5LdG37xK69pUn8FIU0NAhqGI4MbZfopNNw FWApNjZfOSDS3+jgVIwU0zVZoCxn+tuHJ7PmVcJtrcrrDWHWyKLm40E1RUKRxEVW3MhS jDoVM9mK0kZ9IDYOJ0HoW7S6CDqnczcEQpZWdLoKfrNiCuWAHqdCKNhx5fFFZHK+dfZV vj9UkchrI3JLD+QX+WsVJ8dAiXs6zMYwRSVDH6UUMnRjpI8wHRoNqP3kRF4kxd6qa9bs VE7HIaQ1bIhTM1tjtQLpEc4xfmBpA9xkIayUWhQqL5M9XMRKB3/fnIiF7UwsRuP6qmB4 hLcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Ehh86htoiN/rfaoDaK9mLqYGyiMtYzxRCUksCoO5P6Q=; b=uzwhyNHIf7o+fKs2zfU75nzJ1LcCoO2l+Qq5k9uPkrBaJL60Ys4MYu7wqozoBAN3CR fCBh4s/y/oJzYXhDI3xUh00XmQbZM9+3/DP0R9DhDQ0lzEN1+58fUd8yQD8dW+BHcETa Td9ko0IuwYtPE+caKm3b/4kLOsM0J4p5mWgX5zmvxnrQZzcF7kO+ju8buSxruGGPADrv adqnEqcQXv8Y84AYBIYM3SjOdKsYjYMO3pDT5ign32jAvgngUO+Ek1eJMvT6rzl/XdYh cf2p/xkrin1TJNoQK8XNW2JbZisBqiM0m6hudsy7YeDAuLBONygmbVGECKdnuYWqnVU2 6prQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="ia6Ly/ND"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id l11si10169760pgf.540.2020.11.09.13.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="ia6Ly/ND"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B060E8961E; Mon, 9 Nov 2020 21:19:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01097895F5 for ; Mon, 9 Nov 2020 21:19:42 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id w1so10399238wrm.4 for ; Mon, 09 Nov 2020 13:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KyuOZ6WFceJf3q5HhUHXf3izEYZKAnZdbW02BpgTuA4=; b=ia6Ly/NDi9+1f1MROT2EMD4YRQgmF6pBC/ImFkzNoFNFyXq1oRlxFh2uqMhXnE6lbQ 9XLcWdf7NjOGxRxtuv2UN22kTINyIyTfXWFGkK5Sm5i1RBc4bzAIHMXCd0J4sTI7vWJ+ ASGDsFl+nL2+zeJ8sPajMBI5ZgSuPpkBRgxhTJLf6f3M+0GfIyYKGUlgBFv7H3Ys8lqi NuQO4QbSbYtEIowXUA/uPVYkSvdwGoFjjw3IrR2Z57nIhvQjI6y41eAqmfnFG+dXAK4u 6zbri2xyInD457VBa3Kh8Izq/xDjxGZQw+Nb1wcYAJx7wPaRoICKqqQVzzRaI6qWz5q0 /qJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KyuOZ6WFceJf3q5HhUHXf3izEYZKAnZdbW02BpgTuA4=; b=XDVQa8EsYTlOubSdVUHiV8tppFkbrotFCOR+2HocWQES+6TYbPG2R3AGKo5MeIrtsy CqcxmrDG8h/cdto6VDZjI+BRDGn//y5mtWtSiNFVad0dAVQ6ewJif6vUINV79iAHHXUA Zx5bnefmOCj+M5fYVxFJUNFRvb6WjcOP05L2Je9I9QsVIn9f9UCcLeDQc5hBvMqOANHW OC3OqKfP6GzEoR+zToO8a5bcmtXXwGHX6hWj9kjUgxyjoRaOMArq2hu7FCESnN+N+XKu ofQdBwfHoJawLQGfePIevlXgUV//+0vtVaRsWKbWgteRZPwXHpOf0YspabsVVr72COBN 5T+w== X-Gm-Message-State: AOAM530GwZrgAGjxkGsSDZpvh4/zfyynT8pCJ70Ktlc2xBUba0cE/TiE CKOuQ2smc2VnWaKEKucXhw9tRA== X-Received: by 2002:adf:b78b:: with SMTP id s11mr12746859wre.42.1604956781612; Mon, 09 Nov 2020 13:19:41 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/20] drm/radeon/evergreend: Move 'evergreen_*' and 'sumo_*' prototypes out to shared location Date: Mon, 9 Nov 2020 21:18:52 +0000 Message-Id: <20201109211855.3340030-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen.c:1281:6: warning: no previous prototype for ‘evergreen_fix_pci_max_read_req_size’ [-Wmissing-prototypes] 1281 | void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:2664:6: warning: no previous prototype for ‘evergreen_mc_stop’ [-Wmissing-prototypes] 2664 | void evergreen_mc_stop(struct radeon_device *rdev, struct evergreen_mc_save *save) | ^~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:2762:6: warning: no previous prototype for ‘evergreen_mc_resume’ [-Wmissing-prototypes] 2762 | void evergreen_mc_resume(struct radeon_device *rdev, struct evergreen_mc_save *save) | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:2850:6: warning: no previous prototype for ‘evergreen_mc_program’ [-Wmissing-prototypes] 2850 | void evergreen_mc_program(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:3710:5: warning: no previous prototype for ‘evergreen_mc_init’ [-Wmissing-prototypes] 3710 | int evergreen_mc_init(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:3769:6: warning: no previous prototype for ‘evergreen_print_gpu_status_regs’ [-Wmissing-prototypes] 3769 | void evergreen_print_gpu_status_regs(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:3797:6: warning: no previous prototype for ‘evergreen_is_display_hung’ [-Wmissing-prototypes] 3797 | bool evergreen_is_display_hung(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:4009:6: warning: no previous prototype for ‘evergreen_gpu_pci_config_reset’ [-Wmissing-prototypes] 4009 | void evergreen_gpu_pci_config_reset(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:4110:6: warning: no previous prototype for ‘sumo_rlc_fini’ [-Wmissing-prototypes] 4110 | void sumo_rlc_fini(struct radeon_device *rdev) | ^~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:4153:5: warning: no previous prototype for ‘sumo_rlc_init’ [-Wmissing-prototypes] 4153 | int sumo_rlc_init(struct radeon_device *rdev) | ^~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:4381:5: warning: no previous prototype for ‘evergreen_rlc_resume’ [-Wmissing-prototypes] 4381 | int evergreen_rlc_resume(struct radeon_device *rdev) | ^~~~~~~~~~~~~ drivers/gpu/drm/radeon/evergreen.c:4670:6: warning: no previous prototype for ‘evergreen_irq_suspend’ [-Wmissing-prototypes] 4670 | void evergreen_irq_suspend(struct radeon_device *rdev) | ^~~~~~~~~~~~~~~~~~~~~ NB: Lots more of these - snipped for brevity Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/ni.c | 16 ---------------- drivers/gpu/drm/radeon/radeon.h | 23 +++++++++++++++++++++++ drivers/gpu/drm/radeon/si.c | 6 ------ 3 files changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c index 02feb0801fd30..91bba473f2703 100644 --- a/drivers/gpu/drm/radeon/ni.c +++ b/drivers/gpu/drm/radeon/ni.c @@ -38,7 +38,6 @@ #include "radeon_asic.h" #include "radeon_audio.h" #include "radeon_ucode.h" - /* * Indirect registers accessor */ @@ -190,21 +189,6 @@ static const u32 tn_rlc_save_restore_register_list[] = 0x802c, }; -extern bool evergreen_is_display_hung(struct radeon_device *rdev); -extern void evergreen_print_gpu_status_regs(struct radeon_device *rdev); -extern void evergreen_mc_stop(struct radeon_device *rdev, struct evergreen_mc_save *save); -extern void evergreen_mc_resume(struct radeon_device *rdev, struct evergreen_mc_save *save); -extern int evergreen_mc_wait_for_idle(struct radeon_device *rdev); -extern void evergreen_mc_program(struct radeon_device *rdev); -extern void evergreen_irq_suspend(struct radeon_device *rdev); -extern int evergreen_mc_init(struct radeon_device *rdev); -extern void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev); -extern void evergreen_pcie_gen2_enable(struct radeon_device *rdev); -extern void evergreen_program_aspm(struct radeon_device *rdev); -extern void sumo_rlc_fini(struct radeon_device *rdev); -extern int sumo_rlc_init(struct radeon_device *rdev); -extern void evergreen_gpu_pci_config_reset(struct radeon_device *rdev); - /* Firmware Names */ MODULE_FIRMWARE("radeon/BARTS_pfp.bin"); MODULE_FIRMWARE("radeon/BARTS_me.bin"); diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 1cbbaff7cede2..3e53a9493ae92 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -2951,6 +2951,29 @@ extern u32 r6xx_remap_render_backend(struct radeon_device *rdev, extern int ni_init_microcode(struct radeon_device *rdev); extern int ni_mc_load_microcode(struct radeon_device *rdev); +/* + * evergreen functions used by ni.c and si.c + */ + +struct evergreen_mc_save; + +bool evergreen_is_display_hung(struct radeon_device *rdev); +void evergreen_print_gpu_status_regs(struct radeon_device *rdev); +void evergreen_mc_stop(struct radeon_device *rdev, struct evergreen_mc_save *save); +void evergreen_mc_resume(struct radeon_device *rdev, struct evergreen_mc_save *save); +int evergreen_mc_wait_for_idle(struct radeon_device *rdev); +void evergreen_mc_program(struct radeon_device *rdev); +void evergreen_irq_suspend(struct radeon_device *rdev); +int evergreen_mc_init(struct radeon_device *rdev); +void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev); +void evergreen_pcie_gen2_enable(struct radeon_device *rdev); +void evergreen_program_aspm(struct radeon_device *rdev); +void sumo_rlc_fini(struct radeon_device *rdev); +int sumo_rlc_init(struct radeon_device *rdev); +void evergreen_gpu_pci_config_reset(struct radeon_device *rdev); +u32 evergreen_get_number_of_dram_channels(struct radeon_device *rdev); +void evergreen_print_gpu_status_regs(struct radeon_device *rdev); + /* radeon_acpi.c */ #if defined(CONFIG_ACPI) extern int radeon_acpi_init(struct radeon_device *rdev); diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index 93dcab548a835..8b80884990aee 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c @@ -129,12 +129,6 @@ extern void sumo_rlc_fini(struct radeon_device *rdev); extern int sumo_rlc_init(struct radeon_device *rdev); extern int r600_ih_ring_alloc(struct radeon_device *rdev); extern void r600_ih_ring_fini(struct radeon_device *rdev); -extern void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev); -extern void evergreen_mc_stop(struct radeon_device *rdev, struct evergreen_mc_save *save); -extern void evergreen_mc_resume(struct radeon_device *rdev, struct evergreen_mc_save *save); -extern u32 evergreen_get_number_of_dram_channels(struct radeon_device *rdev); -extern void evergreen_print_gpu_status_regs(struct radeon_device *rdev); -extern bool evergreen_is_display_hung(struct radeon_device *rdev); static void si_enable_gui_idle_interrupt(struct radeon_device *rdev, bool enable); static void si_init_pg(struct radeon_device *rdev); From patchwork Mon Nov 9 21:18:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320993 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000600ejb; Mon, 9 Nov 2020 13:19:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzX36aqYaXOz5KIku8aFdbzVQlIv5aQH2SYqAAelH0pGNUJo/xciqa9wF1FYhzKVhQGokkT X-Received: by 2002:a17:90a:4b45:: with SMTP id o5mr1068079pjl.223.1604956789605; Mon, 09 Nov 2020 13:19:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956789; cv=none; d=google.com; s=arc-20160816; b=bZ2EVEekiIXuu/aYhoy80ne73HEJar6uanB6MSS0DkbTXYJjwgEkO9biUdid+oY6xF 4KlE+AxtAS563ozs7EDVwBUYphf2m3neBkWJVrS61h5YeBBfPCdGdy2R1jZ21MvFrEto G9EWKSzh47Yw1nc2IS6romPLiXXrTNEpYGCJ+IEY7JPPqR8RYeQYgevBmCX69QFiyS2B OB1SiSqp1i8iGa/1H3EtFuALwPkrE3vXBG1Le0L/B2Gotmfw//LxFl3/Si0FBZxpcUri hXxXTFOOc/a0bfDlRGqGW6ntNM2MXWSljiifVuijGjisPgox07lYK3rmKG49K+FcT1D4 ihOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=29I0xXPMvn3UiGgUxWfPCoYNEuyFptPKbeWA7nfKhP8=; b=fHMPTtt097KBibY6MXUczcWqFwTw4We3CAY2xZ+XvNPf9glqdp/U1wP3XyXP5zy1wF 7m2oKZJak8GatrAbJZaA6OSya55h2zRMm0AbEpoZXwACPDHf31J0+EXPVTrWcabW4m1P QWRPyT9RQOvqAV1fzl2DFQuK6Uatuj5BQlOelIKyxEa2uyVBTd3FS+5FoLYa02DYv6xT zRftUtdcnyEWl0nn1smzm4vaL7k8h6YGEWlmUbxwZwumm0yTMXVrOUElcpGbf2fWepcw J0ongxOzmvCC9WgW4C5Xgi2HHWJZax0+P6wF6Akx5rhK24N8ujrqBaBuHD8PWXcF6KJ1 OgiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yLNFiHYO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id l13si10777845pgq.112.2020.11.09.13.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yLNFiHYO; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FFF989617; Mon, 9 Nov 2020 21:19:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id C019389650 for ; Mon, 9 Nov 2020 21:19:45 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h62so912418wme.3 for ; Mon, 09 Nov 2020 13:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GKEWaGJB8BfGR6ufuyFa6sc9ZYlzJUyj0WhtwnEg+YM=; b=yLNFiHYOOshoi44YOcHvCJLLEepPoEefGQL1ft/wS6fsl9FUBhQHLyJ4M4k86v5zCs 5J5RdBCbgV+7LI5avSvNm9OU0JAbs9DADt00zEd2Ba9Mz4hOjuJn9JFWKURi/7bvIdt1 xb7UopKkEa8/tRNspkGKQ2Is28Vu5W9N0IieG7NbyaI9fH8PExpFz/fdSK6TKix+0Iwb ygndmQg6/vzQvngoclWGooLS0vCOPnLUQucMoGcBAlNeUndHdyfFCWizDCiYwZPTvMDI ljKm8/NevMLVASgfqYYYm+5j3vYRMHMEMecOkwxAWvBCEZ2lR1U8SOBYI06Q/nz3j6NV BOBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GKEWaGJB8BfGR6ufuyFa6sc9ZYlzJUyj0WhtwnEg+YM=; b=hooy5BfcorKjSTFupn7xpWs6X+IdN2jI+Q0QMPFhWp0zJFL+fIGnKXqEi2bKu5NP9K Depbjl8oJ5ZH23GiEpZEX9W+KbSK2EtGRk+2CL6kbvexGT2nLjdYCcVTWSTdz1PrkIjU DiTniDNkEu1w4HatWBuxDVJUKPQvfrn5B+e97DxG0H+ni3jVDVhU+2yFPrFvhoCZpC07 pDSX7cz3JsRXRwQ+4/sPxQJlZ1W7yTP1F/W6366V0ysjRUoFNaqGMZQlZ82ZiDeV3rFP pMThKiECO43CvXrOl9ynUTROY9glsr2iAnA7hvwC+PIqxRAOJn58wq0Cm779j1PuY55q 2/gQ== X-Gm-Message-State: AOAM5329LphefTyUM9pdtATV0D7/2gDMf/Nof4A1tdN0k4TNneueElpN L0hImKl+xE08H89nOxbiB1ikjA== X-Received: by 2002:a1c:2ece:: with SMTP id u197mr1180731wmu.58.1604956784455; Mon, 09 Nov 2020 13:19:44 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues Date: Mon, 9 Nov 2020 21:18:53 +0000 Message-Id: <20201109211855.3340030-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , report to , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_display.c:264: warning: Function parameter or member '__work' not described in 'radeon_unpin_work_func' drivers/gpu/drm/radeon/radeon_display.c:406: warning: Function parameter or member '__work' not described in 'radeon_flip_work_func' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'freq' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'fb_div_p' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'frac_fb_div_p' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'ref_div_p' not described in 'radeon_compute_pll_avivo' drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'post_div_p' not described in 'radeon_compute_pll_avivo' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: report to Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_display.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 78fceedfd9255..eb0d4cb95f0a6 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -256,7 +256,7 @@ static void radeon_crtc_destroy(struct drm_crtc *crtc) /** * radeon_unpin_work_func - unpin old buffer object * - * @__work - kernel work item + * @__work: kernel work item * * Unpin the old frame buffer object outside of the interrupt handler */ @@ -398,7 +398,7 @@ void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id) /** * radeon_flip_work_func - page flip framebuffer * - * @work - kernel work item + * @__work: kernel work item * * Wait for the buffer object to become idle and do the actual page flip */ @@ -937,11 +937,12 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div, * radeon_compute_pll_avivo - compute PLL paramaters * * @pll: information about the PLL + * @freq: target frequency * @dot_clock_p: resulting pixel clock - * fb_div_p: resulting feedback divider - * frac_fb_div_p: fractional part of the feedback divider - * ref_div_p: resulting reference divider - * post_div_p: resulting reference divider + * @fb_div_p: resulting feedback divider + * @frac_fb_div_p: fractional part of the feedback divider + * @ref_div_p: resulting reference divider + * @post_div_p: resulting reference divider * * Try to calculate the PLL parameters to generate the given frequency: * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div) From patchwork Mon Nov 9 21:18:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320994 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000612ejb; Mon, 9 Nov 2020 13:19:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnuGqThVxzJB4csT2q5gLIUO8yknzRV7M2dUnD66HLaNiQgyiPqkALLXJUelst7pKuB90o X-Received: by 2002:a17:902:b695:b029:d7:d966:1a3b with SMTP id c21-20020a170902b695b02900d7d9661a3bmr8214373pls.5.1604956791028; Mon, 09 Nov 2020 13:19:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956791; cv=none; d=google.com; s=arc-20160816; b=rtRUzlHa1s0ReZM13PPBMuMGQoe/N9CGngnBb/NykuENdk11YqgHqak+9Tjpe8LaSD J7rQIMSbUBmlrVlcSDRnXEcVPr/5qhmpnglpz2JLN9o8JCAQgu8mSEA56o2mdrF2X49q /MwY2Qjcy9jl5rOhcRxm16gP5LoEcxi6U5ihfHJ2iDIVaKLvE/ZO9CiDbKFUe44optqj D5hGfhiKHRQTtqrQWJoY8QRVGUn6Z/nUvv3VNvxiCzQ0AvvgVRgmX145GUWx3ZM+duW8 t+KC2XgxEuvnwdKTHYFwjVqNWQxvGHz6vNtzCgdNNb2duQ4pwIa19fo9+cpbgWKlBdqv 26fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=7TN4hjJvfCitEvap5SoqnFYfBfEnrl355HNx85fUexg=; b=BCyEYcdieizy4ZCcUP8BE2S32V2Z3AhDUvpj/rMeLHOMsAiD/YQbEKVu0oJHgTQOZP ROqFoVO+Vd1q0eCZS4OaqieYI3MVnwcqg9s11ae+S06rv+HMu0bhajiJwY4dLOknh/Qe sObPva+6+7fhlyrJ7rFiUI7TnK5n9cgd9zsm7GIVgYDohQKtguWlkxiiaJrfP3UFl4K3 PIhTTg83NBPUbPwsY6q1v/AyVVG0Bi2rbv2at/rLqMH2P6yhtGmxflkazXjV1t4F/qTv hRGZZNBk6aPxS3EFFEVADtxHK+z5h1bksvS3G0OFGPeykj/dU/K6wzd/DSS1+vbCj6dZ pN9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=krtpRYJ7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id e6si9706138pfd.161.2020.11.09.13.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=krtpRYJ7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 133F389650; Mon, 9 Nov 2020 21:19:49 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2468A89654 for ; Mon, 9 Nov 2020 21:19:48 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id s13so907359wmh.4 for ; Mon, 09 Nov 2020 13:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2Un/LDNkdtYgdVjwGu3XY0AMRqx0e4C7tEIbE9voLUM=; b=krtpRYJ7mJUGfshUvedarUQRk839XAsX1wT12dXjV+G7bjHLBn+k/FCaHDeBwJ6zmR 3e2WA9H9T5WGYWerXvnIdIlBKuOUi0/peBoe60omFIGgRa00EwPLs3UpTyrq9TGFYRY7 cPCF25r0zM+iPp/uYSwZ/iAS8Oc5OLnKgP9gC7Kqrv0Nuy/dOka94U9QSbg60Dg4UrQk yYsmArQ6NE0XriEBZ5U9RjF3P6yr4ypMPN8vNWQRKc4YEEzLtkrSwLbKERomuMHFbFak iEDHJjsS0XIqmRZ2lUxemTSkEl12uzmk3qkW+gSEX64gIFbXq56QLJTS2aVCjo4dXf8t TngA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2Un/LDNkdtYgdVjwGu3XY0AMRqx0e4C7tEIbE9voLUM=; b=bRauFR2SgY9HDhplx0YeIP+0EbI4REpUr8sSk2rrSuPCTcDDjfQWQezVBdFt3K3lht TaGBaS1Dly3s1sK7+NaKwVRfY9XtgN/mISS6f99pmxZzHdUwHovehZmeapj7C6ualj31 wmffzgHJM1/Fi7/0X2YOEX9JJYyw2aRcRHKK5bZEH6c4WkI+pQtNmPpTVlMR85lURzWB QFnlppTTdHT0trchl/lEvFUeCaRXHFI8swtA5NdZDHVG1MclnBWeXZtrnsPAmqKGPZfg j0CjDpL5w3vCWghsY/eRCofmjyBVN9P8eWc2hJtMVOh0V8RCL1I8YltNhmsSvrAmgEso sHug== X-Gm-Message-State: AOAM531c8JtCGyCt/3P9w9QsOD+gzSE2O6pHSfzANv+gRXbK1ATrpdMf YLZcGioqXHWtROhxWD3SV9r+Ww== X-Received: by 2002:a05:600c:2048:: with SMTP id p8mr1123112wmg.165.1604956786842; Mon, 09 Nov 2020 13:19:46 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 19/20] drm/radeon/r600: Fix a misnamed parameter description and a formatting issue Date: Mon, 9 Nov 2020 21:18:54 +0000 Message-Id: <20201109211855.3340030-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600.c:2965: warning: Function parameter or member 'resv' not described in 'r600_copy_cpdma' drivers/gpu/drm/radeon/r600.c:2965: warning: Excess function parameter 'fence' description in 'r600_copy_cpdma' drivers/gpu/drm/radeon/r600.c:4382: warning: Function parameter or member 'rdev' not described in 'r600_mmio_hdp_flush' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/r600.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index 9587792503525..0a085b85f559d 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -2952,7 +2952,7 @@ bool r600_semaphore_ring_emit(struct radeon_device *rdev, * @src_offset: src GPU address * @dst_offset: dst GPU address * @num_gpu_pages: number of GPU pages to xfer - * @fence: radeon fence object + * @resv: DMA reservation object to manage fences * * Copy GPU paging using the CP DMA engine (r6xx+). * Used by the radeon ttm implementation to move pages if @@ -4371,7 +4371,7 @@ int r600_debugfs_mc_info_init(struct radeon_device *rdev) /** * r600_mmio_hdp_flush - flush Host Data Path cache via MMIO - * rdev: radeon device structure + * @rdev: radeon device structure * * Some R6XX/R7XX don't seem to take into account HDP flushes performed * through the ring buffer. This leads to corruption in rendering, see From patchwork Mon Nov 9 21:18:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320995 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000631ejb; Mon, 9 Nov 2020 13:19:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwlRzkpYXKY6xy+2OE0f9H5kX3IKUox+pWyfTWxz1nxpACYwdch+5okWtQfl830SE1R00wi X-Received: by 2002:a17:90b:11cf:: with SMTP id gv15mr1183451pjb.11.1604956793460; Mon, 09 Nov 2020 13:19:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956793; cv=none; d=google.com; s=arc-20160816; b=qgHNe8T5QnJdG283PJPF6y4g7rFu3D6X+kpR7jYvgaGV80WCmnptpdccrieOcYD16H YYeUzj02yD7d30LU0f5UMsxKlNvSfHEOE+2hNuezLNEyZadxXVtQe14EpPxbd5qmU5oO 3i7OCePB7cEjLDvih9y9JClaWkRlMXHw/0xehsqc+pNAXkkqzihd5IDNV51MpwTtPwmv laD1Mr/zcQDkZMVrrV59C5pI2KssZ8LvPQBXveDKr85geKthUjTnj5h7y3rjZmGduwku LxfnttY/ajhK+c/uGZH9L6/uwQptE+GcCQC/QFJMBUKcIenJPdGzc9PtmgzeoJU1mQJI VlWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=FrhTI0QXu1flHB4bXUeQP3FdSFkuIx5v3h1kDuk7Ssg=; b=VtTfQPFd8e1iM47dRrTuug9WVB90DBaPbTns7guxu5viJy74IXnIBV3V+18eP285Lz TUXAVi3K083T31Eeem/LRDongNbSPne02LkEZuOQdPbsWdtMH8iwQdkVzxjc9vrIKaqn FKYoEZI0fe7nrxdahlAAp6nOP7Ta8AzSOYq0bcRzvcIyklJ2laNrXpBuBdrZKPb3wZq4 7jSqgU6vu7alcZDn1Tl76X1PHMUmcnwqcwfZGKUSwm7dz7Mo8mb71ZHTY4+4KHhGa1JH hXzxkud/7d0JMoORFh/gdHCxAPhZSSbM7S1ahRM0IlGYffy2Dsj5H7QNFr9sGdlTP58E z/nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xffKJqvP; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id mj12si509290pjb.168.2020.11.09.13.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xffKJqvP; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91A438961D; Mon, 9 Nov 2020 21:19:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4EA78961D for ; Mon, 9 Nov 2020 21:19:50 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id d12so8862556wrr.13 for ; Mon, 09 Nov 2020 13:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nw6A8bk/xb3oF0GjjrWfN8mr8P4GAXIbWL67zCF8LOk=; b=xffKJqvPcoVpjX49CD9iPngImypKFrocw+0RBun/VUNAfSfLuUnR0X8h9ZvT33k/sS o7nKicVgJtcPFneOEneZ7flekt6bjeIRwpD8cyyv0PTIrfpPpKSu3AIALYPSs8jGW7Ny YllwT7lzXzObLav713wvGeTJk0uasvrXtGa5RUwqQH2pVsBn45qDDiJ7VQs6Su60k3P/ 3ZqJAoEe0RyHAdp90UhuMRhyC+F8NaTAQFWqB0WJURo28AiPzFAwLUIt8HZVCAe2MOuJ RhEx4AxLBHo4loQ2xytFlPGMkYHgp5grST5XuwpZvs0VD6/GmfjlhFgjs4dPzNBCCwsD JGKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nw6A8bk/xb3oF0GjjrWfN8mr8P4GAXIbWL67zCF8LOk=; b=HHQ3/Yeoi7ffgreWvo748I5FPJqdhoX7NlflNuIRTqishYNnwtdFb/5CMZrP7LGWGi 6hMp8xgKcaYBwvT0c9hXlro6DFIEx7pb5h+u7nTYD7acuFzSr41GYY9AS6gtu/ZZdN/V 04dXHNTCuZzx80JYcbc/i1K4SGbvPewX4ME1fAx7tgaIvXftj6IeRgSA+LnxChoukEm4 6jFMBgThKD/l963HZJ/9QXJ1xF3o0xJoEX30NLhiDgYLRmNVYsNAdfEn1aScDnpWOxrr i05JbmbTrSTbnOzBHPNeP5vHZlh/LRZt33geHSLf4cO+04+J08LPL76NnBSbtoAHfH4o ASgg== X-Gm-Message-State: AOAM533B2w0Fo9Xb8R9sDQ38tGNZjAxkInsag66dlvezKjWRk4gLQiqd Ni3Ob+embnvjg1LUlbJJ1zm7GA== X-Received: by 2002:adf:8b84:: with SMTP id o4mr20360420wra.269.1604956789425; Mon, 09 Nov 2020 13:19:49 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 20/20] drm/radeon/cik: Fix a bunch of function parameter descriptions Date: Mon, 9 Nov 2020 21:18:55 +0000 Message-Id: <20201109211855.3340030-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/cik.c:1869:5: warning: no previous prototype for ‘ci_mc_load_microcode’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c: In function ‘cik_gpu_init’: drivers/gpu/drm/radeon/cik.c:3181:6: warning: variable ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/radeon/cik.c: At top level: drivers/gpu/drm/radeon/cik.c:4852:5: warning: no previous prototype for ‘cik_gpu_check_soft_reset’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:5850:6: warning: no previous prototype for ‘cik_enter_rlc_safe_mode’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:5871:6: warning: no previous prototype for ‘cik_exit_rlc_safe_mode’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:6289:6: warning: no previous prototype for ‘cik_update_cg’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:6421:6: warning: no previous prototype for ‘cik_init_cp_pg_table’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:6678:5: warning: no previous prototype for ‘cik_get_csb_size’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:6710:6: warning: no previous prototype for ‘cik_get_csb_buffer’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/cik.c:3084: warning: Function parameter or member 'max_rb_num_per_se' not described in 'cik_get_rb_disabled' drivers/gpu/drm/radeon/cik.c:3084: warning: Excess function parameter 'max_rb_num' description in 'cik_get_rb_disabled' drivers/gpu/drm/radeon/cik.c:3084: warning: Excess function parameter 'se_num' description in 'cik_get_rb_disabled' drivers/gpu/drm/radeon/cik.c:3114: warning: Function parameter or member 'max_rb_num_per_se' not described in 'cik_setup_rb' drivers/gpu/drm/radeon/cik.c:3114: warning: Excess function parameter 'max_rb_num' description in 'cik_setup_rb' drivers/gpu/drm/radeon/cik.c:5662: warning: Function parameter or member 'mc_client' not described in 'cik_vm_decode_fault' drivers/gpu/drm/radeon/cik.c:5690: warning: Function parameter or member 'ring' not described in 'cik_vm_flush' drivers/gpu/drm/radeon/cik.c:5690: warning: Function parameter or member 'vm_id' not described in 'cik_vm_flush' drivers/gpu/drm/radeon/cik.c:5690: warning: Function parameter or member 'pd_addr' not described in 'cik_vm_flush' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/cik.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 5c42877fd6fbf..4494f9122fd91 100644 --- a/drivers/gpu/drm/radeon/cik.c +++ b/drivers/gpu/drm/radeon/cik.c @@ -3071,8 +3071,7 @@ static u32 cik_create_bitmask(u32 bit_width) * cik_get_rb_disabled - computes the mask of disabled RBs * * @rdev: radeon_device pointer - * @max_rb_num: max RBs (render backends) for the asic - * @se_num: number of SEs (shader engines) for the asic + * @max_rb_num_per_se: max RBs (render backends) for the asic * @sh_per_se: number of SH blocks per SE for the asic * * Calculates the bitmask of disabled RBs (CIK). @@ -3104,7 +3103,7 @@ static u32 cik_get_rb_disabled(struct radeon_device *rdev, * @rdev: radeon_device pointer * @se_num: number of SEs (shader engines) for the asic * @sh_per_se: number of SH blocks per SE for the asic - * @max_rb_num: max RBs (render backends) for the asic + * @max_rb_num_per_se: max RBs (render backends) for the asic * * Configures per-SE/SH RB registers (CIK). */ @@ -5654,6 +5653,7 @@ void cik_vm_fini(struct radeon_device *rdev) * @rdev: radeon_device pointer * @status: VM_CONTEXT1_PROTECTION_FAULT_STATUS register value * @addr: VM_CONTEXT1_PROTECTION_FAULT_ADDR register value + * @mc_client: VM_CONTEXT1_PROTECTION_FAULT_MCCLIENT register value * * Print human readable fault information (CIK). */ @@ -5677,11 +5677,9 @@ static void cik_vm_decode_fault(struct radeon_device *rdev, block, mc_client, mc_id); } -/** +/* * cik_vm_flush - cik vm flush using the CP * - * @rdev: radeon_device pointer - * * Update the page table base and flush the VM TLB * using the CP (CIK). */