From patchwork Tue Nov 10 14:27:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 322166 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp270798ils; Tue, 10 Nov 2020 06:27:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyedzRxhqRNJudRzTsbwi/EMk38+kVFkE72iPE7Gft21oL4fxdDIFN/qB5Dr/bF2iNlXAJ X-Received: by 2002:a17:906:831a:: with SMTP id j26mr20769558ejx.450.1605018450670; Tue, 10 Nov 2020 06:27:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605018450; cv=none; d=google.com; s=arc-20160816; b=Is8uCYJY0dGqbop6yoMUqFs6jJzZBriZI+B5YO+i5NMA5UATuMo4YRvpfJ1fjSbtRt F8EXnoVPAR3UbZWMWAMzaPLjjcO8wj9X/kNdeMuJ9OYowGwWa3MyPUcNwGSM+e5QICWJ jYcH+w+MlZeVCVM6Jv5gmBfVl3JX0PtMO3uCsEKI3bX6VoLIVGg5vFBdDQnQMlUsXdGd Ufilh+y1Hd03lJavzDoLBnMNkAEKdUqU7KiV7neysKD0MfpSvpgOMXDveETDNKcZNJ/c 9ca2OuSREkPG5psUkIMyGpWRfKeRJ3gJv88YzOUvxYchglIV62V49jdVoNKXEZKimmmO A3hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=n8uglzR99agOJ88UjmIg/xjEt6zI6BVGiVZlK7lsq1U=; b=iBq5lX1/RKlGFNztB/eZ2Xwj0vbbOIl6x+qNTX29uJlWGc7l1oVSedHq3MmyoSZq4c FaGMxNeQD/Zftu/4HGk3jidOMgQWzfrlPbEAaNBedqVDlL7MClFKitUZLvP5Bdx8JcYF gbJccT81Kf7+XstdjB0JZwSvA5HYoNR7rpVzj+iqC9AYQgssctkO0AF68ajaqcV3hqfk JReDXIZiw9ZArSmiG9jH5/VQIqigkuL+qXJl9ekiTQuiH+70u0JTiA9f0/3ZMgi/0KqR uObBZ/7K1ppOfNf/RsmsJwEk2caDu+DipyE7CmMCK//OnJRSjvUzcuJsv4icbtXAwHww 0LoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gLQ36k4F; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si9252612edl.228.2020.11.10.06.27.30; Tue, 10 Nov 2020 06:27:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gLQ36k4F; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730070AbgKJO13 (ORCPT + 4 others); Tue, 10 Nov 2020 09:27:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730059AbgKJO13 (ORCPT ); Tue, 10 Nov 2020 09:27:29 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 019BCC0613CF for ; Tue, 10 Nov 2020 06:27:28 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id d17so14414811lfq.10 for ; Tue, 10 Nov 2020 06:27:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n8uglzR99agOJ88UjmIg/xjEt6zI6BVGiVZlK7lsq1U=; b=gLQ36k4F1V9h9aVY7TAbTh120++aQJGBrhaJa3jDA+0z+QhElzKWDk28UJv6j+6cpQ 9rWqr0dfIKsqmtuhH6/qkYHaoHq/A0Cx6JKaVIB+wOn02sOpna0znJEkD/8RRS5juWZ+ J3eyD/lNMveWUGlGUSkzymmJ0JV0zxqQdGjbN/qNr1wbS2YcLS4OzKBo63o+fIm4ROGj GxtxoI6KNhwOZb0xXwTZitjL1d77X8z+NxRjNGY6XaR6nQwtv5RqXkXmEYzzayp3yBQ7 4PS2y8fHJyfZgAm5CzpIhI9+jBfbJ9LaOXlesxkg6l4F0/hIi78WHyOvaL70/OzgbeGu 5f0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n8uglzR99agOJ88UjmIg/xjEt6zI6BVGiVZlK7lsq1U=; b=Vb+E38rTDZQnrpNkti3p8l3CBPSfykOJs1U5r4QNFx/CLippI6wh105eMFhVBF9tF0 Z8QeMPwaRWIirN0IjhM4nF+HdQKYNQ9jcaYAYBcASPb0SqeQqOaRQ2TCm6WsqjLXkc3w jzwivLwejzxT5sK1Zt04zXh7WfV+ma1mNZs598yFd3w1nqwbe3edBkcRRlmY+AGXWYXg NxUhJqyqAxhdZe2jKAyvjAR1dHELfI11prNvWCTQk8giCIE5eML0tOvI7kFp6P8eHpz2 TbqokwpN4Kw5TQL+pqyobZSIepmietklR45TTISQpDVPUywjjRYeli0Tp8lGVaCIv65M 8Ydw== X-Gm-Message-State: AOAM5336/Ooj2i1Dj620X04mBJMumc8Cst9tGoCrY0g79/yYy4Jq5sDR L+0OeLPeigTv70z9Sh/Ubzp9jbpDZr1DdOoI X-Received: by 2002:ac2:5607:: with SMTP id v7mr4732783lfd.71.1605018446327; Tue, 10 Nov 2020 06:27:26 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id y2sm426169lfh.130.2020.11.10.06.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 06:27:25 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Bartosz Golaszewski , Linus Walleij Subject: [PATCH] gpio: sysfs: Enforce character device Date: Tue, 10 Nov 2020 15:27:24 +0100 Message-Id: <20201110142724.14760-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org If users select sysfs support they get the character device as well so that end-users cannot complain that they "only have sysfs on my system". They should have the character device at all times. If someone is in so dire need of stripping out the character device while still enabling the sysfs ABI they can very well patch the kernel. Also only show this obsolete option to expert users. Signed-off-by: Linus Walleij --- drivers/gpio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.26.2 diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 5d4de5cd6759..4dd566f7ea39 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -59,8 +59,9 @@ config DEBUG_GPIO that are most common when setting up new platforms or boards. config GPIO_SYSFS - bool "/sys/class/gpio/... (sysfs interface)" + bool "/sys/class/gpio/... (sysfs interface)" if EXPERT depends on SYSFS + select GPIO_CDEV # We need to encourage the new ABI help Say Y here to add the legacy sysfs interface for GPIOs.