From patchwork Thu Nov 19 21:00:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 328936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFCEBC63777 for ; Thu, 19 Nov 2020 21:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84E2A2224A for ; Thu, 19 Nov 2020 21:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TvJQt4NP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbgKSVAV (ORCPT ); Thu, 19 Nov 2020 16:00:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgKSVAU (ORCPT ); Thu, 19 Nov 2020 16:00:20 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0581C0613CF for ; Thu, 19 Nov 2020 13:00:19 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id a186so5666177wme.1 for ; Thu, 19 Nov 2020 13:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=FqtmZwBBU2ipiuRuMDrgFar7Ah+yE3POXmBZUc/Tsv8=; b=TvJQt4NPx60VtyYYLzPlMOqy+vjIjst3naQnahGgBo9LuEL5XZBpUKJy50tj/9bx7S uMG70/a7jFfxW3TNL1zC8GRJIy9AjtrmrRqi/f6cAH6CdVCIXQCke/8VIe8MVuzaJGx1 Oc0qiL8+GdBLtgq0fVZlZdDu9/ZFr9wi9cJqwY9ZG4WrJCctkUg9bH/E+BZzpOOiTBcD FUYoaz0H0HuLZvWAYRsCAj7cWa6OjshoUeo4NU91NZoehAeAWp3exK3RW3j3ATM9jNNi 0ksjKZIfY0900qyfqyKQrmrkUQnhtaLU+rI2vaG4yEuq86JHknjVGsHnawn8060BdDp2 TdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=FqtmZwBBU2ipiuRuMDrgFar7Ah+yE3POXmBZUc/Tsv8=; b=AJT5Eiql8YPemsnWr5UqBTEBETuGJnuAQs2sYgpm0kw5iPK4SdkQXrr44AwR/J7we5 nREjSEKwjb5iKpOx/JsAQjWJFrtkfWfey+Z05Q+zmPsxbbu017YpmY9xv/Wi2WHlcY+J OuOtzHQf1JGJCaVMITTnDtma8z1kFrPcP/jv/lWzBrw4HLowdZlTXiYGi/zvuvDk3Gl4 up8kzorcmRnFLriN1vZ5yV/O/yo70yLm1d8gZszRW1zaQCEe1XXk/qeLMmQxU+mX8S3s qQyV2HNKsvCUa6hjJHiIBdRMh11cG9fwWTrCUMp0RYcZ1H4g300uw05UTmpJFf8Ra4lz Grsg== X-Gm-Message-State: AOAM532h82mqTRinlhV6Z97qcgOySCx9AGckFp6NYjt2ob0bPDfVj1Bl TCowpBtql7TM5ayAYEDYtnfR2EUZABi+Yg== X-Google-Smtp-Source: ABdhPJzKSphKyC0I18qkpNzmN8kxuE3i5pGO/zddSqhVD4+wTKE3mHImnW//TVBFAi/k5JYLmxUILw== X-Received: by 2002:a1c:1b85:: with SMTP id b127mr6703805wmb.163.1605819618448; Thu, 19 Nov 2020 13:00:18 -0800 (PST) Received: from ?IPv6:2003:ea:8f23:2800:6d7c:9ea3:dfaa:d617? (p200300ea8f2328006d7c9ea3dfaad617.dip0.t-ipconnect.de. [2003:ea:8f23:2800:6d7c:9ea3:dfaa:d617]) by smtp.googlemail.com with ESMTPSA id f16sm1621153wrp.66.2020.11.19.13.00.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 13:00:18 -0800 (PST) From: Heiner Kallweit To: Jakub Kicinski , David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" Subject: [PATCH net-next] r8169: use dev_err_probe in rtl_get_ether_clk Message-ID: Date: Thu, 19 Nov 2020 22:00:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tiny improvement, let dev_err_probe() deal with EPROBE_DEFER. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 7dd643f53..a5c7a3935 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5165,8 +5165,8 @@ static int rtl_get_ether_clk(struct rtl8169_private *tp) if (rc == -ENOENT) /* clk-core allows NULL (for suspend / resume) */ rc = 0; - else if (rc != -EPROBE_DEFER) - dev_err(d, "failed to get clk: %d\n", rc); + else + dev_err_probe(d, rc, "failed to get clk\n"); } else { tp->clk = clk; rc = clk_prepare_enable(clk);