From patchwork Tue Dec 1 19:27:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 335143 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp396346ilb; Tue, 1 Dec 2020 11:30:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwsC96VWfqHJ9FU5/EBxtmc+Mg/3iOFbYbIozTjuiq41Vi45gP6MZeuH9xodhfVGbsHAMwC X-Received: by 2002:a2e:9916:: with SMTP id v22mr1992533lji.384.1606851048765; Tue, 01 Dec 2020 11:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606851048; cv=none; d=google.com; s=arc-20160816; b=QmyJ5WedgmIFiAwLJDJSodNQ+uJVq/APdBIj/1FlqsczIFmiKbIpLgkIJdW/5KBozd uuTzyPUx3oz7LR3ccWfIgA4SmST8oK942jbIjZOR/C8KgSd3B+K89YwYBQDdm9bm4Nzg yfxOSxgXHFVUSMGqdLIlF5KChDldI5uTV+ctAD/lE+3erj6h/ohkUfzvgOZNx8DVJFPG uesIb8hzR3ZhVJhsV4xmJRtYlG0MAeVghBOLr8Icxnm3ucv/rG1i5+pU0D4T10GN4Vw9 Ie1Jbk6LqEESZGAW6r+S6X+vTr0FAfBDd/YptRLw7LJZVJ0u0MwtABs65gS24o1LWuyV YheQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=biB1E7VQfFhALxeshFh3G0/O96X9L1epLBYd8Sfk+Nw=; b=X4SU1kSwU1SsAXUtejOCWxr0DYKLosQwXs8YM1GJOCLb7sV9RJTUwPB/HVLvD5UxRY OLFcr8VY1CMiMvjntu1ggRi7cVgnV42kLCb1WrQdzR6zYvLcWSbK92UWBZ7JPE0Pe+jI izF0QlGuI9oxworDip++M9KkjicYhDL6nxts8pD4yjga66EXyAVFiuxGpT5wFw8Nmlu4 jxlST4ceCPKV3/RgAIaqRwpyTIBsVlf4K9T7MpkcvIYyGHBq/pRL4TfmoD4ZwtFDS+v/ W5wzxpsRs3zx9I4NKiYYp0iGsKCrI2/1v7TWeDGPjctp9jdNfPcfd+0f0T7Jya8Tjqz0 JpFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xLTJ2dkm; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si579415edw.41.2020.12.01.11.30.48; Tue, 01 Dec 2020 11:30:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xLTJ2dkm; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404368AbgLAT30 (ORCPT + 8 others); Tue, 1 Dec 2020 14:29:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404353AbgLAT30 (ORCPT ); Tue, 1 Dec 2020 14:29:26 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04772C0617A7 for ; Tue, 1 Dec 2020 11:28:46 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id p8so4506123wrx.5 for ; Tue, 01 Dec 2020 11:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=biB1E7VQfFhALxeshFh3G0/O96X9L1epLBYd8Sfk+Nw=; b=xLTJ2dkmFyetvAQs8XCbA2YVz+kk+PyA+BSVGtk7vkhZpJmN7WYZ2fbRETpXYZcULa mPJvpt+mMKnLdanZ7jRUu2dZTos/9GX0AStqszpT9FSBJkn96JZNBTmMVRA9SffEiA6R SPvFFszUJ4ewvKZW7029b0hxeFLwHIuzX4Lcxxhc+ntQ8FDEgIuvdeAYM6iYS/bUHEUb ucgaFtDeQxpmu8m18BUNUtpWu5X5bXmoVpWGbghatw7F+DIrtldAcySmsO2CWA5EB0Lc wy2Bk2ht9HGAB2tyDQOwisu9hj/e5BJn+AWsEKw4hDvHhOgk9KPMh74F+Gn+SAQ3+T84 jgMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=biB1E7VQfFhALxeshFh3G0/O96X9L1epLBYd8Sfk+Nw=; b=jZebo3HZn+Bak/z17u1IA/xQOgm3c6PEQNNolH6+Y+4W/mdXgVwgKSTxNGyoFqiKXw 1Q2btFbDOUMPwo7YuQLalx0S4d9TC+zysF+Ni7cu1soR7k2he88cHYofmL6Zf2Tupgj/ Ebi4a+3ETmg5TgGX4Tc8KacbUWZ2+yMj5owdHw6Agg3HEUhSMQUMfexmK9bDnNoUy4UN ebjRGIG2mksnOmDHVk03GJRjUJUQuxorj4ckI/rS/Z7/F5o9oqQCvKbpvKDHlqYo47rE EXGvu0cfMlLpEbK0TcgFzWI+gj8Yio3BV7KWpYlzVZteZ/Q6ZGofj3L6vS5sb2hJg1qg Gf0w== X-Gm-Message-State: AOAM533LRnzIVTtWtVmFnP8/Kol/3lrtZ4gz3XB4V6Dc3a1gembzdgp4 zAABJBzRZe49GGQfpj59BY+Kp/IfobgHIg== X-Received: by 2002:a5d:4b81:: with SMTP id b1mr5842762wrt.372.1606850924675; Tue, 01 Dec 2020 11:28:44 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-140-184.adsl.proxad.net. [82.252.140.184]) by smtp.gmail.com with ESMTPSA id n123sm1317922wmn.7.2020.12.01.11.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 11:28:44 -0800 (PST) From: Daniel Lezcano To: rjw@rjwysocki.net Cc: ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com, Thara Gopinath , Lina Iyer , Ram Chandrasekar , Zhang Rui , Andrew Morton , Andy Shevchenko , Akinobu Mita Subject: [PATCH v4 1/4] units: Add Watt units Date: Tue, 1 Dec 2020 20:27:58 +0100 Message-Id: <20201201192801.27607-2-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201201192801.27607-1-daniel.lezcano@linaro.org> References: <20201201192801.27607-1-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org As there are the temperature units, let's add the Watt macros definition. Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Cc: Lukasz Luba Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- include/linux/units.h | 4 ++++ 1 file changed, 4 insertions(+) -- 2.17.1 diff --git a/include/linux/units.h b/include/linux/units.h index aaf716364ec3..92c234e71cab 100644 --- a/include/linux/units.h +++ b/include/linux/units.h @@ -4,6 +4,10 @@ #include +#define MILLIWATT_PER_WATT 1000L +#define MICROWATT_PER_MILLIWATT 1000L +#define MICROWATT_PER_WATT 1000000L + #define ABSOLUTE_ZERO_MILLICELSIUS -273150 static inline long milli_kelvin_to_millicelsius(long t) From patchwork Tue Dec 1 19:27:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 335144 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp396354ilb; Tue, 1 Dec 2020 11:30:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXUWfh9bWsVyApi0tVRyiJpHmmw0qBl2Vj8sv8umNWtPrVJzxI2CZpPnlwfxSlK2J3+Nvv X-Received: by 2002:a05:6402:1155:: with SMTP id g21mr4783663edw.53.1606851049360; Tue, 01 Dec 2020 11:30:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606851049; cv=none; d=google.com; s=arc-20160816; b=EBn7F/2N+miWDf0qLjv8xEN9G8+eJBWjHKHlQEQsX5afAZmAke+wZJK+qta0jRNxcU suXvl1PQslHnxyc6SqN5jGB70aLQamtoEEDI73/LRFChmNv6SSoCRZtgF4UkqjPMJaUj ZRCnv6SBwoD8Ka1Y7dqhHzMq3Oj0MmCJf19lbAoBTnEmsQ3UW7KsVlsfwyZjALDyVwXy 3QBv96JsPJ7RYQjXsgOTmBpGgnZsRU5rrbXZJgF3UWxr3bOsmYSgZC3vbXL84CIrHLGY Dnrj1ntzcUQu0Q4KsCqwwnzFL1paSrX7KsR9+ZXhXYjp2zXhugA2VbNDT2WyszvJ1Y/3 GUCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=FCStDhY/rSQSKI6thsjMCNv1pIeQvLh2oYwBPkXbYRI=; b=g6hnZpRf6iXJEjgebR/XoMfTEvchsvRTmpSGYzPLfledhfQPVrl+eOR+5WEkFxORUN A5zE/5n42j5aQvErxgIWLfxwyJSx59Z5dMZLJ2HGOhFOolSBXio1mgb2SktnZCTO9bf6 hm9t2vrNc5VsaycTFysVDIUwMaHAmoonD6AsrlNucfmteLXLxcYLY2ROF3SdHiLWN+jN JlXczzIiM+fSZM48CPPcAgefG71JAtoUbg3qxbRfbIU2EU3TQ5UVIEtkLcBUzh84miIu ViLqlWSJJ5He1pT4iZJBRAuKC9u6RtnUcwqvyGO9BilYE5+S/7DwqZXXlsQJF2sfOsxN TUTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p475lvEA; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si579415edw.41.2020.12.01.11.30.49; Tue, 01 Dec 2020 11:30:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p475lvEA; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbgLAT3k (ORCPT + 8 others); Tue, 1 Dec 2020 14:29:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbgLAT3k (ORCPT ); Tue, 1 Dec 2020 14:29:40 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A8B1C0613CF for ; Tue, 1 Dec 2020 11:28:54 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id o1so4488182wrx.7 for ; Tue, 01 Dec 2020 11:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FCStDhY/rSQSKI6thsjMCNv1pIeQvLh2oYwBPkXbYRI=; b=p475lvEAOuXjjZ6iPQxjZacrmz1xwNajcTsNjJn6SKugh+I4eRMxk0zQgO9JLRCyxM S0CHI5/7pteeEef/Llu9ITAe2TYmtOKLTIdRFw5M9c1A/4ClkiiQEZpwbF7D/JfrK9Rw iv/TwN7/dWbyrx8eThNFX8io5gKhbRg9myrnfE6FhlYLIj1Q5GZZvkrBv7d3PEbAHx8B oejVpfc3qqMgbURR0XBubNdqGZ/zAfTt/DDo9eCsyVNajzgn8j5pNxsGR/ldUNwGnRz+ OmCfTzMNsi1C/T5iPkX3lFStDJ0zT6888/3hUeqFLkp9SB1Vf6k7OryPJtUaCEuv5Y4O 2otQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FCStDhY/rSQSKI6thsjMCNv1pIeQvLh2oYwBPkXbYRI=; b=aKmsWjsgjP9Q71/9X9VnwA+A8XxXC9Oo7knAX+xtw4EKn2XMZhPZ7C2y1RFghmy67y kxCFfe4WLfssT5/o8H/MannX8hXX0yjczd9+Tn6KzuQzFMJ8O73EbTYoJGkN2oWsDXyr Xcpz+JwZwgxpci2WiU0dmI/Se7LJUX0EA9itc+/MMZ+7plWYB17Y0fYByeOiY6h7ZH6T QyVq5fgy9SiV1LMTUQXBwWYP63XWM6trmyZfi22KjDPr2DrLmPBiWLve0sd1rUjCj1Iy uUgUFYiSydYcz1TMt4CVbN7ZM7YWynZAvztSkq3VFEWhPFCxyKEoF8LHXh+uEUStWg2K HKOQ== X-Gm-Message-State: AOAM5320nclfMGKlYnlh4wEyWlw0b+Do89b5FzicpU0QvWIQbl4GtSBh oFlszAGvBXVEu6BRODodDfv9Ow== X-Received: by 2002:a5d:604f:: with SMTP id j15mr5754895wrt.47.1606850932644; Tue, 01 Dec 2020 11:28:52 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-140-184.adsl.proxad.net. [82.252.140.184]) by smtp.gmail.com with ESMTPSA id n123sm1317922wmn.7.2020.12.01.11.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 11:28:51 -0800 (PST) From: Daniel Lezcano To: rjw@rjwysocki.net Cc: ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com, Thara Gopinath , Lina Iyer , Ram Chandrasekar , Zhang Rui , Jonathan Corbet , Len Brown , Pavel Machek Subject: [PATCH v4 2/4] Documentation/powercap/dtpm: Add documentation for dtpm Date: Tue, 1 Dec 2020 20:27:59 +0100 Message-Id: <20201201192801.27607-3-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201201192801.27607-1-daniel.lezcano@linaro.org> References: <20201201192801.27607-1-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The dynamic thermal and power management is a technique to dynamically adjust the power consumption of different devices in order to ensure a global thermal constraint. An userspace daemon is usually monitoring the temperature and the power to take immediate action on the device. The DTPM framework provides an unified API to userspace to act on the power. Document this framework. Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Cc: Jonathan Corbet Signed-off-by: Daniel Lezcano --- Documentation/power/index.rst | 1 + Documentation/power/powercap/dtpm.rst | 210 ++++++++++++++++++++++++++ 2 files changed, 211 insertions(+) create mode 100644 Documentation/power/powercap/dtpm.rst -- 2.17.1 Reviewed-by: Lukasz Luba diff --git a/Documentation/power/index.rst b/Documentation/power/index.rst index ced8a8007434..a0f5244fb427 100644 --- a/Documentation/power/index.rst +++ b/Documentation/power/index.rst @@ -30,6 +30,7 @@ Power Management userland-swsusp powercap/powercap + powercap/dtpm regulator/consumer regulator/design diff --git a/Documentation/power/powercap/dtpm.rst b/Documentation/power/powercap/dtpm.rst new file mode 100644 index 000000000000..ca095ef4b887 --- /dev/null +++ b/Documentation/power/powercap/dtpm.rst @@ -0,0 +1,210 @@ +========================================== +Dynamic Thermal Power Management framework +========================================== + +On the embedded world, the complexity of the SoC leads to an +increasing number of hotspots which need to be monitored and mitigated +as a whole in order to prevent the temperature to go above the +normative and legally stated 'skin temperature'. + +Another aspect is to sustain the performance for a given power budget, +for example virtual reality where the user can feel dizziness if the +performance is capped while a big CPU is processing something else. Or +reduce the battery charging because the dissipated power is too high +compared with the power consumed by other devices. + +The userspace is the most adequate place to dynamically act on the +different devices by limiting their power given an application +profile: it has the knowledge of the platform. + +The Dynamic Thermal Power Management (DTPM) is a technique acting on +the device power by limiting and/or balancing a power budget among +different devices. + +The DTPM framework provides an unified interface to act on the +device power. + +Overview +======== + +The DTPM framework relies on the powercap framework to create the +powercap entries in the sysfs directory and implement the backend +driver to do the connection with the power manageable device. + +The DTPM is a tree representation describing the power constraints +shared between devices, not their physical positions. + +The nodes of the tree are a virtual description aggregating the power +characteristics of the children nodes and their power limitations. + +The leaves of the tree are the real power manageable devices. + +For instance:: + + SoC + | + `-- pkg + | + |-- pd0 (cpu0-3) + | + `-- pd1 (cpu4-5) + +The pkg power will be the sum of pd0 and pd1 power numbers:: + + SoC (400mW - 3100mW) + | + `-- pkg (400mW - 3100mW) + | + |-- pd0 (100mW - 700mW) + | + `-- pd1 (300mW - 2400mW) + +When the nodes are inserted in the tree, their power characteristics are propagated to the parents:: + + SoC (600mW - 5900mW) + | + |-- pkg (400mW - 3100mW) + | | + | |-- pd0 (100mW - 700mW) + | | + | `-- pd1 (300mW - 2400mW) + | + `-- pd2 (200mW - 2800mW) + +Each node have a weight on a 2^10 basis reflecting the percentage of power consumption along the siblings:: + + SoC (w=1024) + | + |-- pkg (w=538) + | | + | |-- pd0 (w=231) + | | + | `-- pd1 (w=794) + | + `-- pd2 (w=486) + + Note the sum of weights at the same level are equal to 1024. + +When a power limitation is applied to a node, then it is distributed along the children given their weights. For example, if we set a power limitation of 3200mW at the 'SoC' root node, the resulting tree will be:: + + SoC (w=1024) <--- power_limit = 3200mW + | + |-- pkg (w=538) --> power_limit = 1681mW + | | + | |-- pd0 (w=231) --> power_limit = 378mW + | | + | `-- pd1 (w=794) --> power_limit = 1303mW + | + `-- pd2 (w=486) --> power_limit = 1519mW + + +Flat description +---------------- + +A root node is created and it is the parent of all the nodes. This +description is the simplest one and it is supposed to give to +userspace a flat representation of all the devices supporting the +power limitation without any power limitation distribution. + +Hierarchical description +------------------------ + +The different devices supporting the power limitation are represented +hierarchically. There is one root node, all intermediate nodes are +grouping the child nodes which can be intermediate nodes also or real +devices. + +The intermediate nodes aggregate the power information and allows to +set the power limit given the weight of the nodes. + +Userspace API +============= + +As stated in the overview, the DTPM framework is built on top of the +powercap framework. Thus the sysfs interface is the same, please refer +to the powercap documentation for further details. + + * power_uw: Instantaneous power consumption. If the node is an + intermediate node, then the power consumption will be the sum of all + children power consumption. + + * max_power_range_uw: The power range resulting of the maximum power + minus the minimum power. + + * name: The name of the node. This is implementation dependant. Even + if it is not recommended for the userspace, several nodes can have + the same name. + + * constraint_X_name: The name of the constraint. + + * constraint_X_max_power_uw: The maximum power limit to be applicable + to the node. + + * constraint_X_power_limit_uw: The power limit to be applied to the + node. If the value contained in constraint_X_max_power_uw is set, + the constraint will be removed. + + * constraint_X_time_window_us: The meaning of this file will depend + on the constraint number. + +Constraints +----------- + + * Constraint 0: The power limitation is immediately applied, without + limitation in time. + +Kernel API +========== + +Overview +-------- + +The DTPM framework has no power limiting backend support. It is +generic and provides a set of API to let the different drivers to +implement the backend part for the power limitation and create a the +power constraints tree. + +It is up to the platform to provide the initialization function to +allocate and link the different nodes of the tree. + +A special macro has the role of declaring a node and the corresponding +initialization function via a description structure. This one contains +an optional parent field allowing to hook different devices to an +already existing tree at boot time. + +For instance:: + + struct dtpm_descr my_descr = { + .name = "my_name", + .init = my_init_func, + }; + + DTPM_DECLARE(my_descr); + +The nodes of the DTPM tree are described with dtpm structure. The +steps to add a new power limitable device is done in three steps: + + * Allocate the dtpm node + * Set the power number of the dtpm node + * Register the dtpm node + +The registration of the dtpm node is done with the powercap +ops. Basically, it must implements the callbacks to get and set the +power and the limit. + +Alternatively, if the node to be inserted is an intermediate one, then +a simple function to insert it as a future parent is available. + +If a device has its power characteristics changing, then the tree must +be updated with the new power numbers and weights. + +Nomenclature +------------ + + * dtpm_alloc() : Allocate and initialize a dtpm structure + + * dtpm_register() : Add the dtpm node to the tree + + * dtpm_unregister() : Remove the dtpm node from the tree + + * dtpm_update_power() : Update the power characteristics of the dtpm node From patchwork Tue Dec 1 19:28:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 335145 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp396464ilb; Tue, 1 Dec 2020 11:30:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8wQ9RYtrBYiT5mo+WFuotbf99pywNdBIWe3EeK3E7apOGlaP1/d1zTb6YVIPmFbfP21f5 X-Received: by 2002:a19:ac9:: with SMTP id 192mr1828871lfk.342.1606851055732; Tue, 01 Dec 2020 11:30:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606851055; cv=none; d=google.com; s=arc-20160816; b=QMYWXiAHFU3Of5dHDf0/jsvSQsNzNiobDFX7iEZzsM0HZ9cLfL55275Uh9/FJuKgfa M1TBIovjJYtYVha8ZA5wOeRp3ux0uSwIfb7l72NHLEmpGRrkGokBRAPnzVOWuTla+CLO CwXaahJ6SR388UiEyxhQHBikflNPb5kvK53o3Wz3noVJmhCmNXOXEei46SZji6YWPUSr 0X4U5F4PK84tpcJp0kFkn4f7G/9eZI7MnVq+3NSwpIhpKuVoPP7l9drGVgkyx6c7rvOV sVCP/Yqmq2udVh2/QcTF9TvDsKIGokf5YDYe40RcX0beaiL2IuFJCYeWfO3gH56wkN20 AV6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=fjiOkUXx4q+3PXD4NzsYZax+SjTvKvFgyC4hFoqcRmI=; b=UOQV3I2AqdensHk93Aul4p2O9/1N9QKIHplnGLtEeLdyM7G1hXbszjyIfcAgwllx0d s1b5Bdwrth9ywOcZuOYFlGDM2pzguU4FroFRUFHgOAFum7p7gQk4HbrtQRi/Mxz6R0Kq CKgfo1QNkFJANj8r1ooHPlBddEmod6rl61aRfm5neiEl8ryvJlwGIEnKZr5QIx8H7lH2 EpzjUxKFQyB2Ldaz3pDSinFn+iuEarGOsslGul9q5WEdm4LTbyuzMwSO0MZ0tx8fLBtY ixoHbzDKslJ4wLgDZeyv9RrUh75YZJ8yL6u2jEU3NJp/6zAnwidOh19yd7aVjQvicEFT tnlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S+eM8REO; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si579415edw.41.2020.12.01.11.30.55; Tue, 01 Dec 2020 11:30:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S+eM8REO; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731356AbgLAT34 (ORCPT + 8 others); Tue, 1 Dec 2020 14:29:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730420AbgLAT34 (ORCPT ); Tue, 1 Dec 2020 14:29:56 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E496C061A47 for ; Tue, 1 Dec 2020 11:29:01 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id k14so4516640wrn.1 for ; Tue, 01 Dec 2020 11:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fjiOkUXx4q+3PXD4NzsYZax+SjTvKvFgyC4hFoqcRmI=; b=S+eM8REOYmJiSRNQKtQf6sQaiClE/DpUWFA/rsGCGiBsLvulRxZeb1x7Bt0gNpOe36 Zq8sPVvXs3o3DOprXvuu6PP5uiKaeNHci4t6OQmQK2mzONOrhUvkL3+gEt525ycO19zJ RZpqh+RNoGjhmN/hQDp4JCINCQAcI1Qi7QP3Fv5fJxryl88t7kAC+4g5b7eonKdxI7qI 83NzUDBp00hIeIFYXyZyDb3zV8o1h5iZAunUeutDmXQjFmRQxNCnnEFoAR5VHOMQxoDS Q3PXv0mWyZ8GgKMg5ieax8MX6HTK/xV1ia1M4/l8hLmwwXqqUb5NOCryNHL5FQEYU643 C0yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fjiOkUXx4q+3PXD4NzsYZax+SjTvKvFgyC4hFoqcRmI=; b=UG3R9PkG9mUQ+fQzDMbdBty1iMQkkV+dh2yIAcXOp7nXEeRm9cYylqAUJWIIm5rYNb bI8WAzv1gOaX285LE1mkoRyEkHO0tpYTy0Hgp3x8GWmcGRQ7m4HrbBipqec/Ayxnwxkm gO5uqnNH/f/j3/oo02UVpLuEPE7zYImDMpOD4FFl2GDjinrEO+dJcTa3aJDOEy/K3F5r 6wyfjcrAfNVDZRr0Av+nf6HsNFZct+k2cuKE4kLR8wbkQWpWQ2CTd2RA+qEODxTgLoGy DtAAhTIJX5qkd8Az/ltF3wclttXHpQ62H2IL7dyDGAbr30oRsMLdPcFIkRWUi1NkYZJN FAGQ== X-Gm-Message-State: AOAM532jVzavBGCOTlxeoz2EcuCx5ZG0iEN/wcEofAVJk4ALjPJedQav euYjUiKyGs8KkYsitG3bwJq2C/NZAgpRNA== X-Received: by 2002:adf:e387:: with SMTP id e7mr5728739wrm.177.1606850939954; Tue, 01 Dec 2020 11:28:59 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-140-184.adsl.proxad.net. [82.252.140.184]) by smtp.gmail.com with ESMTPSA id n123sm1317922wmn.7.2020.12.01.11.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 11:28:59 -0800 (PST) From: Daniel Lezcano To: rjw@rjwysocki.net Cc: ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com, Thara Gopinath , Lina Iyer , Ram Chandrasekar , Zhang Rui , Arnd Bergmann , linux-arch@vger.kernel.org (open list:GENERIC INCLUDE/ASM HEADER FILES) Subject: [PATCH v4 3/4] powercap/drivers/dtpm: Add API for dynamic thermal power management Date: Tue, 1 Dec 2020 20:28:00 +0100 Message-Id: <20201201192801.27607-4-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201201192801.27607-1-daniel.lezcano@linaro.org> References: <20201201192801.27607-1-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On the embedded world, the complexity of the SoC leads to an increasing number of hotspots which need to be monitored and mitigated as a whole in order to prevent the temperature to go above the normative and legally stated 'skin temperature'. Another aspect is to sustain the performance for a given power budget, for example virtual reality where the user can feel dizziness if the GPU performance is capped while a big CPU is processing something else. Or reduce the battery charging because the dissipated power is too high compared with the power consumed by other devices. The userspace is the most adequate place to dynamically act on the different devices by limiting their power given an application profile: it has the knowledge of the platform. These userspace daemons are in charge of the Dynamic Thermal Power Management (DTPM). Nowadays, the dtpm daemons are abusing the thermal framework as they act on the cooling device state to force a specific and arbitrary state without taking care of the governor decisions. Given the closed loop of some governors that can confuse the logic or directly enter in a decision conflict. As the number of cooling device support is limited today to the CPU and the GPU, the dtpm daemons have little control on the power dissipation of the system. The out of tree solutions are hacking around here and there in the drivers, in the frameworks to have control on the devices. The common solution is to declare them as cooling devices. There is no unification of the power limitation unit, opaque states are used. This patch provides a way to create a hierarchy of constraints using the powercap framework. The devices which are registered as power limit-able devices are represented in this hierarchy as a tree. They are linked together with intermediate nodes which are just there to propagate the constraint to the children. The leaves of the tree are the real devices, the intermediate nodes are virtual, aggregating the children constraints and power characteristics. Each node have a weight on a 2^10 basis, in order to reflect the percentage of power distribution of the children's node. This percentage is used to dispatch the power limit to the children. The weight is computed against the max power of the siblings. This simple approach allows to do a fair distribution of the power limit. Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/Kconfig | 6 + drivers/powercap/Makefile | 1 + drivers/powercap/dtpm.c | 470 ++++++++++++++++++++++++++++++ include/asm-generic/vmlinux.lds.h | 11 + include/linux/dtpm.h | 75 +++++ 5 files changed, 563 insertions(+) create mode 100644 drivers/powercap/dtpm.c create mode 100644 include/linux/dtpm.h -- 2.17.1 Tested-by: Lukasz Luba diff --git a/drivers/powercap/Kconfig b/drivers/powercap/Kconfig index bc228725346b..cc1953bd8bed 100644 --- a/drivers/powercap/Kconfig +++ b/drivers/powercap/Kconfig @@ -43,4 +43,10 @@ config IDLE_INJECT CPUs for power capping. Idle period can be injected synchronously on a set of specified CPUs or alternatively on a per CPU basis. + +config DTPM + bool "Power capping for Dynamic Thermal Power Management" + help + This enables support for the power capping for the dynamic + thermal power management userspace engine. endif diff --git a/drivers/powercap/Makefile b/drivers/powercap/Makefile index 7255c94ec61c..6482ac52054d 100644 --- a/drivers/powercap/Makefile +++ b/drivers/powercap/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_DTPM) += dtpm.o obj-$(CONFIG_POWERCAP) += powercap_sys.o obj-$(CONFIG_INTEL_RAPL_CORE) += intel_rapl_common.o obj-$(CONFIG_INTEL_RAPL) += intel_rapl_msr.o diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c new file mode 100644 index 000000000000..d8f431d87555 --- /dev/null +++ b/drivers/powercap/dtpm.c @@ -0,0 +1,470 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2020 Linaro Limited + * + * Author: Daniel Lezcano + * + * The powercap based Dynamic Thermal Power Management framework + * provides to the userspace a consistent API to set the power limit + * on some devices. + * + * DTPM defines the functions to create a tree of constraints. Each + * parent node is a virtual description of the aggregation of the + * children. It propagates the constraints set at its level to its + * children and collect the children power information. The leaves of + * the tree are the real devices which have the ability to get their + * current power consumption and set their power limit. + */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include +#include + +#define DTPM_POWER_LIMIT_FLAG BIT(0) + +static const char *constraint_name[] = { + "Instantaneous", +}; + +static DEFINE_MUTEX(dtpm_lock); +static struct powercap_control_type *pct; +static struct dtpm *root; + +static int get_time_window_us(struct powercap_zone *pcz, int cid, u64 *window) +{ + return -ENOSYS; +} + +static int set_time_window_us(struct powercap_zone *pcz, int cid, u64 window) +{ + return -ENOSYS; +} + +static int get_max_power_range_uw(struct powercap_zone *pcz, u64 *max_power_uw) +{ + struct dtpm *dtpm = to_dtpm(pcz); + + mutex_lock(&dtpm_lock); + *max_power_uw = dtpm->power_max - dtpm->power_min; + mutex_unlock(&dtpm_lock); + + return 0; +} + +static int __get_power_uw(struct dtpm *dtpm, u64 *power_uw) +{ + struct dtpm *child; + u64 power; + int ret = 0; + + if (dtpm->ops) { + *power_uw = dtpm->ops->get_power_uw(dtpm); + return 0; + } + + *power_uw = 0; + + list_for_each_entry(child, &dtpm->children, sibling) { + ret = __get_power_uw(child, &power); + if (ret) + break; + *power_uw += power; + } + + return ret; +} + +static int get_power_uw(struct powercap_zone *pcz, u64 *power_uw) +{ + struct dtpm *dtpm = to_dtpm(pcz); + int ret; + + mutex_lock(&dtpm_lock); + ret = __get_power_uw(dtpm, power_uw); + mutex_unlock(&dtpm_lock); + + return ret; +} + +static void __dtpm_rebalance_weight(struct dtpm *dtpm) +{ + struct dtpm *child; + + list_for_each_entry(child, &dtpm->children, sibling) { + + pr_debug("Setting weight '%d' for '%s'\n", + child->weight, child->zone.name); + + child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024, + dtpm->power_max); + + __dtpm_rebalance_weight(child); + } +} + +static void __dtpm_sub_power(struct dtpm *dtpm) +{ + struct dtpm *parent = dtpm->parent; + + while (parent) { + parent->power_min -= dtpm->power_min; + parent->power_max -= dtpm->power_max; + parent->power_limit -= dtpm->power_limit; + parent = parent->parent; + } + + __dtpm_rebalance_weight(root); +} + +static void __dtpm_add_power(struct dtpm *dtpm) +{ + struct dtpm *parent = dtpm->parent; + + while (parent) { + parent->power_min += dtpm->power_min; + parent->power_max += dtpm->power_max; + parent->power_limit += dtpm->power_limit; + parent = parent->parent; + } + + __dtpm_rebalance_weight(root); +} + +/** + * dtpm_update_power - Update the power on the dtpm + * @dtpm: a pointer to a dtpm structure to update + * @power_min: a u64 representing the new power_min value + * @power_max: a u64 representing the new power_max value + * + * Function to update the power values of the dtpm node specified in + * parameter. These new values will be propagated to the tree. + * + * Return: zero on success, -EINVAL if the values are inconsistent + */ +int dtpm_update_power(struct dtpm *dtpm, u64 power_min, u64 power_max) +{ + mutex_lock(&dtpm_lock); + + if (power_min == dtpm->power_min && power_max == dtpm->power_max) + return 0; + + if (power_max < power_min) + return -EINVAL; + + __dtpm_sub_power(dtpm); + + dtpm->power_min = power_min; + dtpm->power_max = power_max; + if (!test_bit(DTPM_POWER_LIMIT_FLAG, &dtpm->flags)) + dtpm->power_limit = power_max; + + __dtpm_add_power(dtpm); + + mutex_unlock(&dtpm_lock); + + return 0; +} + +/** + * dtpm_release_zone - Cleanup when the node is released + * @pcz: a pointer to a powercap_zone structure + * + * Do some housecleaning and update the weight on the tree. The + * release will be denied if the node has children. This function must + * be called by the specific release callback of the different + * backends. + * + * Return: 0 on success, -EBUSY if there are children + */ +int dtpm_release_zone(struct powercap_zone *pcz) +{ + struct dtpm *dtpm = to_dtpm(pcz); + struct dtpm *parent = dtpm->parent; + + mutex_lock(&dtpm_lock); + + if (!list_empty(&dtpm->children)) + return -EBUSY; + + if (parent) + list_del(&dtpm->sibling); + + __dtpm_sub_power(dtpm); + + mutex_unlock(&dtpm_lock); + + if (dtpm->ops) + dtpm->ops->release(dtpm); + + kfree(dtpm); + + return 0; +} + +static int __get_power_limit_uw(struct dtpm *dtpm, int cid, u64 *power_limit) +{ + *power_limit = dtpm->power_limit; + return 0; +} + +static int get_power_limit_uw(struct powercap_zone *pcz, + int cid, u64 *power_limit) +{ + struct dtpm *dtpm = to_dtpm(pcz); + int ret; + + mutex_lock(&dtpm_lock); + ret = __get_power_limit_uw(dtpm, cid, power_limit); + mutex_unlock(&dtpm_lock); + + return ret; +} + +/* + * Set the power limit on the nodes, the power limit is distributed + * given the weight of the children. + * + * The dtpm node lock must be held when calling this function. + */ +static int __set_power_limit_uw(struct dtpm *dtpm, int cid, u64 power_limit) +{ + struct dtpm *child; + int ret = 0; + u64 power; + + /* + * A max power limitation means we remove the power limit, + * otherwise we set a constraint and flag the dtpm node. + */ + if (power_limit == dtpm->power_max) { + clear_bit(DTPM_POWER_LIMIT_FLAG, &dtpm->flags); + } else { + set_bit(DTPM_POWER_LIMIT_FLAG, &dtpm->flags); + } + + pr_debug("Setting power limit for '%s': %llu uW\n", + dtpm->zone.name, power_limit); + + /* + * Only leaves of the dtpm tree has ops to get/set the power + */ + if (dtpm->ops) { + dtpm->power_limit = dtpm->ops->set_power_uw(dtpm, power_limit); + } else { + dtpm->power_limit = 0; + + list_for_each_entry(child, &dtpm->children, sibling) { + + /* + * Integer division rounding will inevitably + * lead to a different min or max value when + * set several times. In order to restore the + * initial value, we force the child's min or + * max power every time if the constraint is + * at the boundaries. + */ + if (power_limit == dtpm->power_max) { + power = child->power_max; + } else if (power_limit == dtpm->power_min) { + power = child->power_min; + } else { + power = DIV_ROUND_CLOSEST( + power_limit * child->weight, 1024); + } + + pr_debug("Setting power limit for '%s': %llu uW\n", + child->zone.name, power); + + ret = __set_power_limit_uw(child, cid, power); + if (!ret) + ret = __get_power_limit_uw(child, cid, &power); + + if (ret) + break; + + dtpm->power_limit += power; + } + } + + return ret; +} + +static int set_power_limit_uw(struct powercap_zone *pcz, + int cid, u64 power_limit) +{ + struct dtpm *dtpm = to_dtpm(pcz); + int ret; + + mutex_lock(&dtpm_lock); + + /* + * Don't allow values outside of the power range previously + * set when initializing the power numbers. + */ + power_limit = clamp_val(power_limit, dtpm->power_min, dtpm->power_max); + + ret = __set_power_limit_uw(dtpm, cid, power_limit); + + pr_debug("%s: power limit: %llu uW, power max: %llu uW\n", + dtpm->zone.name, dtpm->power_limit, dtpm->power_max); + + mutex_unlock(&dtpm_lock); + + return ret; +} + +static const char *get_constraint_name(struct powercap_zone *pcz, int cid) +{ + return constraint_name[cid]; +} + +static int get_max_power_uw(struct powercap_zone *pcz, int id, u64 *max_power) +{ + struct dtpm *dtpm = to_dtpm(pcz); + + mutex_lock(&dtpm_lock); + *max_power = dtpm->power_max; + mutex_unlock(&dtpm_lock); + + return 0; +} + +static struct powercap_zone_constraint_ops constraint_ops = { + .set_power_limit_uw = set_power_limit_uw, + .get_power_limit_uw = get_power_limit_uw, + .set_time_window_us = set_time_window_us, + .get_time_window_us = get_time_window_us, + .get_max_power_uw = get_max_power_uw, + .get_name = get_constraint_name, +}; + +static struct powercap_zone_ops zone_ops = { + .get_max_power_range_uw = get_max_power_range_uw, + .get_power_uw = get_power_uw, + .release = dtpm_release_zone, +}; + +/** + * dtpm_alloc - Allocate and initialize a dtpm struct + * @name: a string specifying the name of the node + * + * Return: a struct dtpm pointer, NULL in case of error + */ +struct dtpm *dtpm_alloc(struct dtpm_ops *ops) +{ + struct dtpm *dtpm; + + dtpm = kzalloc(sizeof(*dtpm), GFP_KERNEL); + if (dtpm) { + INIT_LIST_HEAD(&dtpm->children); + INIT_LIST_HEAD(&dtpm->sibling); + dtpm->weight = 1024; + dtpm->ops = ops; + } + + return dtpm; +} + +/** + * dtpm_unregister - Unregister a dtpm node from the hierarchy tree + * @dtpm: a pointer to a dtpm structure corresponding to the node to be removed + * + * Call the underlying powercap unregister function. That will call + * the release callback of the powercap zone. + */ +void dtpm_unregister(struct dtpm *dtpm) +{ + powercap_unregister_zone(pct, &dtpm->zone); + + pr_info("Unregistered dtpm node '%s'\n", dtpm->zone.name); +} + +/** + * dtpm_register - Register a dtpm node in the hierarchy tree + * @name: a string specifying the name of the node + * @dtpm: a pointer to a dtpm structure corresponding to the new node + * @parent: a pointer to a dtpm structure corresponding to the parent node + * + * Create a dtpm node in the tree. If no parent is specified, the node + * is the root node of the hierarchy. If the root node already exists, + * then the registration will fail. The powercap controller must be + * initialized before calling this function. + * + * The dtpm structure must be initialized with the power numbers + * before calling this function. + * + * Return: zero on success, a negative value in case of error: + * -EAGAIN: the function is called before the framework is initialized. + * -EBUSY: the root node is already inserted + * -EINVAL: * there is no root node yet and @parent is specified + * * no all ops are defined + * * parent have ops which are reserved for leaves + * Other negative values are reported back from the powercap framework + */ +int dtpm_register(const char *name, struct dtpm *dtpm, struct dtpm *parent) +{ + struct powercap_zone *pcz; + + if (!pct) + return -EAGAIN; + + if (root && !parent) + return -EBUSY; + + if (!root && parent) + return -EINVAL; + + if (parent && parent->ops) + return -EINVAL; + + if (dtpm->ops && !(dtpm->ops->set_power_uw && + dtpm->ops->get_power_uw && + dtpm->ops->release)) + return -EINVAL; + + pcz = powercap_register_zone(&dtpm->zone, pct, name, + parent ? &parent->zone : NULL, + &zone_ops, MAX_DTPM_CONSTRAINTS, + &constraint_ops); + if (IS_ERR(pcz)) + return PTR_ERR(pcz); + + mutex_lock(&dtpm_lock); + + if (parent) { + list_add_tail(&dtpm->sibling, &parent->children); + dtpm->parent = parent; + } else { + root = dtpm; + } + + __dtpm_add_power(dtpm); + + pr_info("Registered dtpm node '%s' / %llu-%llu uW, \n", + dtpm->zone.name, dtpm->power_min, dtpm->power_max); + + mutex_unlock(&dtpm_lock); + + return 0; +} + +static int __init dtpm_init(void) +{ + struct dtpm_descr **dtpm_descr; + + pct = powercap_register_control_type(NULL, "dtpm", NULL); + if (!pct) { + pr_err("Failed to register control type\n"); + return -EINVAL; + } + + for_each_dtpm_table(dtpm_descr) + (*dtpm_descr)->init(*dtpm_descr); + + return 0; +} +late_initcall(dtpm_init); diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index b2b3d81b1535..b3e4e0740089 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -316,6 +316,16 @@ #define THERMAL_TABLE(name) #endif +#ifdef CONFIG_DTPM +#define DTPM_TABLE() \ + . = ALIGN(8); \ + __dtpm_table = .; \ + KEEP(*(__dtpm_table)) \ + __dtpm_table_end = .; +#else +#define DTPM_TABLE() +#endif + #define KERNEL_DTB() \ STRUCT_ALIGN(); \ __dtb_start = .; \ @@ -733,6 +743,7 @@ ACPI_PROBE_TABLE(irqchip) \ ACPI_PROBE_TABLE(timer) \ THERMAL_TABLE(governor) \ + DTPM_TABLE() \ EARLYCON_TABLE() \ LSM_TABLE() \ EARLY_LSM_TABLE() \ diff --git a/include/linux/dtpm.h b/include/linux/dtpm.h new file mode 100644 index 000000000000..7a1d0b50e334 --- /dev/null +++ b/include/linux/dtpm.h @@ -0,0 +1,75 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2020 Linaro Ltd + * + * Author: Daniel Lezcano + */ +#ifndef ___DTPM_H__ +#define ___DTPM_H__ + +#include + +#define MAX_DTPM_DESCR 8 +#define MAX_DTPM_CONSTRAINTS 1 + +struct dtpm { + struct powercap_zone zone; + struct dtpm *parent; + struct list_head sibling; + struct list_head children; + struct dtpm_ops *ops; + unsigned long flags; + u64 power_limit; + u64 power_max; + u64 power_min; + int weight; + void *private; +}; + +struct dtpm_ops { + u64 (*set_power_uw)(struct dtpm *, u64); + u64 (*get_power_uw)(struct dtpm *); + void (*release)(struct dtpm *); +}; + +struct dtpm_descr; + +typedef int (*dtpm_init_t)(struct dtpm_descr *); + +struct dtpm_descr { + struct dtpm *parent; + const char *name; + dtpm_init_t init; +}; + +/* Init section thermal table */ +extern struct dtpm_descr *__dtpm_table[]; +extern struct dtpm_descr *__dtpm_table_end[]; + +#define DTPM_TABLE_ENTRY(name) \ + static typeof(name) *__dtpm_table_entry_##name \ + __used __section("__dtpm_table") = &name + +#define DTPM_DECLARE(name) DTPM_TABLE_ENTRY(name) + +#define for_each_dtpm_table(__dtpm) \ + for (__dtpm = __dtpm_table; \ + __dtpm < __dtpm_table_end; \ + __dtpm++) + +static inline struct dtpm *to_dtpm(struct powercap_zone *zone) +{ + return container_of(zone, struct dtpm, zone); +} + +int dtpm_update_power(struct dtpm *dtpm, u64 power_min, u64 power_max); + +int dtpm_release_zone(struct powercap_zone *pcz); + +struct dtpm *dtpm_alloc(struct dtpm_ops *ops); + +void dtpm_unregister(struct dtpm *dtpm); + +int dtpm_register(const char *name, struct dtpm *dtpm, struct dtpm *parent); + +#endif From patchwork Tue Dec 1 19:28:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 335146 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp396507ilb; Tue, 1 Dec 2020 11:30:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYwf9+n6bk5p0d6gweIkzVu31PziGVCC03tj56d43d8rzIF3RqPjBweppx1z/PdGSB0hqM X-Received: by 2002:a17:906:3c04:: with SMTP id h4mr4553681ejg.220.1606851058364; Tue, 01 Dec 2020 11:30:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606851058; cv=none; d=google.com; s=arc-20160816; b=SOSL6tKo5wpt1SSps7CFvOHFbIXNF9j99E2HDw5zn04luFho62Y7OCsJLvaL9xPfka CK1OeqVHEhocCJ96RrUhiyW0gAY6Ak9+SKAjT+P7WvzuFUmNCqBW/Ddrx1L3ZHlBaLNu JeyUXkx3p0XTvz8HMWhKvrdoEP98BdXw6JzjhR0DCtUaDEsCoYAK4aYskuVtMtBBi9P3 shrrGgJDIDtfXmpXZ5IJyqsSWV0Ds+3+q5TXQor5vh0iPCR80yDD+aOrjAHYKLvoN/Bk jOzkFChNjKeJ8LYzH2z9yduZLO4HYCP+2na+aYP3YIsg6sLNrm9COMiErfy8Ai/2KeGe YsgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=VOd3JSDgGEf/sA/gneW99yzrnw1TXcmtGN43mHDRXQY=; b=BBhROCjJAgT0lXXvrhgX2Z/8e8UDBa0Ua6K0//6uOJwhscmRA5h1Q7HYIcsgQHGLR/ 7g8TA2AvCtKJLYhnf3kq12xb6F0UynKvGGFTGt9cvYz1BVuNerABP0sPvrzrYqqnt9pV fXV+5T2FPXyfDQZcnpr1c+SSygnb1fA4PSaFLZyKxnMJZgLUhQhNeZvN29lq9ivK+Yay 31jirBJ4NBmMxXRdIterwC9jkYInsHcl/fHNpjuR8MqTW63TPXsaqABjh2Z8XrmRjeZi 0CRnP6OH77g/7foQJgr6aRl/Vc17hov+C+gRpL4dA/ED8bBbNoZ40xulTrIeFsrUDGjJ H8RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T09eoCIy; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si579415edw.41.2020.12.01.11.30.57; Tue, 01 Dec 2020 11:30:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T09eoCIy; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404328AbgLATaC (ORCPT + 8 others); Tue, 1 Dec 2020 14:30:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404324AbgLATaC (ORCPT ); Tue, 1 Dec 2020 14:30:02 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1482C061A4A for ; Tue, 1 Dec 2020 11:29:10 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id s8so4478731wrw.10 for ; Tue, 01 Dec 2020 11:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VOd3JSDgGEf/sA/gneW99yzrnw1TXcmtGN43mHDRXQY=; b=T09eoCIyyL0p97FRT3WIcvf3dvO1HjfeGP1LTk6iswcKA1VIKznSxtVnYUSVzXJGWs wRgcBydqKmJESEMxQca3qn89xmbZXmilx6wPepjrzrBt+Q9FSs/yJeU5flGyDGAQiHqr mRowDXJ+OLvS1TF/yWi2jWgkRB6rmpKilaoXuMmgd00ryW4WRmreOXQz3mHkn7kJVyph yQtbLqsmsYkNYXbWf9sbG3IhmiQZpUeBS7eYSaZVcf6AFoUZHTJBsqEBUnL09VD2RIs9 lj33v+S1ukAs/vVaRHVYpsh7KSYN2lzx9fSqvq83hEioU+M9aXNzzdMZn5pzJ3BomJlI 5BRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VOd3JSDgGEf/sA/gneW99yzrnw1TXcmtGN43mHDRXQY=; b=GvhtkyprVncrvbZzLkGObnVbkMl68I6/QtKiDGyrBqIQmBW2MV8qaMN6PBpZpSS6C1 gpz2xvL/gRdt6OK9paZLg1yx/6vKnxVlnbJytGr31A9jI7ZPfp3iSx/VHErSJqcNJiGL O2uHSAGbv17jgTqfDlN2N9jezIIjT/x355Ejh7bfsrqkV7zm4j3blCm0ptod1K33Kl/G rSqONeL/TMCIpy1cMK8Xw16dzR+xvB94hbiynyOvSHaEFV+GPaZ9bjTYe6AI07ZGxxzz i4nWk2Pp8KJcCduPofK0CkCixKWlMDvNrSMLe7kC2s4Nu7SK+x24HRrb/YUv7ZL5FSbD trKw== X-Gm-Message-State: AOAM532lQ2Yy+/ekWUdH0UhDTPQgkDQocvx19TNeZQLHM/flAWk2nQGe gSH3pvCBd1WP2Mdgk+28/Y2qeA== X-Received: by 2002:adf:e3cf:: with SMTP id k15mr5848029wrm.259.1606850949389; Tue, 01 Dec 2020 11:29:09 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-140-184.adsl.proxad.net. [82.252.140.184]) by smtp.gmail.com with ESMTPSA id n123sm1317922wmn.7.2020.12.01.11.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 11:29:08 -0800 (PST) From: Daniel Lezcano To: rjw@rjwysocki.net Cc: ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com, Thara Gopinath , Lina Iyer , Ram Chandrasekar , Zhang Rui , Palmer Dabbelt , Anup Patel , Michael Ellerman , Kajol Jain , Zqiang , Daniel Jordan , Mike Leach , Atish Patra , Andrew Jones Subject: [PATCH v4 4/4] powercap/drivers/dtpm: Add CPU energy model based support Date: Tue, 1 Dec 2020 20:28:01 +0100 Message-Id: <20201201192801.27607-5-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201201192801.27607-1-daniel.lezcano@linaro.org> References: <20201201192801.27607-1-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org With the powercap dtpm controller, we are able to plug devices with power limitation features in the tree. The following patch introduces the CPU power limitation based on the energy model and the performance states. The power limitation is done at the performance domain level. If some CPUs are unplugged, the corresponding power will be subtracted from the performance domain total power. It is up to the platform to initialize the dtpm tree and add the CPU. Here is an example to create a simple tree with one root node called "pkg" and the CPU's performance domains. static int dtpm_register_pkg(struct dtpm_descr *descr) { struct dtpm *pkg; int ret; pkg = dtpm_alloc(NULL); if (!pkg) return -ENOMEM; ret = dtpm_register(descr->name, pkg, descr->parent); if (ret) return ret; return dtpm_register_cpu(pkg); } static struct dtpm_descr descr = { .name = "pkg", .init = dtpm_register_pkg, }; DTPM_DECLARE(descr); Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Signed-off-by: Daniel Lezcano --- drivers/powercap/Kconfig | 7 + drivers/powercap/Makefile | 1 + drivers/powercap/dtpm_cpu.c | 257 ++++++++++++++++++++++++++++++++++++ include/linux/cpuhotplug.h | 1 + include/linux/dtpm.h | 2 + 5 files changed, 268 insertions(+) create mode 100644 drivers/powercap/dtpm_cpu.c -- 2.17.1 Reviewed-by: Lukasz Luba Tested-by: Lukasz Luba diff --git a/drivers/powercap/Kconfig b/drivers/powercap/Kconfig index cc1953bd8bed..20b4325c6161 100644 --- a/drivers/powercap/Kconfig +++ b/drivers/powercap/Kconfig @@ -49,4 +49,11 @@ config DTPM help This enables support for the power capping for the dynamic thermal power management userspace engine. + +config DTPM_CPU + bool "Add CPU power capping based on the energy model" + depends on DTPM && ENERGY_MODEL + help + This enables support for CPU power limitation based on + energy model. endif diff --git a/drivers/powercap/Makefile b/drivers/powercap/Makefile index 6482ac52054d..fabcf388a8d3 100644 --- a/drivers/powercap/Makefile +++ b/drivers/powercap/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only obj-$(CONFIG_DTPM) += dtpm.o +obj-$(CONFIG_DTPM_CPU) += dtpm_cpu.o obj-$(CONFIG_POWERCAP) += powercap_sys.o obj-$(CONFIG_INTEL_RAPL_CORE) += intel_rapl_common.o obj-$(CONFIG_INTEL_RAPL) += intel_rapl_msr.o diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c new file mode 100644 index 000000000000..6933c783c6b4 --- /dev/null +++ b/drivers/powercap/dtpm_cpu.c @@ -0,0 +1,257 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2020 Linaro Limited + * + * Author: Daniel Lezcano + * + * The DTPM CPU is based on the energy model. It hooks the CPU in the + * DTPM tree which in turns update the power number by propagating the + * power number from the CPU energy model information to the parents. + * + * The association between the power and the performance state, allows + * to set the power of the CPU at the OPP granularity. + * + * The CPU hotplug is supported and the power numbers will be updated + * if a CPU is hot plugged / unplugged. + */ +#include +#include +#include +#include +#include +#include +#include +#include + +static struct dtpm *__parent; + +static DEFINE_PER_CPU(struct dtpm *, dtpm_per_cpu); + +struct dtpm_cpu { + struct freq_qos_request qos_req; + int cpu; +}; + +/* + * When a new CPU is inserted at hotplug or boot time, add the power + * contribution and update the dtpm tree. + */ +static int power_add(struct dtpm *dtpm, struct em_perf_domain *em) +{ + u64 power_min, power_max; + + power_min = em->table[0].power; + power_min *= MICROWATT_PER_MILLIWATT; + power_min += dtpm->power_min; + + power_max = em->table[em->nr_perf_states - 1].power; + power_max *= MICROWATT_PER_MILLIWATT; + power_max += dtpm->power_max; + + return dtpm_update_power(dtpm, power_min, power_max); +} + +/* + * When a CPU is unplugged, remove its power contribution from the + * dtpm tree. + */ +static int power_sub(struct dtpm *dtpm, struct em_perf_domain *em) +{ + u64 power_min, power_max; + + power_min = em->table[0].power; + power_min *= MICROWATT_PER_MILLIWATT; + power_min = dtpm->power_min - power_min; + + power_max = em->table[em->nr_perf_states - 1].power; + power_max *= MICROWATT_PER_MILLIWATT; + power_max = dtpm->power_max - power_max; + + return dtpm_update_power(dtpm, power_min, power_max); +} + +static u64 set_pd_power_limit(struct dtpm *dtpm, u64 power_limit) +{ + struct dtpm_cpu *dtpm_cpu = dtpm->private; + struct em_perf_domain *pd; + struct cpumask cpus; + unsigned long freq; + u64 power; + int i, nr_cpus; + + pd = em_cpu_get(dtpm_cpu->cpu); + + cpumask_and(&cpus, cpu_online_mask, to_cpumask(pd->cpus)); + + nr_cpus = cpumask_weight(&cpus); + + for (i = 0; i < pd->nr_perf_states; i++) { + + power = pd->table[i].power * MICROWATT_PER_MILLIWATT * nr_cpus; + + if (power > power_limit) + break; + } + + freq = pd->table[i - 1].frequency; + + freq_qos_update_request(&dtpm_cpu->qos_req, freq); + + power_limit = pd->table[i - 1].power * + MICROWATT_PER_MILLIWATT * nr_cpus; + + return power_limit; +} + +static u64 get_pd_power_uw(struct dtpm *dtpm) +{ + struct dtpm_cpu *dtpm_cpu = dtpm->private; + struct em_perf_domain *pd; + struct cpumask cpus; + unsigned long freq; + int i, nr_cpus; + + pd = em_cpu_get(dtpm_cpu->cpu); + freq = cpufreq_quick_get(dtpm_cpu->cpu); + cpumask_and(&cpus, cpu_online_mask, to_cpumask(pd->cpus)); + nr_cpus = cpumask_weight(&cpus); + + for (i = 0; i < pd->nr_perf_states; i++) { + + if (pd->table[i].frequency < freq) + continue; + + return pd->table[i].power * + MICROWATT_PER_MILLIWATT * nr_cpus; + } + + return 0; +} + +static void pd_release(struct dtpm *dtpm) +{ + struct dtpm_cpu *dtpm_cpu = dtpm->private; + + if (freq_qos_request_active(&dtpm_cpu->qos_req)) + freq_qos_remove_request(&dtpm_cpu->qos_req); + + kfree(dtpm_cpu); +} + +static struct dtpm_ops dtpm_ops = { + .set_power_uw = set_pd_power_limit, + .get_power_uw = get_pd_power_uw, + .release = pd_release, +}; + +static int cpuhp_dtpm_cpu_offline(unsigned int cpu) +{ + struct cpufreq_policy *policy; + struct em_perf_domain *pd; + struct dtpm *dtpm; + + policy = cpufreq_cpu_get(cpu); + + if (!policy) + return 0; + + pd = em_cpu_get(cpu); + if (!pd) + return -EINVAL; + + dtpm = per_cpu(dtpm_per_cpu, cpu); + + power_sub(dtpm, pd); + + if (cpumask_weight(policy->cpus) != 1) + return 0; + + for_each_cpu(cpu, policy->related_cpus) + per_cpu(dtpm_per_cpu, cpu) = NULL; + + dtpm_unregister(dtpm); + + return 0; +} + +static int cpuhp_dtpm_cpu_online(unsigned int cpu) +{ + struct dtpm *dtpm; + struct dtpm_cpu *dtpm_cpu; + struct cpufreq_policy *policy; + struct em_perf_domain *pd; + char name[CPUFREQ_NAME_LEN]; + int ret = -ENOMEM; + + policy = cpufreq_cpu_get(cpu); + + if (!policy) + return 0; + + pd = em_cpu_get(cpu); + if (!pd) + return -EINVAL; + + dtpm = per_cpu(dtpm_per_cpu, cpu); + if (dtpm) + return power_add(dtpm, pd); + + dtpm = dtpm_alloc(&dtpm_ops); + if (!dtpm) + return -EINVAL; + + dtpm_cpu = kzalloc(sizeof(dtpm_cpu), GFP_KERNEL); + if (!dtpm_cpu) + goto out_kfree_dtpm; + + dtpm->private = dtpm_cpu; + dtpm_cpu->cpu = cpu; + + for_each_cpu(cpu, policy->related_cpus) + per_cpu(dtpm_per_cpu, cpu) = dtpm; + + sprintf(name, "cpu%d", dtpm_cpu->cpu); + + ret = dtpm_register(name, dtpm, __parent); + if (ret) + goto out_kfree_dtpm_cpu; + + ret = power_add(dtpm, pd); + if (ret) + goto out_dtpm_unregister; + + ret = freq_qos_add_request(&policy->constraints, + &dtpm_cpu->qos_req, FREQ_QOS_MAX, + pd->table[pd->nr_perf_states - 1].frequency); + if (ret) + goto out_power_sub; + + return 0; + +out_power_sub: + power_sub(dtpm, pd); + +out_dtpm_unregister: + dtpm_unregister(dtpm); + dtpm_cpu = NULL; + dtpm = NULL; + +out_kfree_dtpm_cpu: + for_each_cpu(cpu, policy->related_cpus) + per_cpu(dtpm_per_cpu, cpu) = NULL; + kfree(dtpm_cpu); + +out_kfree_dtpm: + kfree(dtpm); + return ret; +} + +int dtpm_register_cpu(struct dtpm *parent) +{ + __parent = parent; + + return cpuhp_setup_state(CPUHP_AP_DTPM_CPU_ONLINE, + "dtpm_cpu:online", + cpuhp_dtpm_cpu_online, + cpuhp_dtpm_cpu_offline); +} diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index bc56287a1ed1..72fd8db62342 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -192,6 +192,7 @@ enum cpuhp_state { CPUHP_AP_ONLINE_DYN_END = CPUHP_AP_ONLINE_DYN + 30, CPUHP_AP_X86_HPET_ONLINE, CPUHP_AP_X86_KVM_CLK_ONLINE, + CPUHP_AP_DTPM_CPU_ONLINE, CPUHP_AP_ACTIVE, CPUHP_ONLINE, }; diff --git a/include/linux/dtpm.h b/include/linux/dtpm.h index 7a1d0b50e334..e80a332e3d8a 100644 --- a/include/linux/dtpm.h +++ b/include/linux/dtpm.h @@ -72,4 +72,6 @@ void dtpm_unregister(struct dtpm *dtpm); int dtpm_register(const char *name, struct dtpm *dtpm, struct dtpm *parent); +int dtpm_register_cpu(struct dtpm *parent); + #endif