From patchwork Mon Dec 7 19:26:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D29C4167B for ; Mon, 7 Dec 2020 19:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 684CF2396F for ; Mon, 7 Dec 2020 19:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbgLGTaE (ORCPT ); Mon, 7 Dec 2020 14:30:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgLGTaC (ORCPT ); Mon, 7 Dec 2020 14:30:02 -0500 X-Greylist: delayed 129 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 07 Dec 2020 11:29:22 PST Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A135BC061793; Mon, 7 Dec 2020 11:29:22 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 31FE924008B; Mon, 7 Dec 2020 20:29:21 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 280D43280304; Mon, 7 Dec 2020 20:29:21 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 01/12] media: atomsip: Convert comments to C99 initializers Date: Mon, 7 Dec 2020 20:26:27 +0100 Message-Id: <20201207192638.15219-2-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The struct initalizers have been changed as recommended on https://kernelnewbies.org/KernelJanitors/Todo Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index b4f53be18e7f..af61d05e88d3 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -31,33 +31,33 @@ static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES]; * @brief VBUF resource pool - refpool */ static struct ia_css_rmgr_vbuf_pool refpool = { - false, /* copy_on_write */ - false, /* recycle */ - 0, /* size */ - 0, /* index */ - NULL, /* handles */ + .copy_on_write = false, + .recycle = false, + .size = 0, + .index = 0, + .handles = NULL, }; /* * @brief VBUF resource pool - writepool */ static struct ia_css_rmgr_vbuf_pool writepool = { - true, /* copy_on_write */ - false, /* recycle */ - 0, /* size */ - 0, /* index */ - NULL, /* handles */ + .copy_on_write = true, + .recycle = false, + .size = 0, + .index = 0, + .handles = NULL, }; /* * @brief VBUF resource pool - hmmbufferpool */ static struct ia_css_rmgr_vbuf_pool hmmbufferpool = { - true, /* copy_on_write */ - true, /* recycle */ - 32, /* size */ - 0, /* index */ - NULL, /* handles */ + .copy_on_write = true, + .recycle = true, + .size = 32, + .index = 0, + .handles = NULL, }; struct ia_css_rmgr_vbuf_pool *vbuf_ref = &refpool; From patchwork Mon Dec 7 19:26:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC79C433FE for ; Mon, 7 Dec 2020 19:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7394238E1 for ; Mon, 7 Dec 2020 19:31:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgLGTbW (ORCPT ); Mon, 7 Dec 2020 14:31:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbgLGTbW (ORCPT ); Mon, 7 Dec 2020 14:31:22 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4DC7C0617B0; Mon, 7 Dec 2020 11:30:41 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 52A9B240DFC; Mon, 7 Dec 2020 20:29:59 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 508553280304; Mon, 7 Dec 2020 20:29:59 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning Date: Mon, 7 Dec 2020 20:26:30 +0100 Message-Id: <20201207192638.15219-4-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Use the automatically defined __func__ macro instead of the function name, so it stays correct when the function is renamed. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index 4ba5b8f88a7d..3fb3c8c48f0b 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -119,8 +119,7 @@ void ia_css_rmgr_refcount_retain_vbuf(struct ia_css_rmgr_vbuf_handle **handle) void ia_css_rmgr_refcount_release_vbuf(struct ia_css_rmgr_vbuf_handle **handle) { if ((!handle) || ((*handle) == NULL) || (((*handle)->count) == 0)) { - ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, - "ia_css_rmgr_refcount_release_vbuf() invalid arguments!\n"); + ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, "%s invalid arguments!\n", __func__); return; } /* decrease reference count */ @@ -175,10 +174,9 @@ void ia_css_rmgr_uninit_vbuf(struct ia_css_rmgr_vbuf_pool *pool) { u32 i; - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "ia_css_rmgr_uninit_vbuf()\n"); + ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "%s\n", __func__); if (!pool) { - ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, - "ia_css_rmgr_uninit_vbuf(): NULL argument\n"); + ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, "%s NULL argument\n", __func__); return; } if (pool->handles) { From patchwork Mon Dec 7 19:26:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 305D2C4167B for ; Mon, 7 Dec 2020 19:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E52F62399A for ; Mon, 7 Dec 2020 19:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgLGTbH (ORCPT ); Mon, 7 Dec 2020 14:31:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbgLGTbH (ORCPT ); Mon, 7 Dec 2020 14:31:07 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB11DC061749; Mon, 7 Dec 2020 11:30:26 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 7783E240EB5; Mon, 7 Dec 2020 20:30:25 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 755B13280304; Mon, 7 Dec 2020 20:30:25 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 05/12] media: atomisp: Fix overlong line Date: Mon, 7 Dec 2020 20:26:32 +0100 Message-Id: <20201207192638.15219-6-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Line length of 105 exceeds 100 columns. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index e4483d41ec7a..e4ce8bbacd54 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -294,7 +294,8 @@ void ia_css_rmgr_acq_vbuf(struct ia_css_rmgr_vbuf_pool *pool, } if ((*handle)->vptr == 0x0) { /* we need to allocate */ - (*handle)->vptr = hmm_alloc((*handle)->size, HMM_BO_PRIVATE, 0, NULL, 0); + (*handle)->vptr = hmm_alloc((*handle)->size, + HMM_BO_PRIVATE, 0, NULL, 0); } else { /* we popped a buffer */ return; From patchwork Mon Dec 7 19:26:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A991C1B0D8 for ; Mon, 7 Dec 2020 19:32:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4389B238D7 for ; Mon, 7 Dec 2020 19:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbgLGTby (ORCPT ); Mon, 7 Dec 2020 14:31:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726841AbgLGTbx (ORCPT ); Mon, 7 Dec 2020 14:31:53 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67384C061285; Mon, 7 Dec 2020 11:31:13 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id B8E8E240F0A; Mon, 7 Dec 2020 20:30:30 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id B5B553280304; Mon, 7 Dec 2020 20:30:30 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 08/12] media: atomisp: Delete braces Date: Mon, 7 Dec 2020 20:26:35 +0100 Message-Id: <20201207192638.15219-9-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org WARNING:BRACES: braces {} are not necessary for single statement blocks Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c b/drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c index 00b54a0613bb..08f5c3ea6d29 100644 --- a/drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c +++ b/drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c @@ -23,9 +23,7 @@ int ia_css_timer_get_current_tick(struct ia_css_clock_tick *curr_ts) { assert(curr_ts); if (!curr_ts) - { return -EINVAL; - } curr_ts->ticks = (clock_value_t)gp_timer_read(GP_TIMER_SEL); return 0; } From patchwork Mon Dec 7 19:26:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B5C9C1B0E3 for ; Mon, 7 Dec 2020 19:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBA59238D7 for ; Mon, 7 Dec 2020 19:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbgLGTcA (ORCPT ); Mon, 7 Dec 2020 14:32:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbgLGTcA (ORCPT ); Mon, 7 Dec 2020 14:32:00 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B2C1C061257; Mon, 7 Dec 2020 11:31:17 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 77DF5241006; Mon, 7 Dec 2020 20:30:34 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 6C34B3280304; Mon, 7 Dec 2020 20:30:33 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Date: Mon, 7 Dec 2020 20:26:37 +0100 Message-Id: <20201207192638.15219-11-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c index 38f86764ccfc..7f4592565af6 100644 --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c @@ -105,8 +105,8 @@ int ia_css_spctrl_load_fw(sp_ID_t sp_id, ia_css_spctrl_cfg *spctrl_cfg) void sh_css_spctrl_reload_fw(sp_ID_t sp_id) { /* now we program the base address into the icache and - * invalidate the cache. - */ + * invalidate the cache. + */ sp_ctrl_store(sp_id, SP_ICACHE_ADDR_REG, (hrt_data)spctrl_cofig_info[sp_id].code_addr); sp_ctrl_setbit(sp_id, SP_ICACHE_INV_REG, SP_ICACHE_INV_BIT); From patchwork Mon Dec 7 19:26:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8076BC2BBCF for ; Mon, 7 Dec 2020 19:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57E55238A0 for ; Mon, 7 Dec 2020 19:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgLGTcE (ORCPT ); Mon, 7 Dec 2020 14:32:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbgLGTcD (ORCPT ); Mon, 7 Dec 2020 14:32:03 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 892D1C061794; Mon, 7 Dec 2020 11:31:23 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 92F4624100E; Mon, 7 Dec 2020 20:30:37 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 8D30A3280304; Mon, 7 Dec 2020 20:30:36 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 11/12] media: atomisp: Write function decleration in one line Date: Mon, 7 Dec 2020 20:26:38 +0100 Message-Id: <20201207192638.15219-12-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/queue/src/queue.c | 44 +++++-------------- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c index aea6c66a3cee..2f1c2df59f71 100644 --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c @@ -22,9 +22,7 @@ /***************************************************************************** * Queue Public APIs *****************************************************************************/ -int ia_css_queue_local_init( - ia_css_queue_t *qhandle, - ia_css_queue_local_t *desc) +int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) { if (NULL == qhandle || NULL == desc || NULL == desc->cb_elems || NULL == desc->cb_desc) { @@ -43,9 +41,7 @@ int ia_css_queue_local_init( return 0; } -int ia_css_queue_remote_init( - ia_css_queue_t *qhandle, - ia_css_queue_remote_t *desc) +int ia_css_queue_remote_init(ia_css_queue_t *qhandle, ia_css_queue_remote_t *desc) { if (NULL == qhandle || NULL == desc) { /* Invalid parameters, return error*/ @@ -69,8 +65,7 @@ int ia_css_queue_remote_init( return 0; } -int ia_css_queue_uninit( - ia_css_queue_t *qhandle) +int ia_css_queue_uninit(ia_css_queue_t *qhandle) { if (!qhandle) return -EINVAL; @@ -84,9 +79,7 @@ int ia_css_queue_uninit( return 0; } -int ia_css_queue_enqueue( - ia_css_queue_t *qhandle, - uint32_t item) +int ia_css_queue_enqueue(ia_css_queue_t *qhandle, uint32_t item) { int error = 0; @@ -143,9 +136,7 @@ int ia_css_queue_enqueue( return 0; } -int ia_css_queue_dequeue( - ia_css_queue_t *qhandle, - uint32_t *item) +int ia_css_queue_dequeue(ia_css_queue_t *qhandle, uint32_t *item) { int error = 0; @@ -200,9 +191,7 @@ int ia_css_queue_dequeue( return 0; } -int ia_css_queue_is_full( - ia_css_queue_t *qhandle, - bool *is_full) +int ia_css_queue_is_full(ia_css_queue_t *qhandle, bool *is_full) { int error = 0; @@ -234,9 +223,7 @@ int ia_css_queue_is_full( return -EINVAL; } -int ia_css_queue_get_free_space( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_free_space(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; @@ -268,9 +255,7 @@ int ia_css_queue_get_free_space( return -EINVAL; } -int ia_css_queue_get_used_space( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_used_space(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; @@ -302,10 +287,7 @@ int ia_css_queue_get_used_space( return -EINVAL; } -int ia_css_queue_peek( - ia_css_queue_t *qhandle, - u32 offset, - uint32_t *element) +int ia_css_queue_peek(ia_css_queue_t *qhandle, u32 offset, uint32_t *element) { u32 num_elems = 0; int error = 0; @@ -354,9 +336,7 @@ int ia_css_queue_peek( return -EINVAL; } -int ia_css_queue_is_empty( - ia_css_queue_t *qhandle, - bool *is_empty) +int ia_css_queue_is_empty(ia_css_queue_t *qhandle, bool *is_empty) { int error = 0; @@ -388,9 +368,7 @@ int ia_css_queue_is_empty( return -EINVAL; } -int ia_css_queue_get_size( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_size(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; From patchwork Mon Dec 7 19:26:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 339342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE49CC433FE for ; Mon, 7 Dec 2020 19:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 691C7238E1 for ; Mon, 7 Dec 2020 19:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725874AbgLGTkQ (ORCPT ); Mon, 7 Dec 2020 14:40:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgLGTkQ (ORCPT ); Mon, 7 Dec 2020 14:40:16 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C077C061794 for ; Mon, 7 Dec 2020 11:39:36 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id B05F8240BD5 for ; Mon, 7 Dec 2020 20:39:34 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id DEB773280304; Mon, 7 Dec 2020 20:30:39 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-kernel@i4.cs.fau.de Subject: [PATCH 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Date: Mon, 7 Dec 2020 20:26:39 +0100 Message-Id: <20201207192638.15219-13-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> References: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c index 2f1c2df59f71..7d44070c7114 100644 --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c @@ -24,8 +24,8 @@ *****************************************************************************/ int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) { - if (NULL == qhandle || NULL == desc - || NULL == desc->cb_elems || NULL == desc->cb_desc) { + if (NULL == qhandle || NULL == desc || + NULL == desc->cb_elems || NULL == desc->cb_desc) { /* Invalid parameters, return error*/ return -EINVAL; }