From patchwork Mon Jan 25 03:55:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathew McBride X-Patchwork-Id: 370180 Delivered-To: patch@linaro.org Received: by 2002:a02:a60d:0:0:0:0:0 with SMTP id c13csp3622461jam; Sun, 24 Jan 2021 19:57:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4gYbdjNnPyQuwzlSmM87MjZkkWHI4R17V3FXdPxm1Unxfnqv4SNTtZkVhgFxLA8G0yMmU X-Received: by 2002:a17:906:af41:: with SMTP id ly1mr281776ejb.491.1611547039366; Sun, 24 Jan 2021 19:57:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611547039; cv=none; d=google.com; s=arc-20160816; b=xCk7Q7fPWZmPHGpNMfJ9L5W2/GqPCns2azyIVOQ0N9zHfUTjTAyur2FyOkaggPFvs1 nmVX89ShdyIT7aSdcnvBuNAlv+jNsxfrwyvB58kO7WspVRligKN3ZwxdbMSu+s1CdZ+X gvk7aWa/+r/abP54DOCWNh41wEpR9ctGdRqEmffE8ZmoqExWy6Ozu39MDCNtIbdVshRL eDbtW0oJ322TFDCNG/GEC+AIGz9QGGDU0md+TW+qhdddJwiwvMaaxu0N7O2LtbBxSQ7Q hNa5y1gVAkll+54igT5cCLY+QscNkDF+fpP+D6/NokhV36qIeLe86FHdsW+QH8AEIBi4 NoWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=B5MexJR5lZYGMuBRGtASxjTfdSh4xd17HDFHOkC3TGg=; b=hezze6ZOSB+MDCQjdN6MWcT1m76hKlLMIzvSnix8SfcSHtsiJ+t6MrRqVVgV5dFuYB j34uy3wR28G8K/XdeSxo2upGnGp3LUEbs5XPnkPKuPGK6/ZtkipVSxSurJGmxCARWUcd MIbsF0qNPhZwPugjzUoKQbumnrYt2SDalAw2VJVQ0hq1LDL+bqeB5sZ/UfiFYgSaEKyp KCeU4qP2hZF8hVBEFz0xR+MxAsFh2QKtgRkfHhrEhlAVbwRVoFJJHzRPX7q0gDXi/KlB S+Tano1DjHJvct7YkumhTCAgLaJ7/Rb+hEJ5l/ulYMDzDlCfHamaaiqUZL9C0RAQN5ha VMGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@traverse.com.au header.s=fm2 header.b="QQ/kMXEI"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="NXE1IYg/"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id d7si6771521edv.185.2021.01.24.19.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jan 2021 19:57:19 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@traverse.com.au header.s=fm2 header.b="QQ/kMXEI"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="NXE1IYg/"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C0234826B1; Mon, 25 Jan 2021 04:57:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=traverse.com.au header.i=@traverse.com.au header.b="QQ/kMXEI"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NXE1IYg/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BACF8826BE; Mon, 25 Jan 2021 04:56:53 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 104E7826A7 for ; Mon, 25 Jan 2021 04:56:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matt@traverse.com.au Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5B8D55C00B8; Sun, 24 Jan 2021 22:56:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 24 Jan 2021 22:56:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=traverse.com.au; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=B5MexJR5lZYGM uBRGtASxjTfdSh4xd17HDFHOkC3TGg=; b=QQ/kMXEIxAd8js8kWW9L0NjI63iVx E811mGDXzNp7K0eIys1ePLTvtgtavYbAWlwGTQDN+J5oDQK1GP3FiaXkUjeCgtxA vaKO5kAj1Gaxm1q1v3gupfyb+iaN2QvAo6q5DSjnxAFhHxozpyTcamLmA25YwKRB R8XAdocwvPAOWmDfB1xZ1mRsao6og+RY98RePj2HDpQJ8NLqbd9VivE+tXyCTset QnlZs7/4Es1WgWF5a2W+xdTu8j2eeHbAv0sZqIh+KyZSSRMEgNVMI3ImkRihQ14p 3SRskGtisl8jys5e0DbpmQ/ljhxe9A5YrDfPnKm37t2yptfwuX1TgUb5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=B5MexJR5lZYGMuBRGtASxjTfdSh4xd17HDFHOkC3TGg=; b=NXE1IYg/ Na1J0IRuciKAAK/nwTX3hlnldZX5oueaRykokAYEEj+B5PMQJqy1izN2NqV3bQZW xFSUviOkroqc7SELi1YLmWOLMu2D+phfTr1s4r+/PnWXLn9IKmAniyc+7XqPnpjo 232LBCa8H/Acno5Fngrwi9m47ahb/mLdhY7dGrQkgKH3KegXkGh4Rp07mqhsgCqw wcJqz+hXdQlU5Xds+zcwHpWpKjVWd/Kk0IDJXjHX6LwAo5TWkhDK8kQsXAwN3JBc yWZ0msWyzsmTl8NpJ9wwhLiKPosP48yKEqRM5NPSxYhYyc3hfGdx1ZVaHNsNdoqY eOTj+pQiaGe+/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrthhhvgif ucfotgeurhhiuggvuceomhgrthhtsehtrhgrvhgvrhhsvgdrtghomhdrrghuqeenucggtf frrghtthgvrhhnpeekleevteelvdduheetgfdvfeelueekffeggeethedtteeljeeivedv gfehjeejheenucfkphepudduledrudejrdduheeirddugedunecuvehluhhsthgvrhfuih iivgepvdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrthhtsehtrhgrvhgvrhhsvgdr tghomhdrrghu X-ME-Proxy: Received: from localhost.localdomain (119-17-156-141.77119c.mel.static.aussiebb.net [119.17.156.141]) by mail.messagingengine.com (Postfix) with ESMTPA id A6D47108005B; Sun, 24 Jan 2021 22:56:48 -0500 (EST) From: Mathew McBride To: u-boot@lists.denx.de, Jagan Teki , Priyanka Jain , Pratyush Yadav Cc: Mathew McBride Subject: [PATCH v2 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x Date: Mon, 25 Jan 2021 03:55:22 +0000 Message-Id: <20210125035521.23466-4-matt@traverse.com.au> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210118235256.29748-1-matt@traverse.com.au> References: <20210118235256.29748-1-matt@traverse.com.au> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The LS1088 requires the same QUADSPI_QURIK_BASE_INTERNAL workaround as the LS208x and also has a 64 byte TX buffer. With the previous settings SPI-NAND reads over AHB were corrupted. Fixes: 91afd36f3802 ("spi: Transform the FSL QuadSPI driver to use the SPI MEM API") Signed-off-by: Mathew McBride --- drivers/spi/fsl_qspi.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) -- 2.30.0 diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index 2a1f3a0c44..f965301d6a 100644 --- a/drivers/spi/fsl_qspi.c +++ b/drivers/spi/fsl_qspi.c @@ -259,14 +259,6 @@ static const struct fsl_qspi_devtype_data ls1021a_data = { .little_endian = false, }; -static const struct fsl_qspi_devtype_data ls1088a_data = { - .rxfifo = SZ_128, - .txfifo = SZ_128, - .ahb_buf_size = SZ_1K, - .quirks = QUADSPI_QUIRK_TKT253890, - .little_endian = true, -}; - static const struct fsl_qspi_devtype_data ls2080a_data = { .rxfifo = SZ_128, .txfifo = SZ_64, @@ -877,7 +869,7 @@ static const struct udevice_id fsl_qspi_ids[] = { { .compatible = "fsl,imx7d-qspi", .data = (ulong)&imx7d_data, }, { .compatible = "fsl,imx7ulp-qspi", .data = (ulong)&imx7ulp_data, }, { .compatible = "fsl,ls1021a-qspi", .data = (ulong)&ls1021a_data, }, - { .compatible = "fsl,ls1088a-qspi", .data = (ulong)&ls1088a_data, }, + { .compatible = "fsl,ls1088a-qspi", .data = (ulong)&ls2080a_data, }, { .compatible = "fsl,ls2080a-qspi", .data = (ulong)&ls2080a_data, }, { } };